[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

--- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Hi Sharon,

Thanks for testing! I have made some code changes as per your feedback:

(In reply to Sharon Dugdale from comment #7)
> when merging more than 2 patrons and clicking "keep patrons selected for a
> new operation" does not result in keeping patrons.

The patron you selected to keep should still be selected. However, this was
only working in certain scenarios so I have fixed this and it should now work.
> 
> when merging 2 patrons after clicking on "keep...." then doing a patron
> search for a new list the "Patrons Selected" button says 1 but none are
> selected and none are brought through for a new merge.

This was the same error as above, just presenting itself in a different way.

> 
> when using batch patron modification: after clicking "keep patrons selected
> for a new operation" and you do another patron search and decide you do not
> actually want to keep them, if you then click the button "clear selected" at
> top of the page, choose new patrons you are directed to a message "No patron
> card numbers or borrowernumbers given" When you then click OK you are
> directed to the Batch Patron Modification landing page.

This is a good spot, I've run some tests and this is also happening in our
master branch, not just with this new code I've added. This might need
addressing in a separate bug or there may already be one. I'll have a look and
see if one exists

> 
> when adding 3 patrons to a new list and merging 2 and clicking "keep..." the
> next page shows the "patrons selected" button as 1 but none are selected. If
> you then click on 2 new patrons to merge the "patrons selected" says 3 but
> only the 2 new ones are shown on the next page. I cannot tell if koha is
> also merging the unseen one (the one kept from the merge on the list)

As per the two comments above, this all seems to be stemming from the same
error and should be fixed :)

Let me know if this improves things

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.