[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #152 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #147)
> Oi, so many rebases. Sorry we didn't get to this earlier.
> 
> 1) Can you explain this part of the code please?
> 
> +        my $last_borrowers_to_anonymise =
> $patron->_result->items_last_borrowers->search(
> +            {
> +                (
> +                    $older_than_date
> +                    ? ( created_on => { '<' =>
> $dtf->format_datetime($older_than_date) } )
> +                    : (),
> +                    "itemnumber.damaged"   => 0,
> +                    "itemnumber.itemlost"  => 0,
> +                    "itemnumber.withdrawn" => 0,
> +                ),
> +            },
> +            { join => ['itemnumber'] }
> +        );

This fetches the items_last_borrower rows to anonymise, joining to the items
table to avoid removing info from items that are no longer in circulation where
the last borrower is likely to be responsible for that status

> 2) Database updated needs to be reformatted to use the newer template.

OK

> 3) Terminology / System preference naming
> 
> Sorry to be nit-picky about this, but I believe we should stick to the
> standard terminology as per our coding guidelines:
> 
> * Use AE instead of BE: Anonymise should be Anonymize
> * Borrower should be Patron
> 
> AnonymiseLastBorrower => AnonymizeLastPatron
> AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days
> 
> System preference descriptions need to be adapted as well.

changed 'ise' to 'ize'
As the table is 'items_last_borrower' and we are referring to 'the patron that
last borrowed' I think borrower actually makes more sense in this case

> 4) Cronjob
> 
> +use strict;
> +use warnings;
> 
> --> should be Use Modern::Perl.

OK


> 5) anonymise_issue_history appears to be unused?

It looks like this has been through multiple coders and revisions - all
squashed - unused routine removed

-- 
You are receiving this mail because:
You are watching all bug changes.