[Koha-bugs] [Bug 35431] New: TransportCostMatrix should be checked after HoldsQueuePrioritizeBranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35431

            Bug ID: 35431
           Summary: TransportCostMatrix should be checked after
                    HoldsQueuePrioritizeBranch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Current behavior is:
LocalHoldsPriority is checked if enabled
Item level holds are filled if possible
Now we loop requests:
 - We check if there are items held at the pickup branch
   - We check if these items HoldsQueuePrioritizeBranch match the patron branch
 - Otherwise we check the transport cost matrix
 - continued checks

The correct behavior would be
Now we loop requests:
 - We check if there are items held at the pickup branch
   - We check if these items HoldsQueuePrioritizeBranch match the patron branch
 - We check the transport cost matrix
 - continued checks

The difference being that if we can't fill a hold by match
HoldsQueuePrioritizeBranch we should next check the matrix, not skip it.

The matrix, if enabled, will select where the holding and pickup library match
(as it is the least cost transfer to not transfer) and HoldsQueuePrioritize
branch doesn't match, so we want this fallback

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.