From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 08:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 06:17:08 +0000 Subject: [Koha-bugs] [Bug 33947] Move GetAllIssues to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 08:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 06:17:10 +0000 Subject: [Koha-bugs] [Bug 33947] Move GetAllIssues to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152195|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 156444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156444&action=edit Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 15:05:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 13:05:39 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #11 from Katrin Fischer --- (In reply to Agnes Rivers-Moore from comment #10) > Librarian point of view - > As M Tomsett says, this method cannot work properly without an email > address. The email field should not be required - especially now with so > many countries requiring specific opt-in permission from the user to send > them email. > However, it should be possible for people to use online services without > giving an email address. > I agree with Marcel that the ideal solution is to have the user enter > password (hidden, twice for verification) in the registration form. Then, > let the email address be optional, as a library set preference. The problem with an optional email address on self registration is that you have no means to verify that the user registering is a real person. It would open self registrations up to bots and pranks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 15:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 13:17:54 +0000 Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don't use OPAC description if message type is OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:16:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:16:28 +0000 Subject: [Koha-bugs] [Bug 19703] Some items have the incorrect item type displayed in the 'Most popular' section in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I believe this is the intended behavior right now - showing the itemtype from biblio level. Please re-open if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:18:26 +0000 Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 --- Comment #20 from Katrin Fischer --- Would be great to see this one revived. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:23:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:23:32 +0000 Subject: [Koha-bugs] [Bug 19723] Use tab key to navigate only in subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I just tested and the tab brings you from subfield to subfield, unless the field can be repeated, then the tabs will jump to these controls before it jumps to the next subfield. This seems the logical sequence to me. Thinking of accessibility I believe the controls need to be included as they would otherwise be not reachable/associated with the subfield correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:25:08 +0000 Subject: [Koha-bugs] [Bug 19727] Make it possible to change callnumber in items when biblio-level callnumber is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Editing call number in |Make it possible to change |bibliographic record don't |callnumber in items when |follow in the item record |biblio-level callnumber is | |changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:30:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:30:02 +0000 Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML link element in last breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Katrin Fischer --- It looks like we resolved this when re-working the breadcrumbs fro accessibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:53:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:53:28 +0000 Subject: [Koha-bugs] [Bug 19742] Differentiate possible number of renewals at the OPAC from those at the Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I think the seen/unseen holds feature covers this now :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:58:59 +0000 Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE(DUE notices to take calendar into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option for PREDUE |Add option for PREDUE(DUE |notices to take calendar |notices to take calendar |into account |into account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 16:59:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 14:59:12 +0000 Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE and DUE notices to take calendar into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option for PREDUE(DUE |Add option for PREDUE and |notices to take calendar |DUE notices to take |into account |calendar into account Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:05:32 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- All depending bugs have been resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:13:28 +0000 Subject: [Koha-bugs] [Bug 19811] Preventing runaway processes bringing down Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I think overall this sounds more like a system administration/hardware issue. So something that should likely be solved outside of Koha. Please re-open if you disagree. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:15:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:15:28 +0000 Subject: [Koha-bugs] [Bug 19815] Replace Record via Z39.50 Server give option to change framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19815 --- Comment #1 from Katrin Fischer --- The 'replace' feature brings up the normal Z39.50 search - in which step would you place the framework selection and should/could it apply to normal catalouging as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:16:16 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #11 from Katrin Fischer --- Now that the depending bugs are done - could we resume here? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:18:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:18:42 +0000 Subject: [Koha-bugs] [Bug 19836] Make it possible to change the last pick-up date manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This is now possible from the holds tab of the record (not yet from the patron account) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:21:41 +0000 Subject: [Koha-bugs] [Bug 19844] Z39.50 additional fields for authorities in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 28166 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:21:41 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca --- Comment #26 from Katrin Fischer --- *** Bug 19844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:24:34 +0000 Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852 --- Comment #5 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:28:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:28:45 +0000 Subject: [Koha-bugs] [Bug 19861] Add warn to About page if patron category in PatronSelfRegistrationDefaultCategory is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I think this is remedied now by using the multi-select instead of a text field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:29:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:29:49 +0000 Subject: [Koha-bugs] [Bug 19863] Add 'save and continue' option when editing authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add more save options when |Add 'save and continue' |edditing authorities |option when editing | |authorities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:31:13 +0000 Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #11 from Katrin Fischer --- (In reply to Owen Leonard from comment #10) > I can't reproduce this bug either. Besides, the non-XSLT view is deprecated. The non-XSLT view has since been removed. Closing WONTFIX. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:33:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:33:51 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|Patch doesn't apply |RESOLVED --- Comment #60 from Katrin Fischer --- Bug 21206 removed GetItem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:36:23 +0000 Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC advanced search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19891 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:36:23 +0000 Subject: [Koha-bugs] [Bug 19891] itemtypecat should show categories in refine search (facets) and item details, not itypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32258 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:37:44 +0000 Subject: [Koha-bugs] [Bug 19629] No translatable notification in overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19912 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 17:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 15:37:44 +0000 Subject: [Koha-bugs] [Bug 19912] PrintNoticesMaxLines message should print after list of items not at end of notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19629 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 18:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 16:42:27 +0000 Subject: [Koha-bugs] [Bug 33947] Move GetAllIssues to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 18:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 16:42:30 +0000 Subject: [Koha-bugs] [Bug 33947] Move GetAllIssues to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156444|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 156445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156445&action=edit Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 19:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 17:26:15 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 19:26:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 17:26:19 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154316|0 |1 is obsolete| | --- Comment #50 from David Nind --- Created attachment 156446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156446&action=edit Bug 12133: Add requirements for guarantor and guarantee Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Test plan: 1. Add a child patron without guarantor or child patron with guarantee as guarantor succesfully. 2. Apply this patch. 3. Add a child patron as a guarantor. => Error is raised. 4. Turn syspref "ChildNeedsGuarantor" ON. 5. Add a child patron without a guarantor and error "Child needs a guarantor" is raised. 6. Add guarantor. Guarantor can either be existing patron or added with "Contact" section. => Save without errors. Also prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 19:26:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 17:26:23 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156387|0 |1 is obsolete| | --- Comment #51 from David Nind --- Created attachment 156447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156447&action=edit Bug 12133: Fix QA issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 19:30:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 17:30:12 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes two release notes| |changes to guarantors and | |guarantees when registering | |a new patron: | | | |- A child | |patron must have a | |guarantor - this is | |controlled by | | the new | |ChildNeedsGuarantor system | |preference. | |- A guarantor | |cannot be a guarantee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 20:13:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 18:13:32 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34886 --- Comment #52 from David Nind --- I'm not getting the expected results for the 'On shelf holds allowed', both before and after the patch is applied. Maybe this is something to do with Bug 34886 - Regression in when hold button appears? Set up: - Changed the circulation and fines rules for all patron categories and item types (basically, just used one rule) - Used Mary Burton as the patron Before the patch is applied, I am getting this behavour: - On shelf holds allowed: Yes . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: can place a hold - On shelf holds allowed: If any unavailable . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: no 'Place hold' option - On shelf holds allowed: If all unavailable . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: no 'Place hold' option After the patch is applied, I am getting this behavour: - On shelf holds allowed: Yes . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: can place a hold - On shelf holds allowed: If any unavailable . Not logged in to OPAC: can place a hold . Logged in to OPAC: no 'Place hold' option - On shelf holds allowed: If all unavailable . Not logged in to OPAC: can place a hold . Logged in to OPAC: no 'Place hold' option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 20:13:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 18:13:32 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:07:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:07:01 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #22 from David Nind --- Hi Lucas. I tried a few other areas, and this seemed to work OK: acquisitions, statistics reports, calendar tool, log viewer, patron categories, circulate and fine rules, budgets. One area that didn't work was on the add or edit item forms (these use the dateaccessioned.pl plugin). Should it work here? Also, there is no license information on the About > Licenses page. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:11:36 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Hi Kristi. I think you've signed this off, but the status needs changing. Could you change the status to signed off? (This also means that you will get credit on the dashboard under the sign-offs section https://dashboard.koha-community.org/ ) David Nind New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:39:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:39:11 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:39:13 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155662|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156448&action=edit Bug 34801: Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) __() should be used in .js files, not .tt files To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find the lines in the commit Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:49:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:49:55 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. po/fr-FR-staff-prog.po - 'Account has been deleted' was added to the .po file (no occurrence before patch applied). 2. po/fr-FR-opac-bootstrap.po - 'No title' was already in the .po file before applying the patch - an additional line was added after the patch was applied (#: koha-tmpl/opac-tmpl/bootstrap/en/includes/js-biblio-format.inc:1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 19:57:53 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Are you able to add a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:08:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:08:33 +0000 Subject: [Koha-bugs] [Bug 20024] Backup files should be encrypted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- I'll add my voice to this being a system administration task. If you move your files to another server for backup (which is a good idea), you can also encrypt them in the process. As always: please re-open if you disagree! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:08:34 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 20024, which changed state. Bug 20024 Summary: Backup files should be encrypted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:11:04 +0000 Subject: [Koha-bugs] [Bug 20027] Generate password at patron detail edit page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 --- Comment #2 from Katrin Fischer --- Can you explain the use case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:12:26 +0000 Subject: [Koha-bugs] [Bug 20046] Reconfigure Z39.50 authority search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change configuration of the |Reconfigure Z39.50 |authorities z39.50 search |authority search form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:15:40 +0000 Subject: [Koha-bugs] [Bug 26934] SIP2 allows checkin of already checked in item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20059 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:15:40 +0000 Subject: [Koha-bugs] [Bug 20059] Option to allow checkin of non-issued items without setting SIP-alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26934 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:18:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:18:58 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #11 from Katrin Fischer --- This has been reported against a now very old version of Koha and we haven't been able to reproduce the issue. Closing, but please re-open if you still experience this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:21:20 +0000 Subject: [Koha-bugs] [Bug 20096] Regarding duplicate data in statistics and logs data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I think this is 'too late' to be fixed. People do reporting on both tables and it doesn't hurt to have both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:24:25 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Hi Zeno. I'm not seeing the error. This what I see: ... Dati per la localiozzazione aggiunti * custom.sql L'installazione di base è completa. Nei prossimi passi sarete guidati a fare alcuni punti fondamentali, tra cui l'utente di gestione con tutti i privilegi amministrativi (superlibrarian). Puoi aiutare la comunità di Koha condividendo le tue statistiche con noi. Se vuoi condividere alcuni tuoi dati, attiva la funzionalità nella sezione "Condividi statistiche d'uso" del modulo di amministrazione. ... Here are my testing notes (so far) using koha-testing-docker (KTD) (note that KTD uses MARIA DB in strict mode by default): 1. Install the it-IT language: 1.1 cd misc/translator 1.2 ./translate update it-IT 1.3 ./translate install it-IT 2. Test the web installer: 2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1 2.2 Drop the koha_kohadev database: drop database koha_kohadev; 2.3 Create the database: create database koha_kohadev; 2.4 Add privileges (for a real installation, this would be limited): grant all on 2.5 koha_kohadev.* to koha_kohadev; 2.6 Restart everything (there may be some errors listed): flush_memcached and then restart_all 2.7 Access the web installer: go to 127.0.0.1:8081 2.8 Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 2.9 Continue through the installation process In addition, your commit message needs to be formatted using these guidelines: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:30:39 +0000 Subject: [Koha-bugs] [Bug 20143] Allow separate system preferences for Self Checkout specific to Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20143 --- Comment #2 from Katrin Fischer --- Did you mean the web based self checkout or SIP? For SIP the AllowFineOverride is solved in the SIP XML configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:32:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:32:20 +0000 Subject: [Koha-bugs] [Bug 20027] Generate password at patron detail edit page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 --- Comment #3 from Michal Denar --- Hi, There is a link on the password change page that, when clicked, will generate a random password. https://snipboard.io/WFbicx.jpg It would be great to have the same option on the page where you edit the reader details, and the login and password are there too. The option to generate a random password is now missing there: https://snipboard.io/h2oPbH.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:33:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:33:39 +0000 Subject: [Koha-bugs] [Bug 20159] Acq: Allow to change discount on receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20159 --- Comment #1 from Katrin Fischer --- Reading this now I wonder how it would work. Should it still adjust the estimated cost? Would it be used for statistics? It would not influence the actual cost. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:44:20 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:44:23 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156377|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156449&action=edit Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:47:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:47:50 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Created attachment 156450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156450&action=edit Screenshot - Send cart and lists pop-up windows I've signed off as they now look much more consistent! However, I did note that for the cart there is a more space before the heading than with the list (see attached image). My CSS is not that great, but maybe this is something to do with the div for the container. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 22:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 20:57:24 +0000 Subject: [Koha-bugs] [Bug 20170] Patron account can be renewed multiple times in a row without noticing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Version|17.05 |master --- Comment #3 from Katrin Fischer --- When you renew from the patron menu, we have a confirmation alert, but when you click the renew link on an already expired account there is no alert. In both cases the page reloads and shows the new exiration date in a message box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:00:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:00:31 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156431|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 156451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156451&action=edit Bug 34689: Ignore itemnumber when creating item hash A primary key error can be thrown when an item number is included in a new title hash. We need the item creation to ignore an itemnumber even if it is included in a MARC Framework Test plan: 1) Edit the MARC framework relating to books (BKS in KTD) 2) In the 952$9 field (Koha itemnumber (autogenerated)), change the value of "Managed in tab" to "items (10)" 3) In the catalog, find a record that uses that MARC framework 4) Click "New" and choose to add a new item 5) Enter a barcode and click the "Add & duplicate" button 6) The page will refresh and an item will have been added 7) Enter a new barcode and click the same button again 8) An error will be thrown 9) Click the back button in the browser 10) Apply patch and restart_all 11) Click the add and duplicate button again 12) This time no error will be thrown and the page will refresh with another new item added 13) Sign off! Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:05:24 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:08:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:08:11 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #14 from Katrin Fischer --- I am not sure how to test this - can someone tell if it's still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:13:21 +0000 Subject: [Koha-bugs] [Bug 20184] Posibility to add a box to enter a specific page number in authorities result search. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20183 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:13:21 +0000 Subject: [Koha-bugs] [Bug 20183] Posibility to change the number of results shown by default in authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20184 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:17:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:17:20 +0000 Subject: [Koha-bugs] [Bug 20192] ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master --- Comment #4 from Katrin Fischer --- I believe it would be an option to use the REST API now - should this be closed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:18:17 +0000 Subject: [Koha-bugs] [Bug 20202] Link EDI account to Create EDI order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Link EDI account to Create |Link EDI account to Create |Edi order |EDI order CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Katrin Fischer --- Martin, can you maybe say something about this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:19:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:19:31 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Katrin Fischer --- I like this idea - where should we link to and how should we phrase it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:22:41 +0000 Subject: [Koha-bugs] [Bug 20209] New and improved Koha Serials development specifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32753 Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Bug 32753 covers the first and I believe SubscriptionHistory / opacSerialDefaultTab cover the second. Pleaes re-open if I missed something! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:22:41 +0000 Subject: [Koha-bugs] [Bug 32753] Add ability to hide some subscriptions from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20209 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:24:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:24:37 +0000 Subject: [Koha-bugs] [Bug 20246] Do not show 773$9 or 773$0 if EasyAnalyticalRecords is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:25:46 +0000 Subject: [Koha-bugs] [Bug 20253] Optionally use buyer's purchase order number from EDIFACT quote in basket name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optionally use buyer's |Optionally use buyer's |purchase order number from |purchase order number from |Edifact quote in basketname |EDIFACT quote in basket | |name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:33:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:33:59 +0000 Subject: [Koha-bugs] [Bug 20289] Unhelpful message on SIP for checkouts blocked by overdue items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unhelpful message on sip |Unhelpful message on SIP |overdrive - Overdue items |for checkouts blocked by | |overdue items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:37:46 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32721 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:37:46 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #61 from Katrin Fischer --- *** Bug 20320 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:38:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:38:40 +0000 Subject: [Koha-bugs] [Bug 20324] Fund warnings do not occur when importing records from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fund Warnings do not occur |Fund warnings do not occur |when importing records from |when importing records from |a staged file |a staged file Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:39:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:39:00 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156448|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 156452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156452&action=edit Bug 34801: Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) __() should be used in .js files, not .tt files To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find the lines in the commit Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:41:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:41:17 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:44:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:44:05 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED --- Comment #13 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #12) > Is this still valid? I feel like the search filters are filtering on > existing search results in master. Can someone please confirm? I believe that the confusion has been removed by renaming the side filters to 'search for patron' and it will show your search term when entered in the search above first. And if you want to filter the search results, you can use the filters on top of the columns or the table one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:46:48 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set their preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 --- Comment #5 from Katrin Fischer --- I feel like this would be a big change as it would require recalculating all amounts displayed to the user according to their selected currency. This is a big amount of work and would only make sense if the library accepts different currencies. Also different exchange rates might apply. Should this be WONTFIX? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:50:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 21:50:18 +0000 Subject: [Koha-bugs] [Bug 20378] OPAC ID and password do not auto-generate for new patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:00:04 +0000 Subject: [Koha-bugs] [Bug 20405] enhanced messaging preference should always be on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com, | |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Katrin Fischer --- We now default EnhancedMessagingPreferences to 1 for new installations. I am not sure if there is a use case where showing the preferences always and by default would be bad. Should we remove the preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:07:21 +0000 Subject: [Koha-bugs] [Bug 20406] Remove ISBD display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #18 from Katrin Fischer --- Reviewing the comments here the vote was quite clear: the ISBD view needs to stay. We could still think about offering an alternative way of defining its contents or at least making sure the syntax is well documented. Closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:07:23 +0000 Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature creep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Bug 20396 depends on bug 20406, which changed state. Bug 20406 Summary: Remove ISBD display https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:11:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:11:37 +0000 Subject: [Koha-bugs] [Bug 20409] Remove OpacBrowseResults system preference and make it always on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409 --- Comment #5 from Katrin Fischer --- We have a lot of switches for OPAC features - I am not sure if this pref hurts anyone - but would be nice to get more opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:13:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:13:41 +0000 Subject: [Koha-bugs] [Bug 20411] Remove StaffDetailItemSelection system preference and make the feature always on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- I'd not be opposed to removing the preference - any opinions on this one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:39:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 22:39:35 +0000 Subject: [Koha-bugs] [Bug 20628] Search result highlighting doesn't work for searches using CCL syntax including truncation/phrase etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search result highlighting |Search result highlighting |not working with truncated |doesn't work for searches |search terms |using CCL syntax including | |truncation/phrase etc. --- Comment #2 from Katrin Fischer --- It seems to break when using any 'qualifier' after the search index, like ',phr' or ',rtrn'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:06:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:06:02 +0000 Subject: [Koha-bugs] [Bug 20606] Add the age column to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20606 --- Comment #4 from Katrin Fischer --- Maybe this could be replaced by bug 33013? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:06:39 +0000 Subject: [Koha-bugs] [Bug 20605] Make possible to set patron's privacy from staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make possible to set |Make possible to set |patron's privacy from staff |patron's privacy from staff |client |interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:07:27 +0000 Subject: [Koha-bugs] [Bug 20597] koha-restore 17.x fails to restore dump from 16.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > As we no longer maintain the 17.x versions, should we move this to WONTFIX? 3 years later - closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:13:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:13:07 +0000 Subject: [Koha-bugs] [Bug 20575] Auto-renewals to use current patron category when renewing as opposed to when item was issued. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20575 --- Comment #4 from Katrin Fischer --- I don't think we can resolve this right now as the flag can be set/unset for several reasons (patron doesn't want auto-renewals, manual auto renewal, circulation conditions). Also... libraries might expect different behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:13:14 +0000 Subject: [Koha-bugs] [Bug 20575] Auto-renewals to use current patron category when renewing as opposed to when item was issued. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:16:57 +0000 Subject: [Koha-bugs] [Bug 20553] MARCfindbreeding should be factored out of .pl's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20553 --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:20:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:20:04 +0000 Subject: [Koha-bugs] [Bug 20542] Unresponsive Print Button from Cart in Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Just tested this in the current development version and the print button works after sorting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:27:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:27:05 +0000 Subject: [Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #15 from Katrin Fischer --- I feel like a total removal is out of question for now reading through the comments, but there are some issues about usability with the items tab. I feel like some might have been addressed since this was filed in 2018, but we might still have room for improvement. I suggest to file separate bugs for any single identifiable issue or idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:27:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:27:06 +0000 Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature creep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Bug 20396 depends on bug 20528, which changed state. Bug 20528 Summary: Remove the items tab from the detailed bibliographic view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:30:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:30:20 +0000 Subject: [Koha-bugs] [Bug 20451] Add ability to specify due date to batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This has since been implemented. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:34:08 +0000 Subject: [Koha-bugs] [Bug 20418] Remove UpdateTotalIssuesOnCirc and make it cron everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20418 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19310 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:34:08 +0000 Subject: [Koha-bugs] [Bug 19310] Warning on UpdateTotalIssuesOnCirc should be revisited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20418 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:40:17 +0000 Subject: [Koha-bugs] [Bug 20448] Noise in plugin version comparisons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20448 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #2 from Katrin Fischer --- Tested and confirmed that there is no warning in the current development version. Maybe fixed by bug 23230? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:41:49 +0000 Subject: [Koha-bugs] [Bug 20449] Noise triggered by Archive::Extract during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20449 --- Comment #3 from Katrin Fischer --- There is no clear test plan here, I am not sure how to replicate the reported behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 01:50:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Oct 2023 23:50:05 +0000 Subject: [Koha-bugs] [Bug 20488] Manual renewal due date ignore closed day in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 08:29:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 06:29:05 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 --- Comment #3 from Magnus Enger --- (In reply to David Nind from comment #2) > I'm not sure of the best way to update the nb-NO files - is this handled by > the translation process? Yes it is. Thanks for the fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 08:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 06:55:40 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #4 from Frédéric Demians --- (In reply to David Nind from comment #3) > Are you able to add a test plan? It seems possible, but, for me, now, the test t/db_dependent/OAI/Server.t fails on master. Is it the case for you also? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 08:39:53 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 --- Comment #2 from Magnus Enger --- Would this be a good page to link to? Is it up to date? https://wiki.koha-community.org/wiki/Documentation_-_Contributing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 08:41:02 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 --- Comment #3 from Magnus Enger --- And as for the link, just something simple like a link with the text "How to contribute to this documentation"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:46:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 08:46:22 +0000 Subject: [Koha-bugs] [Bug 33949] Replace GetAllIssues with Koha::Checkouts - opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #8 from Jonathan Druart --- (In reply to David Nind from comment #7) > I've signed off, but I had a couple of questions: Thanks! > 1. I'm not sure where I should be checking for the display of the ISBN and > UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the > indicators)). Sorry, wrong test plan. The UPC is used by BakerTaylor, and the ISBN for the cover images. They are not directly displayed on the UI. > 2. Old checkouts - I was sure how to replicate this issue. After applying > the patch, checking out and checking in an item, things displayed as > expected. This worked the same before the patches were applied. Yes, the second patch is a follow-up for the first patch. It's no fixing a bug that is in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 09:17:13 +0000 Subject: [Koha-bugs] [Bug 29324] Some files still don't have the correct license statement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324 --- Comment #46 from Philip Orr --- Thought about this one a little more over the weekend. Perl files will need the shebang to be the first line. For other files, (I hope) it doesn't matter if copyright/license statements are the first line. What I'm going to try is something like: - if the first line is a shebang, add copyright/license info starting from the second line - if not, add copyright/license info directly from the first line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 09:46:44 +0000 Subject: [Koha-bugs] [Bug 20405] enhanced messaging preference should always be on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20405 --- Comment #2 from Aude Charillon --- I agree the messaging preferences should always be visible in the staff interface. I think there's a case for them not being modifiable by all members of staff (so they don't stray from the patron category defaults) or for only some messaging preferences to be modifiable in the Opac... but those thoughts would be for other bugs!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:03:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 10:03:01 +0000 Subject: [Koha-bugs] [Bug 34927] Adding DMARC compatibility to mailing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34927 --- Comment #4 from Thomas Dukleth --- While there seems to be a consensus for adding DMARC support to all the mailing lists, the development meetings request has been to contact people and see whether someone with access was prepared to do the necessary work to alter the configuration and may be trivial. Explicit blessing for koha-devel and other lists should wait upon the next development meeting where people can be prepared to test the result. We should probably wait until after the next meeting. It may be better to try first with a Biblibre hosted mailing list, such as koha-devel, if it is easier to have attention to revert if a problem is identified and fewer people would be affected adversely. Mailman 2 Configuration. When DMARC is activated we should set both of the following variables. dmarc_is_list set to "Munge From". dmarc_moderation_action set to "Munge From". Preexisting or default values for other DMARC related variables should be fine. Koha General Mailing List. The only particular complaint about lack of DMARC support was for the general Koha mailing list where someone has a work institution which has a strict DMARC policy. The Katipo Mailman 2.1.18 installation maybe somewhat older than the Biblibre Mailman 2.1.26 installation and could use an upgrade but does not seem to have a critical problem for Mailman 2 DMARC support. We could find minor bug 1536816 for some messages in 2.1.18 which was fixed in 2.1.21rc1 is that non-ASCII names pulled from the registered user list when absent in the originating From header. See https://bugs.launchpad.net/mailman/+bug/1536816 . The DNS configuration for lists.katipo.co.nz needs the following line: _dmarc.lists.katipo.co.nz. IN TXT "v=DMARC1; p=none" ... if using BIND as DNS server or the equivalent where the policy is "p=none" matching the Biblibre DNS configuration and allows messages to the mailing list from non-DMARC compliant systems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:23:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 10:23:42 +0000 Subject: [Koha-bugs] [Bug 34671] Collapsing fields in patron form allows saving without mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34671 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156263|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen --- Created attachment 156453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156453&action=edit Bug 34671: Show error message if fieldset has invalid input If fieldset is collapsed and it contains required fields patron can be saved without filling these fields. This patch adds rule ignore as "" in form validation and displayes error message in fieldsets containing missing required inputs. To test: 1. Make sure you have "Main address" fields set as mandatory with BorrowerMandatoryField syspref (address, city, zipcode) 2. Add new patron, fill in some info, but leave "Main address" fields empty. 3. Attempt to save. => "This field is mandatory" should be displayed next to the address fields. 4. Collapse "Main address" fieldset. 5. Attempt to save again. => Patron is saved successfully without address information. 6. Apply this patch. 7. Edit patron and attempt to save again with "Main address" fieldset collapsed. => Error message "There are some required fields missing from this field set. Please fill them." should be displayed and patron isn't saved. 8. Fill missing fields, attempt to save. => Saving should now be successfull. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 10:24:15 +0000 Subject: [Koha-bugs] [Bug 34671] Collapsing fields in patron form allows saving without mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34671 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156264|0 |1 is obsolete| | --- Comment #11 from Emmi Takkinen --- Created attachment 156454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156454&action=edit Bug 34671: Ignore new_guarantor_relationship input if it's hidden adding/modifying guarantee patrons since class new_guarantor_relationship is always hidden and mandatory if syspref "borrowerRelationship" is set. This patch adds class ignore_validation to relationship input if it's hidden to ignore validatation and removes it when input is displayed, so it is validated. To test: 1. Apply previous patch. 2. Add or modify guarantee patron. 3. Do not add or modify guarantor. 4. Attempt to save patron. => Pressing save button does nothing and no error is displayed. 5. Apply this patch. 6. Again add or modify guarantee patron and don't add or modify guarantor. 7. Attempt to save. => Saving should now be successfull. 8. Again, add or modify guarantee patron, but this time also add or modify guarantor. 9. Leave relationship input empty. 10. Attempt to save. => Saving should fail and error "There are some required fields missing..." should be displayed on top of "Patron guarantor" field set. 11. Add relationship for guarantor and save. => Saving should now be successfull. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:31:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 10:31:27 +0000 Subject: [Koha-bugs] [Bug 34671] Collapsing fields in patron form allows saving without mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34671 --- Comment #12 from Emmi Takkinen --- (In reply to Owen Leonard from comment #9) > I would suggest this change to the text: > > "There are some required fields missing from this section. Please complete > them." > > And I think it looks better when the new message appears after the > not before it. Adjusted as suggested. And it does look better now :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 13:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 11:24:34 +0000 Subject: [Koha-bugs] [Bug 34927] Adding DMARC compatibility to mailing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34927 --- Comment #5 from Thomas Dukleth --- Mailman bug 1334450 is another bug which we might find with Mailman 2.1.18 installed at Katipo was fixed in 2.1.19rc1. If a message is held for moderation, dmarc_moderation_action of munge From header is not applied after approval and thus the approved message would not be sent as DMARC. See https://bugs.launchpad.net/mailman/+bug/1334450 . Assuming messages are seldom held for moderation, bug 1334450 is not a problem which should necessarily prevent turning on DMARC for those who need it and are otherwise missing access to the Koha general mailing list from a work environment with a strict DMARC policy. Thus, waiting on upgrade to a more recent version of Mailman at Katipo and/or a possible administrative change to the mailing list provide such time should not be necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 12:12:05 +0000 Subject: [Koha-bugs] [Bug 34971] New: Permission to close a serial subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34971 Bug ID: 34971 Summary: Permission to close a serial subscription Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: pierre.genty at biblibre.com QA Contact: testopia at bugs.koha-community.org Hi, With only receive_serials permission it is possible to close a serial subscription. This should require edit_subscription permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:32:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 12:32:30 +0000 Subject: [Koha-bugs] [Bug 32963] Add ability to enable/disable Acquisitions module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32963 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 12:33:13 +0000 Subject: [Koha-bugs] [Bug 9159] Direct link to favourite vendors on the acq homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9159 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:39:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 12:39:07 +0000 Subject: [Koha-bugs] [Bug 34805] Add order search form to acq start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34805 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 13:07:48 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr --- Comment #13 from Nicolas Legrand --- Some people at the BULAC library would like something like this also :). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 13:45:29 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com --- Comment #4 from Caroline Cyr La Rose --- That link seems to have good information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 14:12:24 +0000 Subject: [Koha-bugs] [Bug 32767] Optionally allow for trimming whitespace from patron attribute values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 --- Comment #10 from Peter Vashchuk --- (In reply to Marcel de Rooy from comment #9) > Oops. Please run QA tools. (You are in QA?) > Failing test and more trouble. Tested on the latest master, QA tools are OK, and tests also seem fine: $> prove t/db_dependent/Koha/Patron/Attribute.t t/db_dependent/Koha/Patron/Attribute.t .. ok All tests successful. Files=1, Tests=3 Result: PASS can you please help me find out what the problem is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:21:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 14:21:46 +0000 Subject: [Koha-bugs] [Bug 20203] Add info about contributing to koha-community.org/documentation/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 --- Comment #5 from Aude Charillon --- Sounds great! I just checked my website powers and I only seem to have access to Posts (not Pages). Can I get more powers to do this myself or would someone else rather do it instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 14:52:36 +0000 Subject: [Koha-bugs] [Bug 20405] enhanced messaging preference should always be on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20405 --- Comment #3 from Caroline Cyr La Rose --- The only case I would see where it *could* be hidden would be a very small library who does not send emails/sms at all, it could clutter up the patron record. But I think those would be very few. I checked our smallest clients (meaning the ones with fewest patrons), and in the ones with under 500 patrons, only one has the pref disabled, a small school. It's a client who has been with us for a while and it was probably before the pref was enabled automatically and we probably did not enable the pref ourselves either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:03:32 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:03:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:03:34 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 --- Comment #1 from Owen Leonard --- Created attachment 156455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156455&action=edit Bug 34961: Add sort parameter to OPAC search results RSS feed link This patch corrects two RSS links in the OPAC search results template so that they include the correct parameters, including the descending sort by acquisition date. To test, apply the patch and go to the OPAC. - Perform a catalog search which will return search results. - Next to the page heading "Your search returned X results" is an RSS link. Check the link to confirm that it has all the expected parameters: opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss - Perform a search which will return no results and check the RSS link on that page. It should be the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:10:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:10:42 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:10:44 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156325|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 156456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156456&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:26:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:26:46 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #12 from Agnes Rivers-Moore --- (In reply to Katrin Fischer from comment #11) > (In reply to Agnes Rivers-Moore from comment #10) > > Librarian point of view - > > As M Tomsett says, this method cannot work properly without an email > > address. The email field should not be required - especially now with so > > many countries requiring specific opt-in permission from the user to send > > them email. > > However, it should be possible for people to use online services without > > giving an email address. > > I agree with Marcel that the ideal solution is to have the user enter > > password (hidden, twice for verification) in the registration form. Then, > > let the email address be optional, as a library set preference. > > The problem with an optional email address on self registration is that you > have no means to verify that the user registering is a real person. It would > open self registrations up to bots and pranks. I am not sure existence of an email address proves a genuine individual or protects from pranking or misuse. If a library needs to prove there is a real person who is not already registered, or banned, or from another country, they would need more than an email address. Our staff see the online registration attempt and contact the person for ID verification. So, library set preference for whether email is required or not. For us, phone number required is more important. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:50:22 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 15:50:24 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 --- Comment #1 from Owen Leonard --- Created attachment 156457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156457&action=edit Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:00:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 16:00:27 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 16:00:29 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #1 from Owen Leonard --- Created attachment 156458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156458&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 16:21:11 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 16:21:13 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 --- Comment #1 from Owen Leonard --- Created attachment 156459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156459&action=edit Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 16:37:41 +0000 Subject: [Koha-bugs] [Bug 10596] Patrons: Make expiration date an option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g --- Comment #1 from Kristi --- This would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 17:26:34 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 17:47:06 +0000 Subject: [Koha-bugs] [Bug 34972] New: Canceling a waiting hold from the holds over tab can make the next hold unfillable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Bug ID: 34972 Summary: Canceling a waiting hold from the holds over tab can make the next hold unfillable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When a staff member cancels a hold by clicking the button in the "holds waiting over 10 days" report, Koha incompletely attempts to assign that item to the next matching hold. Koha assigns the itemnumber to the hold, but does *not* set found status of the hold. Instead, it prompts the staff member, "Please retain this item and check it in to process the hold." This causes a few problems: - The itemnumber is immediately assigned to the hold without an opportunity for staff input, even if HoldsAutoFill is disabled. - If the staff member does not check in the book afterward (whether intentionally or through human error), it leaves the hold in an invalid state: it is tied to the itemnumber, but it is neither "found" nor an item-level hold. - Since the itemnumber is assigned, other items can't fill the hold. However, since the "found" field was never set, the option to "revert waiting status" or "revert transit status" isn't available. Essentially, a bib-level hold is suddenly behaving like an item-level hold, with no way for staff to identify or fix the issue. This is especially a problem if the item is missing from the holds shelf for some reason, and the staff member cancels the waiting hold first and then marks the item "lost". This makes the next-in-line hold unfillable unless the item is found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:29:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 18:29:41 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156456|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 156460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156460&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:30:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 18:30:03 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Victor Grousset/tuxayo --- Thanks, it works :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 18:34:27 +0000 Subject: [Koha-bugs] [Bug 23875] Elasticsearch - When sorting by score we should provide a tiebreaker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30879 --- Comment #17 from Fridolin Somers --- 30879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 18:34:27 +0000 Subject: [Koha-bugs] [Bug 30879] Add option to sort components by biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23875 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:35:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 18:35:39 +0000 Subject: [Koha-bugs] [Bug 23875] Elasticsearch - When sorting by score we should provide a tiebreaker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 --- Comment #18 from Fridolin Somers --- Ah I had issues with local-number sort, found Bug 30879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:09:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:09:23 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g --- Comment #24 from Kristi --- I see this is signed off. This is a system preference our library branches are eager to see in place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:12:41 +0000 Subject: [Koha-bugs] [Bug 33641] We should record return branch in old checkouts (oldissues) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:14:47 +0000 Subject: [Koha-bugs] [Bug 33641] We should record return branch in old checkouts (oldissues) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #1 from Andrew Fuerste-Henry --- +1, This would be helpful data and is not particularly accessible with the current structure. I'm currently trying to write a query to determine how often our items are returned somewhere other than the branch at which they were checked out and the manner in which we record things is making is very difficult. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:25:09 +0000 Subject: [Koha-bugs] [Bug 12769] Manage fees for sending notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4858 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:25:09 +0000 Subject: [Koha-bugs] [Bug 4858] Ability to Charge for Print Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12769 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:26:06 +0000 Subject: [Koha-bugs] [Bug 4871] Debian packaging should use start-stop-daemon, not daemon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:29:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:29:12 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #31 from Katrin Fischer --- I am not sure which bug added it, but we do now have the option to set default values for indicators in the MARC bibliographic framework configuration. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 19:51:22 +0000 Subject: [Koha-bugs] [Bug 10596] Patrons: Make expiration date an option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 --- Comment #2 from Katrin Fischer --- We recently noticed some issues with missing expiration dates - it affected the due date calculations. This might be due to the fact that Koha tries to set the due date before the patron expires, but if we were to make the expiration date optional, this is something that would need a closer look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:04:01 +0000 Subject: [Koha-bugs] [Bug 4990] reintegrate overdues email in overdue list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #11 from Katrin Fischer --- I tried to reintegrate mailto links in the past but ran into issues with complex text and diacritics. I believe if manually generating overdue notices is a requirement, we'd need a new approach. Closing this for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:09:54 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:09:55 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156405|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 156461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156461&action=edit Bug 34939: Set hour:minute to 23:59 when inputing dates unless explicitly set 1. Find some places in the staff interface where data-flatpickr-enable-time is set to true. Examples: renew.tt or circulation.tt 2. Directly input a date in whatever date format you have specified in DateFormat but omit the hour/minute. Example: 12/12/2023 3. See that the hour/minute default to 00:00 if your TimeFormat is 24hr and 12:00 AM if your time format is 12hr 4. Apply patch, clear browser cache. 5. Try step again, setting a date like '12/12/2023'. The hour:minute should be added as 23:59. 6. With TimeFormat set to 24hr try entering a date with the hour:minute like '12/12/2023 11:22'. The hour:minute should be set to 11:22. 7. With TimeFormat set to 12hr try entering a date with the hour:minute like '12/12/2023 11:22 AM'. The hour:minute should be set to 11:22 AM. 8. Play with this in as many TimeFormat and DateFormat combonatinons as you can. Signed-off-by: Kristi Krueger Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:13:42 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #19 from Fridolin Somers --- I suppose _do_xslt_proc() can be called just after SetUTF8Flag() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:24:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:24:36 +0000 Subject: [Koha-bugs] [Bug 34938] Add collection column to holds ratio report (circ/reserveratios.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:24:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:24:38 +0000 Subject: [Koha-bugs] [Bug 34938] Add collection column to holds ratio report (circ/reserveratios.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156305|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 156462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156462&action=edit Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:32:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:32:33 +0000 Subject: [Koha-bugs] [Bug 21007] Add new patron column for date of last successful login attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15504 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:32:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:32:33 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #67 from Katrin Fischer --- *** Bug 21007 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:33:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:33:03 +0000 Subject: [Koha-bugs] [Bug 21007] Add new patron column for date of last successful login attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007 --- Comment #6 from Katrin Fischer --- Note: you can also log successful logins in action_logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:38:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:38:13 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- This appears to be fixed! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:38:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:38:14 +0000 Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Bug 24403 depends on bug 21014, which changed state. Bug 21014 Summary: Availability of hidden items showing in OPAC results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:39:51 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:39:53 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156439|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 156463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156463&action=edit Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:40:27 +0000 Subject: [Koha-bugs] [Bug 33949] Replace GetAllIssues with Koha::Checkouts - opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #9 from David Nind --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:52:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:52:22 +0000 Subject: [Koha-bugs] [Bug 21059] callback function in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Katrin Fischer --- Hi Kyle, this sounds like there was a very specific use case behind this - can you add some more information? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:58:50 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #5 from David Nind --- (In reply to Frédéric Demians from comment #4) > It seems possible, but, for me, now, the test t/db_dependent/OAI/Server.t > fails on master. Is it the case for you also? I can confirm that the tests fail for me, both before and after. I was more after a test plan, so I could replicate the issue, apply the patch, and make sure it fixes things. Test results - before ~~~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/OAI/Server.t t/db_dependent/OAI/Server.t .. 13/34 # No tests run! t/db_dependent/OAI/Server.t .. 30/34 # Failed test 'No tests run for subtest "Bug 19725: OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp"' # at t/db_dependent/OAI/Server.t line 413. Can't call method "timestamp" on an undefined value at t/db_dependent/OAI/Server.t line 400. # Looks like your test exited with 2 just after 30. t/db_dependent/OAI/Server.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 5/34 subtests Test Summary Report ------------------- t/db_dependent/OAI/Server.t (Wstat: 512 Tests: 30 Failed: 1) Failed test: 30 Non-zero exit status: 2 Parse errors: Bad plan. You planned 34 tests but ran 30. Files=1, Tests=30, 3 wallclock secs ( 0.01 usr 0.00 sys + 1.12 cusr 0.13 csys = 1.26 CPU) Result: FAILU) Result: PASS Test results - after ~~~~~~~~~~~~~~~~~~~~ There was a lot more output, and I haven't included it here (just the start and end). prove t/db_dependent/OAI/Server.t t/db_dependent/OAI/Server.t .. 19/34 # Failed test 'ListRecords marcxml' # at t/db_dependent/OAI/Server.t line 184. # Compared $data->{"ListRecords"}{"record"}[0]{"metadata"}{"record"}{"leader"} # got : '00183 2200097 4500' # expect : '00183 a2200097 4500' # PARAM:--- # metadataPrefix: marcxml # verb: ListRecords ..... # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # No tests run! t/db_dependent/OAI/Server.t .. 30/34 # Failed test 'No tests run for subtest "Bug 19725: OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp"' # at t/db_dependent/OAI/Server.t line 413. Can't call method "timestamp" on an undefined value at t/db_dependent/OAI/Server.t line 400. # Looks like your test exited with 2 just after 30. t/db_dependent/OAI/Server.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 10/34 subtests Test Summary Report ------------------- t/db_dependent/OAI/Server.t (Wstat: 512 Tests: 30 Failed: 6) Failed tests: 21-24, 29-30 Non-zero exit status: 2 Parse errors: Bad plan. You planned 34 tests but ran 30. Files=1, Tests=30, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.17 cusr 0.11 csys = 1.30 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 22:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 20:58:54 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Zeno Tajoli --- Probably the problem is presnt only on a specific platform. I use Debian 11 with MariaDb (default setup) I change the commit file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:08:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:08:06 +0000 Subject: [Koha-bugs] [Bug 21118] Highlighting of search terms in the 500 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21118 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:09:00 +0000 Subject: [Koha-bugs] [Bug 21119] Add option to repeat order line fields for next order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:14:26 +0000 Subject: [Koha-bugs] [Bug 21143] Mechanism added to permit merging of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 27121 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:14:26 +0000 Subject: [Koha-bugs] [Bug 27121] Merge items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emjhet at pa.net --- Comment #9 from Katrin Fischer --- *** Bug 21143 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:18:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:18:12 +0000 Subject: [Koha-bugs] [Bug 19062] Don't queue check-in/checkout messages if patron has no e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 --- Comment #7 from Caroline Cyr La Rose --- My understanding is the same as Jonathan's. If the patron has no address, when process_message_queue runs, it puts it as "failed", and adds a comment in the db ("NO_EMAIL"). After that, it is not treated again, unless we click on the resend button, or change it manually in the db back to "pending". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:22:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:22:18 +0000 Subject: [Koha-bugs] [Bug 21187] GDPR: Regularly force patrons password renew In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GDPR: Force patrons |GDPR: Regularly force |password renew |patrons password renew -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:24:20 +0000 Subject: [Koha-bugs] [Bug 21193] Develop a procedure for handling minified CSS at release only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21193 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I believe we have taken care of this now - please re-open if I am mistaken! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:27:25 +0000 Subject: [Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 --- Comment #2 from Katrin Fischer --- All dependent bugs have been resolved, but I believe there is still a ton to go if we want C4/Acquisitions gone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:31:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:31:06 +0000 Subject: [Koha-bugs] [Bug 21236] Restore ability to selectively set item to lost without generating fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:33:01 +0000 Subject: [Koha-bugs] [Bug 21240] Tables with lot of columns should have autoWidth turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21240 --- Comment #4 from Katrin Fischer --- With git grep I see a lot of instances of autoWidth false in the codebase. It looks like this might be fixed. Closing, please re-open if I misssed something! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:33:08 +0000 Subject: [Koha-bugs] [Bug 21240] Tables with lot of columns should have autoWidth turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:49:41 +0000 Subject: [Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleypelham at ownmail.net |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 23:49:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 21:49:48 +0000 Subject: [Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:03:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:03:54 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Fridolin Somers --- Ah needs work Should use metadata->schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:01 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:01 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:06 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34482 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:06 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31383 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:10 +0000 Subject: [Koha-bugs] [Bug 21302] Link in 780/785 should search for $t in title and $a in author In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:17:10 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21302 [Bug 21302] Link in 780/785 should search for $t in title and $a in author -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:21:18 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #6 from David Nind --- (In reply to Zeno Tajoli from comment #5) > Probably the problem is presnt only on a specific platform. I use Debian 11 > with MariaDb (default setup) > I change the commit file KTD (koha-testing-docker) by default is currently using Debian 11 and MariaDB 10.5.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:21:48 +0000 Subject: [Koha-bugs] [Bug 21328] Purchase Suggestions View by Hierarchical Group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21328 --- Comment #1 from Katrin Fischer --- Hi Lisette, you can see 'all branches', but I think by hierarchical groups you were referring to library groups? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:23:58 +0000 Subject: [Koha-bugs] [Bug 21342] how to generate comparative statement of book sellers in koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21342 --- Comment #1 from Katrin Fischer --- Hi Bashir, how do you track the quoted price? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:32:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:32:23 +0000 Subject: [Koha-bugs] [Bug 21370] Regular search and items search displays different info as Status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21370 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- We re-labelled the column to read 'not for loan status'. So I believe this is now accurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:34:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:34:33 +0000 Subject: [Koha-bugs] [Bug 21371] Ability to add the processing fee to Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12769 Version|17.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:34:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:34:33 +0000 Subject: [Koha-bugs] [Bug 12769] Manage fees for sending notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21371 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:37:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:37:02 +0000 Subject: [Koha-bugs] [Bug 21378] Add filters in reserve/request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- There is a filter now on top of the item table on the 'place hold' page in the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:47:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:47:47 +0000 Subject: [Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|ASSIGNED |RESOLVED --- Comment #8 from Katrin Fischer --- I think this was resolved with the addition of the CSS classes. Please re-open if I missed something! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:50:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 22:50:39 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #26 from Fridolin Somers --- In my opinion, we should revert from oldstable in order for stability and to avoid behavior changes. Note that Bug 34694 is not in oldstabe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:29:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:29:14 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:29:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:29:17 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156459|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156464&action=edit Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:33:13 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a couple of release notes| |inconsistencies in the cash | |register administration | |page, making sure the page | |title, breadcrumb | |navigation, and page | |headers are consistent with | |each other. CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Enable UseCashRegisters system preference. 2. I noticed in the patch (I don't normally look at these as I don't know what is going on!), and noticed there was 'stuff' for deleting a cash register. I can't see an option to do this in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:39:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:39:50 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:39:53 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156457|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156465&action=edit Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:40:30 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a couple of release notes| |inconsistencies in the | |debit types administration | |page, making sure the page | |title, breadcrumb | |navigation, and page | |headers are consistent with | |each other. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:49:21 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:49:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:49:23 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156455|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156466&action=edit Bug 34961: Add sort parameter to OPAC search results RSS feed link This patch corrects two RSS links in the OPAC search results template so that they include the correct parameters, including the descending sort by acquisition date. To test, apply the patch and go to the OPAC. - Perform a catalog search which will return search results. - Next to the page heading "Your search returned X results" is an RSS link. Check the link to confirm that it has all the expected parameters: opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss - Perform a search which will return no results and check the RSS link on that page. It should be the same. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Oct 2023 23:50:13 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes two RSS links in release notes| |the OPAC search results | |template so that they | |include the correct | |parameters, including the | |descending sort by | |acquisition date. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:02:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:02:11 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:02:13 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #2 from David Nind --- Created attachment 156467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156467&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:02:16 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #3 from David Nind --- Created attachment 156468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156468&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:05:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:05:20 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a couple of release notes| |inconsistencies in the | |credit types administration | |page, making sure the page | |title, breadcrumb | |navigation, and page | |headers are consistent with | |each other. CC| |david at davidnind.com --- Comment #4 from David Nind --- Feel free to obsolete my follow-up patch - bug 34389 (debit types) and bug 34391 (cash registers) had single quotes around the debit and cash register code values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:07:27 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #83 from Aleisha Amohia --- Created attachment 156469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156469&action=edit Bug 33478: [WIP] CSS area instead of specific style inputs This patch implements a single style field for the slip to allow for more advanced CSS customisation. This prevents the forcing of default styles which override the SlipCSS syspref settings. There are links to insert selectors as helpers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 00:07:43 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 03:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 01:45:05 +0000 Subject: [Koha-bugs] [Bug 26973] extendedPatronAttributes not showing during selfregistration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #15 from David Cook --- I find it a bit weird that patron attributes aren't shown when PatronSelfRegistrationVerifyByEmail is enabled. Surely most Koha instances should have PatronSelfRegistrationVerifyByEmail enabled... I suppose that's more of an enhancement though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 03:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 01:50:27 +0000 Subject: [Koha-bugs] [Bug 26973] extendedPatronAttributes not showing during selfregistration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #16 from David Cook --- (In reply to David Cook from comment #15) > I find it a bit weird that patron attributes aren't shown when > PatronSelfRegistrationVerifyByEmail is enabled. > > Surely most Koha instances should have PatronSelfRegistrationVerifyByEmail > enabled... > > I suppose that's more of an enhancement though... Although it looks like borrower_modifications can support extended_attributes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 03:57:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 01:57:12 +0000 Subject: [Koha-bugs] [Bug 26973] extendedPatronAttributes not showing during selfregistration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #17 from David Cook --- Ah hence bug 30120. Never mind... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 03:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 01:57:16 +0000 Subject: [Koha-bugs] [Bug 30120] Allow extended attributes during self registration when using PatronSelfRegistrationVerifyByEmail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26973 CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 03:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 01:57:16 +0000 Subject: [Koha-bugs] [Bug 26973] extendedPatronAttributes not showing during selfregistration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30120 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:51:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:51:45 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #40 from Jonathan Druart --- Matt, thanks, this is working great now! I remember I played with that scrollTop trick, I must have missed the right place to put it! I think this can go as it now and we will implement it for the other dropdown lists on separate bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:25 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:29 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153110|0 |1 is obsolete| | Attachment #153111|0 |1 is obsolete| | Attachment #153112|0 |1 is obsolete| | Attachment #153113|0 |1 is obsolete| | Attachment #156410|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 156470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156470&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:32 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #42 from Jonathan Druart --- Created attachment 156471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156471&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:35 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #43 from Jonathan Druart --- Created attachment 156472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156472&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:38 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #44 from Jonathan Druart --- Created attachment 156473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156473&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:41 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #45 from Jonathan Druart --- Created attachment 156474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156474&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:52:57 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |pedro.amorim at ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:56:06 +0000 Subject: [Koha-bugs] [Bug 32494] Potentially expensive API calls made for conditional template rendering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- I think this has been fixed by the following commit: Bug 32807: Fetch count instead of all entries for agreements and licenses *** This bug has been marked as a duplicate of bug 32807 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 08:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 06:56:06 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #11 from Jonathan Druart --- *** Bug 32494 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:01:51 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #46 from Martin Renvoize --- It's great to see this has moved.. are you comfortable for me to QA Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:00 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156470|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 156475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156475&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:03 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156471|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 156476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156476&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:06 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156472|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 156477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156477&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:09 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156473|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 156478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156478&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:11 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156474|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 156479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156479&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:14:29 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|pedro.amorim at ptfs-europe.co |martin.renvoize at ptfs-europe |m |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:15:05 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #52 from Martin Renvoize --- This is working great, so nice to see that bump gone too. Code looks solid, tests are passing and happy.. QA scripts happy, No regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:19:36 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #53 from Martin Renvoize --- Oop.. forgot to run the Cypress tests in my eaferness.. running those before switching state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:30:16 +0000 Subject: [Koha-bugs] [Bug 34973] New: JS warning in the console: "Glyph bbox was incorrect" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Bug ID: 34973 Summary: JS warning in the console: "Glyph bbox was incorrect" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com downloadable font: Glyph bbox was incorrect (glyph ids 1 2 3 4 5 8 9 10 11 12 13 14 16 17 19 22 24 28 32 34 35 38 39 40 43 44 45 46 47 50 51 52 53 55 56 58 60 61 62 64 67 68 70 71 72 73 74 78 79 80 81 83 90 96 101 103 104 105 108 109 115 116 117 118 120 123 125 135 138 139 140 142 143 144 145 146 148 149 154 155 157 161 162 163 164 165 169 170 171 173 179 181 193 195 203 207 208 210 211 214 218 219 223 225 227 228 229 230 235 236 237 238 239 240 245 246 247 248 249 250 251 252 253 254 255 256 257 263 264 266 268 271 275 278 279 280 281 282 283 284 285 286 287 288 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 321 335 338 339 340 342 344 345 346 353 354 356 357 358 359 362 363 365 366 371 373 374 379 381 382 383 386 389 390 391 393 394 406 407 412 413 418 419 420 424 432 433 439 448 449 450 451 454 455 456 457 472 479 480 481 482 485 486 490 491 493 499 500 501 503 508 509 513 515 516 525 527 528 532 535 541 542 543 549 550 551 552 554 555 556 558 560 569 571 602 603 604 607 608 609 614 615 617 618 623 626 627 643 644 645 647 650 651 654 655 656 657 662 663 664 665 670 671 672 674 675 679 680 681 682 683 698 699 708 712 714 717 718 729 730 732 735 736 739 746 747 752 761 762 767 774 776 777 778 779 788 789 790 794 796 798 800 801 803 804 806 826 828 829 831 835 836 838 839 840 841 842 843 844 845 848 849 856 857 861 862 863 871 873 874 880 882 892 895 900 908 911 913 925 928 929 930 933 936 937 938 941 942 943 944 945 948 949 950 952 958 960 961 962 964 966 967 969 973 974 978 979 980 981 982 989 998 1000 1001 1005 1006 1008 1009 1011 1012 1013 1016 1020 1026 1027 1031 1036 1037 1042 1045 1048 1050 1052 1053 1057 1058 1060 1063 1072 1073 1076 1084 1087 1099 1104 1110 1111 1112 1116 1117 1121 1122 1124 1131 1136 1140 1141 1142 1147 1148 1151 1157 1163 1167 1168 1170 1177 1186 1187 1193 1196 1199 1200 1201 1204 1205 1208 1211 1212 1217 1218 1220 1224 1226 1228 1229 1230 1231 1232 1233 1235 1236 1237 1238 1243 1246 1247 1249 1251 1256 1258 1259 1260 1261 1265 1268 1269 1271 1272 1273 1275 1276 1279 1285 1289 1290 1291 1292 1296 1297 1303 1304 1305 1309 1310 1311 1312 1317 1319 1320 1324 1325 1328 1329 1330 1331 1334 1335 1337 1339 1341 1343 1356 1357 1363 1369 1371 1372 1375 1376 1377 1380 1381 1382 1384 1387) (font-family: "Font Awesome 6 Free" style:normal weight:900 stretch:100 src index:0) source: http://kohadev-intra.mydnsname.org:8081/intranet-tmpl/lib/fontawesome/webfonts/fa-solid-900.woff2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:30:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:30:52 +0000 Subject: [Koha-bugs] [Bug 34973] JS warning in the console: "Glyph bbox was incorrect" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:51:36 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Assignee|matt.blenkinsop at ptfs-europe |jonathan.druart+koha at gmail. |.com |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:58:47 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #54 from Jonathan Druart --- Created attachment 156481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156481&action=edit Bug 32474: Fix required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 09:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 07:59:42 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #55 from Jonathan Druart --- Created attachment 156482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156482&action=edit Bug 32474: Adjust tests - X-Total-Count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:23:47 +0000 Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don't use OPAC description if message type is OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC|axelle.clarisse at univ-amu.fr | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:28:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:28:45 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #56 from Jonathan Druart --- Created attachment 156483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156483&action=edit Bug 32474: Pass label and identifier This is a try to fix the last remaining Cypress failure. The problem is that the label of the existing license does not display, only its id. To recreate: Create a license Create an agreement and select the license Edit the agreement => The display shows "License: {id}", not its name This patch is removing the code from created() because I thought it was the problem originally, and it didn't seem correct to let InfiniteScrollSelect deal with the "id" and "label" for the different dataType. But the problem is somewhere else: we have not fetched any licenses yet from the AgreementLicenses. However we do have the selected license that we could pass to InfiniteScrollSelect, but that's yet another param to pass. It feels like there is something better to do here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:31:25 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #57 from Jonathan Druart --- There is also something else: we are passing "v-model" but InfiniteScrollSelect is expecting "modelValue". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:36:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:36:28 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com Status|ASSIGNED |NEW --- Comment #58 from Jonathan Druart --- To summary the last changes: * The "required" was no longer working - It was not possible to save the form * Cypress tests were failing because we didn't mock correctly the response (X-Total-Count header was missing) * "Pass label and identifier" patch can be dropped if you disagree with it, but I think it's the correct way to fix the last remaining cypress failure (which is about the display of the license's name when we edit an agreement) * Something is wrong with "v-model" vs "modelValue", see previous comment. Handing it back to Matt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:36:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:36:42 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:36:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:36:48 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 10:52:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 08:52:00 +0000 Subject: [Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917 Georgia Newman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |g.newman at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:52:31 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:53:59 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:58:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:58:04 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:58:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:58:07 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156465|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156484&action=edit Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:58:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:58:36 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:58:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:58:39 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156464|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156485&action=edit Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:59:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:59:03 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:59:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:59:41 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 11:59:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 09:59:44 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156463|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156486&action=edit Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:00:18 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:04:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:04:53 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:04:57 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156432|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156487&action=edit Bug 34967: Remove Test::DBIx::Class Move everything in one subtest Test plan: Run t/Prices.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:05:00 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156433|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 156488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156488&action=edit Bug 34967: Add sample biblios and tidy some lines Test plan: Run t/Prices.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:05:03 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156434|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156489&action=edit Bug 34967: Move to db_dependent No further changes. Test plan: Run t/db_dependent/Prices.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:05:23 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:07:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:07:31 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:07:34 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156438|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156490&action=edit Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t There is really no need for all those modules here. What remains, is just a trivial test. Test plan: Run t/SuggestionEngine_AuthorityFile.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:08:12 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:09:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:09:20 +0000 Subject: [Koha-bugs] [Bug 34974] New: search_for_data_inconsistencies.pl: Can't call method "get_column" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34974 Bug ID: 34974 Summary: search_for_data_inconsistencies.pl: Can't call method "get_column" Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When calling the script "search_for_data_inconsistencies.pl" the only output is the following: $ sudo koha-shell -c "perl /usr/share/koha/bin/maintenance/search_for_data_inconsistencies.pl" instancename Can't call method "get_column" on an undefined value at /usr/share/koha/bin/maintenance/search_for_data_inconsistencies.pl line 157. This happens when using Koha 20.11.02 with MariaDB 10.3.39, running on Debian GNU/Linux 10. According to Jonathan Druart (3 October 2023) this can be considered as a bug for this script, and it seems (looking at the code) that the bug still exists in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:11:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:11:21 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Why remove these tests? -use_ok('C4::Search'); -can_ok('C4::Search', - qw/_build_initial_query/); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:12:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:12:10 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:16:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:16:35 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:16:37 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156437|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156491&action=edit Bug 34969: Remove unneeded module from buildQuery.t Test plan: Run t/Search/buildQuery.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:16:42 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 --- Comment #4 from Katrin Fischer --- Created attachment 156492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156492&action=edit Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests No need to remove them for removing Test::DBIx::Class dependency. Tests still pass. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:17:15 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:20:40 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:20:44 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156466|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156493&action=edit Bug 34961: Add sort parameter to OPAC search results RSS feed link This patch corrects two RSS links in the OPAC search results template so that they include the correct parameters, including the descending sort by acquisition date. To test, apply the patch and go to the OPAC. - Perform a catalog search which will return search results. - Next to the page heading "Your search returned X results" is an RSS link. Check the link to confirm that it has all the expected parameters: opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss - Perform a search which will return no results and check the RSS link on that page. It should be the same. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:21:26 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 12:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 10:58:54 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #59 from Matt Blenkinsop --- Passing the data to the component from the parent causes issues because we can't guarantee that there is a match for the "label" property in that data object. For example, in the case of agreement licenses, if we pass the agreement license to the select component it doesn't have a "name" property which is used as the label. The "name" property exists in the license which appears to be embedded in that object. We'd need to iterate through all the properties to determine if any of them were embedded objects which might contain the "name" property and we could have a scenario where there are agreements and licenses embedded in the same object and both have the "name" property. This could be very inconsistent and difficult to maintain. To do it we would have to explicitly pass the actual name of the license itself as a prop e.g. :dataToEditLabel="agreement_license.license.name" This is the cleanest method in terms of code but involves passing another parameter each time The only other real option I can think of atm is to fetch it from the API when the component is rendered and add it to the options for the select. This means another API request but this is probably more reliable than passing the data from the parent and will be far easier to maintain when Vue gets used in other parts of Koha. Let me know your thoughts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:03:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:03:56 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:03:59 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156460|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156494&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:04:47 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:06:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:06:54 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #13 from Marcel de Rooy --- (In reply to Agnes Rivers-Moore from comment #12) > I am not sure existence of an email address proves a genuine individual or > protects from pranking or misuse. If a library needs to prove there is a > real person who is not already registered, or banned, or from another > country, they would need more than an email address. Our staff see the > online registration attempt and contact the person for ID verification. So, > library set preference for whether email is required or not. For us, phone > number required is more important. If you enable the verification step for self registration (and imo you should always do that), you need an email address. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:07:21 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Georgia Newman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |g.newman at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:09:08 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:09:11 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156461|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156495&action=edit Bug 34939: Set hour:minute to 23:59 when inputing dates unless explicitly set 1. Find some places in the staff interface where data-flatpickr-enable-time is set to true. Examples: renew.tt or circulation.tt 2. Directly input a date in whatever date format you have specified in DateFormat but omit the hour/minute. Example: 12/12/2023 3. See that the hour/minute default to 00:00 if your TimeFormat is 24hr and 12:00 AM if your time format is 12hr 4. Apply patch, clear browser cache. 5. Try step again, setting a date like '12/12/2023'. The hour:minute should be added as 23:59. 6. With TimeFormat set to 24hr try entering a date with the hour:minute like '12/12/2023 11:22'. The hour:minute should be set to 11:22. 7. With TimeFormat set to 12hr try entering a date with the hour:minute like '12/12/2023 11:22 AM'. The hour:minute should be set to 11:22 AM. 8. Play with this in as many TimeFormat and DateFormat combonatinons as you can. Signed-off-by: Kristi Krueger Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:09:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:09:49 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 --- Comment #8 from Katrin Fischer --- Key here is to type the date vs. picking it from the widget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:09:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:09:51 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156458|0 |1 is obsolete| | Attachment #156467|0 |1 is obsolete| | Attachment #156468|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 156496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156496&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:09:54 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #6 from Owen Leonard --- Created attachment 156497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156497&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:10:06 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:10:38 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156467|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:10:46 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:25:41 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 --- Comment #4 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > Why remove these tests? > > -use_ok('C4::Search'); > -can_ok('C4::Search', > - qw/_build_initial_query/); Calling use_ok does not really add anything to our tests (here and in general too). We have a specific test that tests loading all modules in C4 and Koha in t/00-load.t. It will signal such a module. If the module would not load (and it would still be signed off..), the specific test will fail too anyway. For me the BEGIN blocks with use_ok are just unneeded ballast. We have no coding guideline to keep them and not one to remove them. It should not be a blocker for this report imo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:27:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:27:34 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:27:37 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156231|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156498&action=edit Bug 34822: Process real time holds along with indexing Current code already skips indexing when adding record to instead index in a single call. This patch pdates the code to do the same thing for real time holds queue updates. Note: Newly added records do not need to be updated as they won't have holds yet. To test: 1 - Have a marc file with several records that match records in your catalog You can export part of your catalog to generate one 2 - Set system preference: RealTimeHoldsQueue to 'enable' 3 - Stage and import file, make sure you are matching and overlaying 4 - Go to Administration->Manage jobs 5 - Note a batch update for each updated record 6 - Apply patch 7 - Repeat 8 - Note a single job added for the entire batch containing only updated records Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:28:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:28:17 +0000 Subject: [Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #6) > I am not an expert programmer, I am happy to change things around, but I > need a little bit more insight in why you think something is wrong. I will try. Should not be very hard? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:30:08 +0000 Subject: [Koha-bugs] [Bug 34975] New: Job details for BatchUpdateBiblioHoldsQueue lack information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34975 Bug ID: 34975 Summary: Job details for BatchUpdateBiblioHoldsQueue lack information Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The details for the holds queue update with RealTimeHoldsQueue enabled shows a list of checkboxes, but no information on the records or holds updated. It would be nice to include some information or just a count maybe. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:30:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:30:21 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 --- Comment #5 from Katrin Fischer --- I am not sure if this could be unit tested, but I ran the existing tests and they still pass ok: t/db_dependent/ImportBatch.t The detailed BatchUpdateBiblioHoldsQueue job info doesn't look nice yet. Filed: Bug 34975 - Job details for BatchUpdateBiblioHoldsQueue lack information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:31:25 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #12 from Katrin Fischer --- (In reply to Kyle M Hall from comment #11) > (In reply to Katrin Fischer from comment #9) > > It's not the wording, it's the formatting. I'd forgo the for quotes. > > Katrin, can you have another look as this now that I've replaced them em > tags? Sorry, this fell through the cracks, will try to do it now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:32:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:32:05 +0000 Subject: [Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > my $branch = $input->param("branch"); > my $manager_branchcode = $input->param("branch") || > C4::Context->userenv->{'branch'}; > This does not look good. You added $branch here, but we already have $manager_branchcode using the same CGI parameter. We should not do that. It will create confusion. If you need to know the branch code passed, use the existing variable. Change that etc. Do not clone it. > And this looks bad: > - > Script still has it: > if ($manager_branchcode ne 'ALL') { In the template you remove the ALL value of a combo box. You replace it by: + But the script still contains reference to the old value ALL. You should also solve those references. HTH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:39:27 +0000 Subject: [Koha-bugs] [Bug 28431] [DOCS] Spelling error in the manual (tools): exsit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Keywords|Manual |Manual-updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:40:45 +0000 Subject: [Koha-bugs] [Bug 32767] Optionally allow for trimming whitespace from patron attribute values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 --- Comment #11 from Marcel de Rooy --- (In reply to Peter Vashchuk from comment #10) > (In reply to Marcel de Rooy from comment #9) > > Oops. Please run QA tools. (You are in QA?) > > Failing test and more trouble. > > Tested on the latest master, QA tools are OK, and tests also seem fine: > > $> prove t/db_dependent/Koha/Patron/Attribute.t > t/db_dependent/Koha/Patron/Attribute.t .. ok > All tests successful. > Files=1, Tests=3 > Result: PASS > > can you please help me find out what the problem is? Sure. Did you merge latest changes on qa tools? I will copy my results in the next comment. Note that the test does pass. I probably did not run the atomicupdate. Sorry about that.. But there are still some issues raised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:40:56 +0000 Subject: [Koha-bugs] [Bug 32767] Optionally allow for trimming whitespace from patron attribute values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 --- Comment #12 from Marcel de Rooy --- Processing files before patches |========================>| 10 / 10 (100.00%) Processing files after patches |========================>| 10 / 10 (100.00%) WARN Koha/Patron/Attribute.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 8, now: 10) OK valid WARN Koha/Patron/Attribute/Type.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 6, now: 14) OK valid WARN Koha/Schema/Result/BorrowerAttributeType.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 47, now: 49) OK valid WARN admin/patron-attr-types.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 62, now: 65) OK valid WARN installer/data/mysql/atomicupdate/bug_32767-trim-attr-feature.pl OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) OK valid FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column borrower_attribute_types.trim_value is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/BorrowerAttributeType.pm), see the SQL12 coding guideline OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template WARN members/memberentry.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 318, now: 319) OK valid OK opac/opac-memberentry.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid WARN t/db_dependent/Koha/Patron/Attribute.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 84, now: 104) OK valid Processing additional checks OK! Running tests (1) * Proving /usr/share/koha/t/db_dependent/Koha/Patron/Attribute.t OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:46:17 +0000 Subject: [Koha-bugs] [Bug 27098] Rename 'Relatives fines' to 'Relatives charges' in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27098 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Keywords|Manual |Manual-updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:49:33 +0000 Subject: [Koha-bugs] [Bug 30615] Wrong URL to OAI-PMH-Tutorial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30615 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon at ptfs-europe. | |com Status|NEW |RESOLVED --- Comment #4 from Aude Charillon --- It does look resolved! Marking the bug as such. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:59:13 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #10 from Marcel de Rooy --- This is much better! One final thing: + $orders = GetHistory( order_status => "new", vendornote => 'status search' ); + is( scalar(@$orders), 1, 'GetHistory with order status "new" returns 1 order' ); + + my $orders = GetHistory( get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); + is( scalar(@$orders), 2, 'GetHistory with order status "any" returns all orders' ); + + $orders = GetHistory( order_status => "", vendornote => 'status search' ); + is( scalar(@$orders), 1, 'GetHistory with order status "all except cancelled" returns zero orders' ); The last test does not read very well. If orders == 1 then it returns 0 orders?? Please adjust. No big blocker but you assume that there are no orders in the system when you get a count. So your test may very well fail with some orders being there. Since you created a new basket, you could also pass the param basket to GetHistory [my $basket = $params{basket} ]. Which would resolve the issue with other orders. GetHistory( basket => $order_basket->{basketno}, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:59:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:59:15 +0000 Subject: [Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual |Manual-updated CC| |aude.charillon at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:59:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:59:21 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #11 from Marcel de Rooy --- diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t index d102a343a0..a5a165d777 100755 --- a/t/db_dependent/Acquisition.t +++ b/t/db_dependent/Acquisition.t @@ -995,13 +995,13 @@ subtest 'GetHistory status search' => sub { }; $order = $builder->build( { source => 'Aqorder', value => $orderinfo2 } ); - $orders = GetHistory( order_status => "new", vendornote => 'status search' ); + $orders = GetHistory( basket => $order_basket->{basketno}, order_status => "new", vendornote => 'status search' ); is( scalar(@$orders), 1, 'GetHistory with order status "new" returns 1 order' ); - my $orders = GetHistory( get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); + my $orders = GetHistory( basket => $order_basket->{basketno}, get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); is( scalar(@$orders), 2, 'GetHistory with order status "any" returns all orders' ); - $orders = GetHistory( order_status => "", vendornote => 'status search' ); + $orders = GetHistory( basket => $order_basket->{basketno}, order_status => "", vendornote => 'status search' ); is( scalar(@$orders), 1, 'GetHistory with order status "all except cancelled" returns zero orders' ); }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:59:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:59:36 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 13:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 11:59:57 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #12 from Marcel de Rooy --- Patches may be squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:14:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:14:21 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #13 from Katrin Fischer --- Note to myself: instead of note we could use the basketno. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:24:20 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the inventory |This fixes the inventory release notes|tool to clarify the message |tool to clarify the message |for items with non-matching |for items with non-matching |not for loan values in the |not for loan values in the |inventory results |inventory results |'Problems' column. |'Problems' column. | | |It: |It: |- |- |Adds a hint on the |Adds a hint on the |inventory tool page under |inventory tool page under |'Optional filters for |'Optional filters for |inventory list or comparing |inventory list or comparing |barcodes' section. |barcodes' section. |- |- |Clarifies the message in |Clarifies the message in |the 'Problems' column: from |the 'Problems' column: from |'Unknown not-for-loan |'Unknown not-for-loan |status' to 'Items has no |status' to 'Items has no |not for loan status'. |not for loan status'. | | |(If |If |one or more not for loan |one or more not for loan |values (Optional filters |values (Optional filters |for inventory list or |for inventory list or |comparing barcodes > |comparing barcodes > |items.notforloan) are |items.notforloan) are |selected, and an item is |selected, and an item is |scanned that has no NFL |scanned that has no NFL |status or an unselected NFL |status or an unselected NFL |status, the error message |status, the error message |was "Unknown not-for-loan |was "Unknown not-for-loan |status". This could be |status". This could be |interpreted as the item |interpreted as the item |having an NFL status value |having an NFL status value |that is not defined in the |that is not defined in the |system, but that is not |system, but that is not |accurate. This is now |accurate. This is now |clarified and the error |clarified and the error |message is now "Items has |message is now "Items has |no not for loan status". |no not for loan status". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:35:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:35:42 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:35:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:35:45 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155871|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 156499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156499&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:35:47 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155928|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 156500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156500&action=edit Bug 34820: (QA follow-up) add filter, update CSV output Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:35:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:35:51 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155957|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 156501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156501&action=edit Bug 34820: (QA follow-up) Replace em tags with quotes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:35:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:35:54 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #16 from Katrin Fischer --- Created attachment 156502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156502&action=edit Bug 34820: (QA follow-up) Fix span tag One span tag was missing a <. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:39:13 +0000 Subject: [Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Taking a closer look at the comments here, there seems to be some discussion about implementation, also question about how to reproduce the issue this is trying to fix. Truth is this has had comments from a lot of QA team members already and we are a little stuck. Kyle, could you review the last few comments for a start please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:40:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:40:50 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:40:53 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156436|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156503&action=edit Bug 34968: Remove unneeded module from Search.t Test::DBIx::Class is not even used here. Just like C4::Biblio. We should remove TestBuilder too (this is t not t/db)! Test plan: Run t/Search.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:41:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:41:41 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 --- Comment #5 from Katrin Fischer --- Marcel commented on the removed tests on another bug - removing my follo-up: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968#c4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:41:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:41:53 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:16 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:17 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:19 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:20 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:21 +0000 Subject: [Koha-bugs] [Bug 34836] OPAC ISBD or MARC view blows up with error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:23 +0000 Subject: [Koha-bugs] [Bug 34836] OPAC ISBD or MARC view blows up with error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:25 +0000 Subject: [Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:26 +0000 Subject: [Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:27 +0000 Subject: [Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:29 +0000 Subject: [Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:30 +0000 Subject: [Koha-bugs] [Bug 34930] Fix timezone problem in Koha/Object.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34930 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:31 +0000 Subject: [Koha-bugs] [Bug 34930] Fix timezone problem in Koha/Object.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34930 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:32 +0000 Subject: [Koha-bugs] [Bug 34934] Remove the use of event attributes from OPAC lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:34 +0000 Subject: [Koha-bugs] [Bug 34934] Remove the use of event attributes from OPAC lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:35 +0000 Subject: [Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 14:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 12:55:37 +0000 Subject: [Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:18:26 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:18:47 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:18:49 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:18:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:18:50 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:18:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:18:52 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:19:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:19:07 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:19:36 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:19:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:19:49 +0000 Subject: [Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:20:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:20:27 +0000 Subject: [Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:23:55 +0000 Subject: [Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:23:57 +0000 Subject: [Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:23:58 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:23:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:23:59 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:24:01 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:24:02 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:24:25 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #68 from Tomás Cohen Arazi --- Follow-up pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 15:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 13:26:37 +0000 Subject: [Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Emily Lamancusa --- The script output looks right in terms of which items should renew, but the renewal itself doesn't seem to be happening. After running the cron with the --confirm switch, the item's due date doesn't change, and the patron's checkouts table line for that item still says "Scheduled for automatic renewal (2 of 2 renewals remaining and 2 of 2 unseen renewals remaining)". The patron does have a queued automatic renewal notice saying that the item renewed and is due on the original due date. I tried again with only the first patch applied and got the same result, so I'm guessing the problem is there somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:09:29 +0000 Subject: [Koha-bugs] [Bug 34955] One Koha manual (to rule them all) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34955 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:10:37 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 R Bradshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rebecca.bradshaw at nnuh.nhs.u | |k Alias| |Rebecca, Bradshaw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:11:04 +0000 Subject: [Koha-bugs] [Bug 34897] ILL unit tests have lots of 'redefined' warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34897 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Pedro Amorim --- *** This bug has been marked as a duplicate of bug 34838 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:11:04 +0000 Subject: [Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Pedro Amorim --- *** Bug 34897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:11:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:11:17 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 R Bradshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Rebecca Bradshaw contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:11:32 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 R Bradshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|Rebecca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:11:38 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 R Bradshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|Bradshaw | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:20:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:20:45 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 R Bradshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/738 Status|Needs documenting |RESOLVED --- Comment #10 from R Bradshaw --- Hi - This has been added to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:32:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:32:22 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #60 from Jonathan Druart --- Created attachment 156504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156504&action=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:32:25 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156483|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 156505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156505&action=edit Bug 32474: Pass label and identifier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:32:48 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #62 from Jonathan Druart --- This is not very nice, but the tests now pass and it's flexible enough for now IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:34:23 +0000 Subject: [Koha-bugs] [Bug 33934] 'No encryption_key in koha-conf.xml' needs more detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33934 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #15 from Marcel de Rooy --- For purists, taken from Crypt::CBC -pass,-key The encryption/decryption passphrase. These arguments are interchangeable, but -pass is preferred ("key" is a misnomer, as it is not the literal encryption key). So our "encryption key" is a misnnomer too :) It is a passphrase used to generate the real encryption key. We say now: We recommend one of at least 32 bytes. It should be formally at least 16 bytes (AES blocksize) in order to be safe. So 32 is fine. Shouid we enforce a minimum length in Koha::Encryption? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:36:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:36:07 +0000 Subject: [Koha-bugs] [Bug 28788] Default holds policy by item type can be overridden but holds will not capture In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28788 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Emily Lamancusa --- *** This bug has been marked as a duplicate of bug 20955 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:36:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:36:07 +0000 Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #5 from Emily Lamancusa --- *** Bug 28788 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:40:35 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #6 from Jonathan Druart --- (quick note) test_connection returns 500 if credentials are not correct (I guess it's the problem). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:45:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:45:22 +0000 Subject: [Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart --- I am still getting a lot of warnings t/db_dependent/Illrequests.t .. 1/15 illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 101. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 111. t/db_dependent/Illrequests.t .. 6/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. t/db_dependent/Illrequests.t .. 8/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 11/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 12/15 Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 14/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:45:55 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:45:57 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #2 from Owen Leonard --- Created attachment 156506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156506&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:47:29 +0000 Subject: [Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > Note that 4 warnings remain > > t/db_dependent/Koha/Illbackend.t .. Use of uninitialized value in exists at > /kohadevbox/koha/Koha/Illrequest.pm line 1956. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1961. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1956. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1961. So this was t/db_dependent/Koha/Illbackend.t But the problem remains for t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:50:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:50:50 +0000 Subject: [Koha-bugs] [Bug 34976] New: Encryption keys should not be shared between modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 Bug ID: 34976 Summary: Encryption keys should not be shared between modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org At this time we are using the encryption key in koha-conf to encrypt stuff for 2FA, EDI and Acquisition already. The key was introduced for 2FA. I think that it would be better to differentiate and use separate keys for various processes in Koha. For instance, the key for 2FA should be used exclusively for that purpose. We could consider if that is needed also for EDI and Acq since these are related modules. They could use one or two new keys. When adding a new call to Encryption, we should think about it. Perhaps this would be forced a bit more by passing a parameter to K::E indicating which key to use? Opening the discussion :) What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:51:33 +0000 Subject: [Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:51:52 +0000 Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Bug 34976 - Encryption keys should not be shared between modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 16:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 14:52:40 +0000 Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078 --- Comment #5 from Marcel de Rooy --- (In reply to David Cook from comment #1) > In master, I'm only seeing Koha::Encryption used in Koha::Patron, and within > Koha::Patron it's used in the function "encode_secret". Unfortunately this is no longer true. EDI and Acquisition started using it too. See the other report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:02:20 +0000 Subject: [Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 --- Comment #1 from Jonathan Druart --- Why that? Security? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:08:35 +0000 Subject: [Koha-bugs] [Bug 34977] New: The "Patron Lists" only allows deleting one list at a time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Bug ID: 34977 Summary: The "Patron Lists" only allows deleting one list at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: salah.ghedda at inlibro.com QA Contact: testopia at bugs.koha-community.org Instead of deleting one list at a time, it's more helpful to be able to delete multiple lists at once by adding checkboxes for each list along with a button (at the bottom or top of the page) to enable the deletion of multiple lists at once. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:10:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:10:20 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com, | |philippe.blouin at inlibro.com Assignee|koha-bugs at lists.koha-commun |salah.ghedda at inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:38:54 +0000 Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|ASSIGNED |In Discussion --- Comment #6 from Emily Lamancusa --- +1 for adding a flag - holds violating the holds policy should trap if and only if the hold policy was explicitly overridden. Retaining that information in a flag seems like a good way to enforce that. Even with an override flag, there are some possible side effects with bib level holds, though... For sure I can see problems for consortia that have set-in-stone rules about which branches can and cannot share resources, but allow overrides for other reasons. With a simple true/false override flag, a hold that was placed with an override for other reasons (e.g. patron category, hold limits, etc) could unintentionally override the branch restriction and trigger a transfer that may not be possible or reasonable to actually fulfill. I'm not sure what the solution is here. - Flagging which specific policies were overridden when the hold was placed? (seems messy and with a high potential for side effects) - More granularity in the sysprefs governing which policies are allowed to be overridden at all? (I think this would be great, but not sure if this is the right place) - Apply this enhancement only to item-level holds, or give TriggerForbiddenHolds three settings - All / Item-level only / Off? We at MCPL would definitely like to see something like this go through (our staff often place holds to get their hands on items for workflow reasons, and currently that doesn't work for items that aren't normally holdable). But I think it needs a bit more examination to make sure it isn't unusable for systems that need to keep some things set in stone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:41:14 +0000 Subject: [Koha-bugs] [Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20955 CC| |emily.lamancusa at montgomeryc | |ountymd.gov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 17:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 15:41:14 +0000 Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169 [Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:06:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:06:41 +0000 Subject: [Koha-bugs] [Bug 34395] Inconsistencies in Authority types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34395 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:06:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:06:44 +0000 Subject: [Koha-bugs] [Bug 34395] Inconsistencies in Authority types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34395 --- Comment #2 from Owen Leonard --- Created attachment 156507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156507&action=edit Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and header This patch fixes some inconsistencies in the authority types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Authority types - New authority type - Edit authority type - Delete an authority type which is not used - Delete an authority type which is in use - Authority type MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:24:26 +0000 Subject: [Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:29:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:29:58 +0000 Subject: [Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:30:00 +0000 Subject: [Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 --- Comment #1 from Owen Leonard --- Created attachment 156508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156508&action=edit Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the classification configuration administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each view to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Classification configuration - New classification source - Edit classification source - New filing rule - Edit filing rule - New splitting rule - Edit splitting rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:57:24 +0000 Subject: [Koha-bugs] [Bug 34963] Unable to delete notes in suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 18:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 16:59:59 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:15:53 +0000 Subject: [Koha-bugs] [Bug 34978] New: Add --include and --exclude options to install_plugins.pl to choose the plugins to install Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Bug ID: 34978 Summary: Add --include and --exclude options to install_plugins.pl to choose the plugins to install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: emily-rose.francoeur at inLibro.com QA Contact: testopia at bugs.koha-community.org It would be great to be able to choose which plugins to install and which ones not to install when using the install_plugins.pl script([Koha]/misc/devel/install_plugins.pl). The --include option would take a list of plugins and only install those. The --exclude option would take a list of plugins and install all plugins except those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:16:47 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com, | |emily-rose.francoeur at inLibr | |o.com, | |philippe.blouin at inlibro.com Assignee|koha-bugs at lists.koha-commun |emily-rose.francoeur at inLibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:42:04 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:42:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:42:06 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #1 from Owen Leonard --- Created attachment 156509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156509&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:51:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:51:27 +0000 Subject: [Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:56:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:56:10 +0000 Subject: [Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:56:12 +0000 Subject: [Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399 --- Comment #1 from Owen Leonard --- Created attachment 156510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156510&action=edit Bug 34399: Fix inconsistencies in Record overlay rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record overlay rules page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test the record matching rules page to confirm that page title, heading, and breadcrumbs are consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 19:58:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 17:58:21 +0000 Subject: [Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 20:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 18:23:34 +0000 Subject: [Koha-bugs] [Bug 34979] New: AutoApprovePatronProfileSettings missing from sysprefs.sql Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Bug ID: 34979 Summary: AutoApprovePatronProfileSettings missing from sysprefs.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I'm wondering if this is normal. The system preference AutoApprovePatronProfileSettings is in updatedatabase.pl and in patrons.pref, but not in sysprefs.sql (unless I'm not looking in the right place). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 20:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 18:39:15 +0000 Subject: [Koha-bugs] [Bug 34979] AutoApprovePatronProfileSettings missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #1 from Caroline Cyr La Rose --- Also missing - EmailSMSSendDriverFromAddress - HidePersonalPatronDetailOnCirculation - ManaToken - OPACDetailQRCode - OverDriveAuthname - OverDriveWebsiteID - RecordStaffUserOnCheckout - SelfCheckInModuleUserID And not removed from the db after being moved out of sysprefs, also not sure if it's supposed to be like that or not. - OpacMoreSearches - OPACMySummaryNote This one is in sysprefs.sql but not in updatedatabase.pl - UpdateNotForLoanStatusOnCheckout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 20:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 18:39:39 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AutoApprovePatronProfileSet |System preferences missing |tings missing from |from sysprefs.sql |sysprefs.sql | --- Comment #2 from Caroline Cyr La Rose --- Feel free to close if this is completely irrelevant :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 20:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 18:46:01 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #4 from Christopher Brannon --- (In reply to Christopher Brannon from comment #1) > I agree that this AllowHoldsOnPatronsPossessions is a problem. > > Currently, we have certain records that we allow mulitple holds on. The > patron cannot place a hold on one of these items if they have something on > that record checkout out and AllowHoldsOnPatronsPossessions is set to Don't > allow. This preference needs to take into account circ rules that allow > multiple holds on a record. Would really like to see this oversight or conflict in logic addressed. It is an ongoing issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 21:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 19:20:19 +0000 Subject: [Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 Suzanne changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 --- Comment #2 from Suzanne --- Any chance we could get some movement on this bug? It is a continued source of frustration for patrons and staff. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 21:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 19:33:07 +0000 Subject: [Koha-bugs] [Bug 34552] No Results when filtering "All payments to the library" or "payment" in Statistics wizards : Cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #21 from Christopher Brannon --- (In reply to Matt Blenkinsop from comment #20) > Nice work everyone! > > Pushed to oldstable for 22.11.x Thank you! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 21:39:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 19:39:31 +0000 Subject: [Koha-bugs] [Bug 34925] Favorite reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34925 --- Comment #2 from Christopher Brannon --- (In reply to Michael Adamyk from comment #1) > This would be different from a Report Group so that you could have any > report marked as a Favorite, regardless of its Report Group -- is that > correct? Correct. It would also be based on the logged in person. If a table was in order, it might be foresight to construct the table in such away that the borrowernumber and table it is referring to is listed, in addition to specific report number. That way, if we found use of favorites elsewhere in Koha, we could use the same table to store those favorites. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 21:56:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 19:56:32 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 21:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 19:56:35 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156506|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 156511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156511&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 22:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 20:06:18 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some release notes| |inconsistencies in the MARC | |bibliographic framework | |administration page, making | |sure the page title, | |breadcrumb navigation, and | |page headers are consistent | |with each other. CC| |david at davidnind.com --- Comment #4 from David Nind --- I've signed off, but there were two that I wasn't sure of. 1. View subfield constraints ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Tab title: Tag 006 > Books, Booklets, Workbooks (BKS) > MARC bibliographic frameworks > Administration > Koha Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 subfield structure Page title: Tag 006 subfield structure (framework BKS) Comment: maybe the tab title should be 'Tag XXX subfield structure'? 2. Edit subfield constraints ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Tab title: Edit subfields constraints > Tag 006 > Books, Booklets, Workbooks (BKS) > MARC bibliographic frameworks > Administration > Koha Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 > Edit subfields constraints Page title: Tag 006 subfield constraints Comment: I don't know why, but 'subfields constraints' seems wrong to me. There could be multiple subfields, with each of them having constraints. But it just sounds wrong to me... So I prefer 'Tag 006 subfield constraints'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 00:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 22:03:43 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 00:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 22:35:14 +0000 Subject: [Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 --- Comment #2 from David Cook --- Having a single master key isn't uncommon, but it could be nice to be able to have multiple encryption keys and to specify which one is needed for what feature. I think that this mechanism could be especially useful for key rotation. (I notice Marcel has already commented on bug 32078 where we had talked a bit about key rotation.) I've used other systems where I've rotated encryption keys in this way. Another future use could be data interchange. Perhaps you'd want to share encrypted data with another system without giving that other system your master key. You could just encrypt that particular information with a shared key while keeping most other data encrypted using a master key. This scenario is pretty hypothetical though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:23:08 +0000 Subject: [Koha-bugs] [Bug 33934] 'No encryption_key in koha-conf.xml' needs more detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33934 --- Comment #16 from David Cook --- (In reply to Marcel de Rooy from comment #15) > For purists, taken from Crypt::CBC > > -pass,-key The encryption/decryption passphrase. These arguments > are interchangeable, but -pass is preferred > ("key" is a misnomer, as it is not the literal > encryption key). > > So our "encryption key" is a misnnomer too :) > It is a passphrase used to generate the real encryption key. That's true although I think colloquially it's all right to call it the encryption key. > We say now: We recommend one of at least 32 bytes. > It should be formally at least 16 bytes (AES blocksize) in order to be safe. > So 32 is fine. Shouid we enforce a minimum length in Koha::Encryption? Probably a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:26:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:26:16 +0000 Subject: [Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #4 from David Cook --- Thanks for taking care of this, Owen. You're a legend. I haven't had time lately so really appreciate it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:27:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:27:32 +0000 Subject: [Koha-bugs] [Bug 34980] New: Remove the use of event attributes from title-actions-menu.inc in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Bug ID: 34980 Summary: Remove the use of event attributes from title-actions-menu.inc in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org There are some event attributes in the title-actions-menu.inc include. These should be removed in favor of defining events in JavaScript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:27:38 +0000 Subject: [Koha-bugs] [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:27:38 +0000 Subject: [Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:29:09 +0000 Subject: [Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #5 from David Cook --- Using the following I found one more instance: egrep -R " on[a-z]+=" koha-tmpl/opac-tmpl/* Bug 34980 Once we've pushed the dependent bugs, we'll be adhering to https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events in the OPAC! It would also allow us to start using Content-Security-Policy in the OPAC... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 01:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Oct 2023 23:57:33 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 02:20:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 00:20:59 +0000 Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852 --- Comment #6 from David Cook --- I've been thinking about this topic for some time... and maybe a solution is to create a new Template::Toolkit filter that uses C4::Scrubber/HTML::Scrubber. An old version already exists on CPAN: https://metacpan.org/pod/Template::Plugin::Filter::HTMLScrubber We could either use that one or come up with our own. The tough part here is the configuration. Deciding how rigid/flexible to make it for long-term maintainability but also end-user usability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 02:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 00:24:04 +0000 Subject: [Koha-bugs] [Bug 34335] Run Koha plugin method from CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #14 from David Cook --- (In reply to Marcel de Rooy from comment #13) > Why not just call something like: > > perl -MKoha::Plugin::RMA::ItemHook::Adapter > -e"Koha::Plugin::RMA::ItemHook::Adapter->new->install" > > etc. > > Do we really need a script for that? That's an overly simplistic example. For a more complicated example, you'd need to write a full custom Perl script. This change means you don't need a custom script. You can just pass in configuration/data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 02:26:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 00:26:55 +0000 Subject: [Koha-bugs] [Bug 34335] Run Koha plugin method from CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #15 from David Cook --- If folk don't want it in core Koha, that's fine. I'm already using this pattern in existing plugins. I've found it useful and thought others would too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 06:44:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 04:44:01 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:16:07 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153290|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 156512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156512&action=edit Bug 30700: Allow staff users to change their password via staff client Patrons who can log into the staff client (have the 'catalogue' permission) should be able to change their own password. To test: 0) Apply the patch, install database updates, restart services. Go to System preferences and enable the StaffLoginResetPassword system preference. 1) Create a user with only 'catalogue' permissions (Patron A) 2) Log in to the staff client as Patron A 3) Click the menu with your username in the top-right of the window. Click the 'your account' menu link. 4) Confirm you are forced to a login screen, so you cannot view your account, which is where the 'change password' link is normally found. 5) Try to access the page to change your password directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap Patron A's borrowernumber in). Confirm you are forced to a login screen. 6) Apply this patch and restart services. Go back to the mainpage logged in as Patron A. 7) Click the menu with your username in the top-right of the window. Notice there is now a 'Change password' menu link. Go to 'change password'. 8) Confirm you are now shown a page to change your password. Change your password, and confirm you are redirect to the mainpage. 9) Try to access the page to change someone else's page directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap some other borrowernumber in). Confirm you are redirected to a 404. 10) Log out and log back in as your original borrower. Confirm you are able to change your password as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind Signed-off-by: Sam Lau Rebased-by: Victor Grousset/tuxayo Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:16:10 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153291|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo --- Created attachment 156513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156513&action=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:16:13 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153292|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 156514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156514&action=edit Bug 30700: (follow-up) Redirect to patron page after changing password This patch ensures the logged in user is redirected to the patron detail page after successfully changing another patron's password (rather than the homepage). Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:18:29 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156513|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 156515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156515&action=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. Signed-off-by: Sam Lau Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:18:36 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156514|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 156516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156516&action=edit Bug 30700: (follow-up) Redirect to patron page after changing password This patch ensures the logged in user is redirected to the patron detail page after successfully changing another patron's password (rather than the homepage). Signed-off-by: Sam Lau Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:28:05 +0000 Subject: [Koha-bugs] [Bug 20192] ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192 Roland Keck changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #5 from Roland Keck --- Can be closed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 07:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 05:39:22 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | Status|Signed Off |Failed QA --- Comment #29 from Victor Grousset/tuxayo --- Works as expected, here is a 2nd signoff :) I couldn't get it to change the password of another user via editing and resending the POST query 😈 and the code looks well guarded against that 👍 Code looks good functionally. I found this: `print $input->redirect(...)` followed by `exit;` is used in many other pages to make guard closes. So it seems to me we can avoid wrapping the whole happy path in an `else {...}` That also avoids the need to indent tons of lines. Or to choose to not do it which makes perltidy complain a lot. And about much more than actually changed lines. So just some polishing and it will be good :) I'll go ask about what should be the default value of StaffLoginResetPassword for new installs and existing installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 08:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 06:49:09 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #39 from Martin Renvoize --- Hi all, Sorry for the dark here, I've been rebasing and fixing some further bugs highlighted during testing. There are now a series of sandboxes setup for different timezones on the ptfs-e sandbox system. I am continuing to iterate still as feedback comes in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 09:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 07:15:55 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 --- Comment #9 from Jonathan Druart --- We need confirmation from Christophe that the patch fixes his problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 09:31:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 07:31:24 +0000 Subject: [Koha-bugs] [Bug 34981] New: XSS handling - Scrub all the things Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34981 Bug ID: 34981 Summary: XSS handling - Scrub all the things Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 09:37:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 07:37:07 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 --- Comment #10 from Christophe TORIN --- Hi, I just applied the patch on our platform and it fixes the problem on our side ! Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:15:36 +0000 Subject: [Koha-bugs] [Bug 34150] Personal name (100a) field missing tag editor on acquisition framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34150 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com --- Comment #1 from Aude Charillon --- We are seeing this issue on 22.11 too. It sounds logical that the section shown in Esther Melander's screenshot should follow the acquisitions framework as set up in Administration > MARC bibliographic frameworks. But without the tag editor button, the author fields linked to the authority file are unusable. Here are a few more details on what we are doing: 1. Set the RequireChoosingExistingAuthority system preference to "require". 2. Set the UseACQFrameworkForBiblioRecords system preference to "Use". 3. Check the ACQ framework has a field linked to authorities, e.g. 100a to PERSO_NAME or 110a to CORPO_NAME. 4. In Acquisitions, find a vendor and add to a basket "from a new (empty) record. 5. See that the author fields are locked but there is no tag editor button to select an authority - like there is when adding a new record in the Cataloguing module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:26:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:26:07 +0000 Subject: [Koha-bugs] [Bug 34355] Automated MARC record ordering process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:44:26 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > I'd say that code related to AllowHoldsOnPatronsPossessions (from > reserve/request.pl and opac/opac-reserve.pl) must be moved to > C4::Reserves::CanBookBeReserved Done on bug 22806. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:48:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:48:27 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #6 from Jonathan Druart --- Created attachment 156518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156518&action=edit Bug 16260: Remove CheckIfIssuedToPatron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:48:29 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #7 from Jonathan Druart --- Created attachment 156519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156519&action=edit Bug 16260: Adjust logic of AllowHoldsOnPatronsPossessions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:49:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:49:51 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #8 from Jonathan Druart --- I think this patch is doing what you are expecting, but I am not sure this is a change everybody will agreed on. The syspref's description is clear enough: "Allow/Do not allow a patron to place a hold on a record where the patron already has one or more items attached to that record checked out." Patch for discussion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:50:04 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26058 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 10:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 08:50:04 +0000 Subject: [Koha-bugs] [Bug 26058] Add ability for AllowHoldsOnPatronsPossessions to be limited by item type, collection code or shelving location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16260 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:01:30 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 --- Comment #11 from Jonathan Druart --- (In reply to Christophe TORIN from comment #10) > Hi, > > I just applied the patch on our platform and it fixes the problem on our > side ! > > Thank you Great, thanks for the quick reply! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:22:30 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #25 from Jonathan Druart --- I think we should move the logic enrollment_fee logic to the notice template + $fees->{$recent->branchcode} = $recent->category->enrolmentfee if !exists $fees->{$recent->branchcode}; + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if $fees->{$recent->branchcode} > 0; It can be [% patron.category.enrolmentfee %], and we don't add black magic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:28:34 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #26 from Jonathan Druart --- Hum, and why are you using the branchcode as the key of $fees? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:41:28 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- Please clarify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:42:28 +0000 Subject: [Koha-bugs] [Bug 34982] New: admin currencies table not showing pagination Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 Bug ID: 34982 Summary: admin currencies table not showing pagination Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org and only the first 20 entries are displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:43:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:43:48 +0000 Subject: [Koha-bugs] [Bug 34982] admin currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 11:43:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 09:43:50 +0000 Subject: [Koha-bugs] [Bug 34982] admin currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 --- Comment #1 from Jonathan Druart --- Created attachment 156520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156520&action=edit Bug 34982: Add pagination to the currencies table Otherwise we only display the first 20. Test plan: Create more than 20 currencies and confirm that you can know filter the table and see all the currencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 12:39:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 10:39:03 +0000 Subject: [Koha-bugs] [Bug 34335] Run Koha plugin method from CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #16 from Marcel de Rooy --- (In reply to David Cook from comment #15) > If folk don't want it in core Koha, that's fine. > > I'm already using this pattern in existing plugins. I've found it useful and > thought others would too. I do not have a strong objection either. Just asking for some feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 12:45:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 10:45:33 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > Hum, and why are you using the branchcode as the key of $fees? Thats a good question. It seems to be a typo. I do not recall another reason right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 12:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 10:46:04 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #29 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > I think we should move the logic enrollment_fee logic to the notice template > > + $fees->{$recent->branchcode} = $recent->category->enrolmentfee if > !exists $fees->{$recent->branchcode}; > + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if > $fees->{$recent->branchcode} > 0; > > It can be [% patron.category.enrolmentfee %], and we don't add black magic. Will have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 12:53:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 10:53:11 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:14:35 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:14:37 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #5 from Owen Leonard --- Created attachment 156521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156521&action=edit Bug 34393: (follow-up) QA fixes and further refinement This patch addresses issues discovered during testing and fixes a couple of issues which were missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:19:57 +0000 Subject: [Koha-bugs] [Bug 34150] Personal name (100a) field missing tag editor on acquisition framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34150 --- Comment #2 from Katrin Fischer --- I believe the configurable acq form was not thought to be a full replacement of the cataloguing editor, but to provide a more flexibility than the older hard coded form. What could help here is removing the Thesaurus from 100(a) to make the field editable at least. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:49:16 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #30 from Marcel de Rooy --- Nice that both enrollmentfee and enrolment fee are correct spellings.. Please ignore that inconsistency here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:50:26 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:50:29 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155222|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 156522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156522&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy [EDIT] Enrollment fee via object instead of substitute hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:50:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:50:32 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155223|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 156523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156523&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy [EDIT] Removed $fees and $substitute in favor of notice approach -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:50:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:50:35 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155224|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 156524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156524&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:50:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:50:39 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155225|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 156525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156525&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:51:53 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #35 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > I think we should move the logic enrollment_fee logic to the notice template > > + $fees->{$recent->branchcode} = $recent->category->enrolmentfee if > !exists $fees->{$recent->branchcode}; > + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if > $fees->{$recent->branchcode} > 0; > > It can be [% patron.category.enrolmentfee %], and we don't add black magic. Removed the $fees and $substitute construct now and moved it to the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 13:54:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 11:54:22 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #36 from Marcel de Rooy --- New test result: +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ | message_id | letter_id | borrowernumber | subject | content | metadata | letter_code | message_transport_type | status | time_queued | updated_on | to_address | from_address | reply_address | content_type | failure_code | +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ | 513 | 173 | 50 | Account renewal | Dear Tommy Peters, Your library account has been renewed. The new expiry date is: 2032-01-04. An enrollment fee of $12.35 has been applied. Thank you, Your library, Springfield | | MEMBERSHIP_RENEWED | email | pending | 2023-10-04 11:47:28 | 2023-10-04 11:47:28 | NULL | noreply at master.rijkskoha.nl | NULL | NULL | | +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:21:53 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:21:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:21:56 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156100|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 156526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156526&action=edit Bug 14092: Add 'any status' option to acq order search form Sometimes it's really helpful to see all orders for a basket, a vendor or a standing order, including the cancelled ones. Currently this is not possible, as we have search options for every single status and one for "any except cancelled", but no "Any status" option. This patch adds the "Any status" option. The sometimes appearing empty entry is updated to "Any status except cancelled" as this is what it does. Testing data: * Requires multiple order lines with different order status * Must include at least one order line with status 'cancelled' To test: * Go to acquisitions * Open the advanced search page from the top search options: Order search > config icon > Advanced search link * Verify the status pull down looks as described above * Apply patch * Verify there is now an "Any status" option in the pull down * Try searches for different status, including "Any status" * Verify the results are as expected * Create a new basket * Create an order line by 'From an existing order (copy)' * Verify the search form there also works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:21:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:21:59 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #15 from Katrin Fischer --- Created attachment 156527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156527&action=edit Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:22:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:22:14 +0000 Subject: [Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 --- Comment #3 from Marcel de Rooy --- Using one encryption key for whole Koha is obviously more convenient than carrying a large keychain but is unsafer too. If you get that key, you can decrypt everything. Interesting question though would be: How would you get one key and not the others? And underlying, is koha-conf the best place to save them? Easy to ask, harder to answer. If you would get secrets from some vault, you still need a token for that, etc. As David referred to the rotation bug, the management of data encrypted with which key and what version becomes a bit harder.. Security always has a price. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:24:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:24:19 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #16 from Katrin Fischer --- Hi Marcel, ready for another go. As you suggested a squash I added my follow-up into the last patch: * Corrected the unit test result message * Removed the vendor_note as 'identifier' for the order lines in favor of the basketno -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 14:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 12:24:34 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:00:30 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:00:30 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20057 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:01:44 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:01:44 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20356 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:02:24 +0000 Subject: [Koha-bugs] [Bug 21121] New syspref to allow hiding of private patron data in circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:02:24 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21121 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:05 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : Data sharing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:05 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17047 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:24 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:27 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155161|0 |1 is obsolete| | Attachment #155162|0 |1 is obsolete| | Attachment #155163|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 156528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156528&action=edit Bug 33245: TestBuilder: Default value for anonymized When we create a patron with TestBuilder, we normally do not expect an anonymized status. This will certainly hold for the patrons we are creating for testing is_active in a following patch. Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:29 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #19 from Jonathan Druart --- Created attachment 156529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156529&action=edit Bug 33245: Introduce patron->is_active Does only add the new patron method. NOTE: We may define additional criteria at some point, but I think that this is a good starting point. Test plan: Run perl -MKoha::Patron -e'print Koha::Patrons->find(X)->is_active(Y);' Note: replace X by a valid borrowernumber and Y by date criterium. Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:32 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #20 from Jonathan Druart --- Created attachment 156530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156530&action=edit Bug 33245: Add unit test Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop JD amended patch: Adjust number of tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:40 +0000 Subject: [Koha-bugs] [Bug 23566] Continue on device - with QR codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:40 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:03:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:03:55 +0000 Subject: [Koha-bugs] [Bug 34983] New: Retranslating causes changes in locale_data.json Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 Bug ID: 34983 Summary: Retranslating causes changes in locale_data.json Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Actually, nothing may have changed. But the hash keys are processed in random order. We could force ordering them at a slightly slower rate. Advantage would be to see only changes when translations really changed. Actually, the performance changes that I saw were neglectible. The staff po file is converted in about 600-700 ms both ways. Sometimes the one is faster than the other even. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:04:07 +0000 Subject: [Koha-bugs] [Bug 34983] Retranslating causes changes in locale_data.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:04:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:04:12 +0000 Subject: [Koha-bugs] [Bug 34983] Retranslating causes changes in locale_data.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:04:27 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:04:30 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155164|0 |1 is obsolete| | Attachment #155165|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 156531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156531&action=edit Bug 33522: Add active and inactive parameter to membership_expiry.pl Test plan: Enable TrackLastPatronActivity. Set MembershipExpiryDaysNotice to X days. Pick a patron, make it expire in X days. Add email address. Update borrowers.lastseen for this patron to make it active. Run membership_expiry.pl -c -v -active 6 You should see at least one enqueued notice. Run membership_expiry.pl -c -v -inactive 6 You should see that it skipped a number of active patrons (>=1). Signed-off-by: Marcel de Rooy Signed-off-by: Sam Lau Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:04:33 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 --- Comment #9 from Jonathan Druart --- Created attachment 156532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156532&action=edit Bug 33522: (follow-up) Do not rely on fallback Bug 33245 has been adjusted; the fallback has been removed. We should check now if the -active or -inactive parameter actually has been passed. Test plan: See earlier test plan. Run the script without active/inactive. Run the script with active. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:04 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:08 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156522|0 |1 is obsolete| | Attachment #156523|0 |1 is obsolete| | Attachment #156524|0 |1 is obsolete| | Attachment #156525|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 156533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156533&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy [EDIT] Enrollment fee via object instead of substitute hash. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:11 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #38 from Jonathan Druart --- Created attachment 156534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156534&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy [EDIT] Removed $fees and $substitute in favor of notice approach Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:15 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #39 from Jonathan Druart --- Created attachment 156535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156535&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:18 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #40 from Jonathan Druart --- Created attachment 156536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156536&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:05:22 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #41 from Jonathan Druart --- Created attachment 156537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156537&action=edit Bug 28688: Use pod2usage for incorrect usage Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:14:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:14:53 +0000 Subject: [Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:14:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:14:54 +0000 Subject: [Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 --- Comment #27 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:14:56 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:14:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:14:57 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:14:59 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:00 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:01 +0000 Subject: [Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:03 +0000 Subject: [Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:04 +0000 Subject: [Koha-bugs] [Bug 34911] Test suite no longer run test critic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:05 +0000 Subject: [Koha-bugs] [Bug 34911] Test suite no longer run test critic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:06 +0000 Subject: [Koha-bugs] [Bug 34912] Account(s).t tests fail in UTC+1 and higher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34912 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:08 +0000 Subject: [Koha-bugs] [Bug 34912] Account(s).t tests fail in UTC+1 and higher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34912 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:09 +0000 Subject: [Koha-bugs] [Bug 34916] ArticleRequests.t may fail on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34916 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:10 +0000 Subject: [Koha-bugs] [Bug 34916] ArticleRequests.t may fail on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34916 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:11 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:13 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:14 +0000 Subject: [Koha-bugs] [Bug 34944] Remove the use of event attributes from OPAC full serial issue page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:15 +0000 Subject: [Koha-bugs] [Bug 34944] Remove the use of event attributes from OPAC full serial issue page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:16 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:18 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:19 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:15:20 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:18:34 +0000 Subject: [Koha-bugs] [Bug 34983] Retranslating causes changes in locale_data.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:18:36 +0000 Subject: [Koha-bugs] [Bug 34983] Retranslating causes changes in locale_data.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 --- Comment #1 from Marcel de Rooy --- Created attachment 156538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156538&action=edit Bug 34983: Force a sort order in JSON output of po2json This patch does so by default. If you do not want them sorted, export CANONICAL-0 on the command line. Test plan: Copy a staff PO file from misc/translator to test.po Now run: time misc/translator/po2json test.po > json1 And do: time misc/translator/po2json test.po > json2 Run: diff json1 json2; #They should be the same. Now: export CANONICAL=0 And run: time misc/translator/po2json test.po > json3 And again: time misc/translator/po2json test.po > json4 And run: diff json3 json4; # Lots of changes Remove the created cruft. And signoff :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:20:15 +0000 Subject: [Koha-bugs] [Bug 34983] Retranslating causes changes in locale_data.json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34983 --- Comment #2 from Marcel de Rooy --- if you test, please check the times reported for the various runs. If you see something unusual, please copy it on the report here. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:23:29 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #1 from Émily-Rose Francoeur --- Created attachment 156539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156539&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It’s possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include Test1 --include Koha::Plugin::Test2 TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command : "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project : "./misc/devel/install_plugins.pl --exclude --exclude ” 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:23:57 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:24:20 +0000 Subject: [Koha-bugs] [Bug 34800] Update contributor openhub links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- How did you generate the list? Did you write a script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:25:24 +0000 Subject: [Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:25:24 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21082 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:26:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:26:44 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #42 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #41) > Signed-off-by: Jonathan Druart Great! Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:27:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:27:10 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:27:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:27:10 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:28:34 +0000 Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:28:34 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15492 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:28:42 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #43 from Jonathan Druart --- (Note that we should remove the Options part from the SYNOPSIS, it's redundant when you get the help message). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:30:16 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:30:16 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24220 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:32:48 +0000 Subject: [Koha-bugs] [Bug 28224] Make date range for order search configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Why don't you make the value sticky and store it into a cookie instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:21 +0000 Subject: [Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:22 +0000 Subject: [Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:24 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:25 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:26 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:28 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:29 +0000 Subject: [Koha-bugs] [Bug 34619] Show debug mode column in list of SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34619 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:30 +0000 Subject: [Koha-bugs] [Bug 34619] Show debug mode column in list of SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34619 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:32 +0000 Subject: [Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:33 +0000 Subject: [Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:34 +0000 Subject: [Koha-bugs] [Bug 34825] Move Letters.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34825 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:35 +0000 Subject: [Koha-bugs] [Bug 34825] Move Letters.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34825 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:36 +0000 Subject: [Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:38 +0000 Subject: [Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:39 +0000 Subject: [Koha-bugs] [Bug 34865] Syspref OPACURLOpenInNewWindow not working for Library URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:40 +0000 Subject: [Koha-bugs] [Bug 34865] Syspref OPACURLOpenInNewWindow not working for Library URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:42 +0000 Subject: [Koha-bugs] [Bug 34887] Merge Patron.t into t/db/Koha/Patron.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34887 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:43 +0000 Subject: [Koha-bugs] [Bug 34887] Merge Patron.t into t/db/Koha/Patron.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34887 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:43 +0000 Subject: [Koha-bugs] [Bug 28224] Make date range for order search configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Why don't you make the value sticky and store it into a cookie instead? Well, you will need a separate field on the form of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:44 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:33:45 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:37:46 +0000 Subject: [Koha-bugs] [Bug 28224] Make date range for order search configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 --- Comment #6 from Jonathan Druart --- Having a syspref for that purpose feels wrong to me. You could even do it using some JS code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:38:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:38:25 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #3 from Caroline Cyr La Rose --- For OpacMoreSearches and OPACMySummaryNote, I see they are removed in dbrevs, but I ran updatedatabase.pl on an old db and they are still there. This might be a 'me' problem, (i.e. I might not be doing something correctly) I don't know... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:38:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:38:35 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #4 from Caroline Cyr La Rose --- For OpacMoreSearches and OPACMySummaryNote, I see they are removed in dbrevs, but I ran updatedatabase.pl on an old db and they are still there. This might be a 'me' problem, (i.e. I might not be doing something correctly) I don't know... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:39:15 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #21 from Tomás Cohen Arazi --- Please rebase the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:43:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:43:04 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #44 from Marcel de Rooy --- Created attachment 156540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156540&action=edit Bug 28688: (follow-up) Remove redundant options Test plan: Run misc/cronjobs/membership_expiry.pl --help misc/cronjobs/membership_expiry.pl --man Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:51 +0000 Subject: [Koha-bugs] [Bug 32676] EDI message status uses varying case, breaking EDI status block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32676 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:53 +0000 Subject: [Koha-bugs] [Bug 32676] EDI message status uses varying case, breaking EDI status block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32676 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:54 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:56 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:57 +0000 Subject: [Koha-bugs] [Bug 34891] View restrictions button (patrons page) doesn't link to tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:44:58 +0000 Subject: [Koha-bugs] [Bug 34891] View restrictions button (patrons page) doesn't link to tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:45:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:45:00 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:45:01 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:50:08 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156528|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 156541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156541&action=edit Bug 33245: TestBuilder: Default value for anonymized When we create a patron with TestBuilder, we normally do not expect an anonymized status. This will certainly hold for the patrons we are creating for testing is_active in a following patch. Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:50:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:50:10 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156529|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 156542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156542&action=edit Bug 33245: Introduce patron->is_active Does only add the new patron method. NOTE: We may define additional criteria at some point, but I think that this is a good starting point. Test plan: Run perl -MKoha::Patron -e'print Koha::Patrons->find(X)->is_active(Y);' Note: replace X by a valid borrowernumber and Y by date criterium. Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:50:12 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156530|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 156543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156543&action=edit Bug 33245: Add unit test Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop JD amended patch: Adjust number of tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:51:07 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:52:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:52:58 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #21 from Jonathan Druart --- Not considering blocker, but worth raising it: if you pass an invalid header's value ("foobar"), it is ignored. I would have expected swagger's spec validation to raise an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:53:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:53:56 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:53:59 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155396|0 |1 is obsolete| | Attachment #155397|0 |1 is obsolete| | Attachment #155406|0 |1 is obsolete| | Attachment #155407|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 156544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156544&action=edit Bug 33690: Add ability to send welcome notice when creating patrons using the REST API It would be nice to have the ability to send a welcome notice when creating patrons via the API. Test Plan: 1) Apply this patch 2) Ensure you have a WELCOME notice 3) Create a new patron using the REST API ( api/v1/patrons ) 4) Note no welcome notice is sent to the patron ( you can check the notices tab for the patron ) 5) Repeat step 3, but send the header X-Koha-SendWelcomeEmail with a value of 1 as part of the POST 6) Note the welcome message for the patron is in their notices! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Bug 33690: Tidy test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:54:02 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #23 from Jonathan Druart --- Created attachment 156545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156545&action=edit Bug 33690: (QA follow-up) Mock C4::Letters subroutines for unit tests Signed-off-by: Martin Renvoize JD Amended patch: tidy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 15:54:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 13:54:05 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #24 from Jonathan Druart --- Created attachment 156546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156546&action=edit Bug 33690: Convert to x-koha-override This patch converts the existing work to use x-koha-override instead of introducing an entirely new header and we default to the system preference value if the override isn't passed. I believe this is more consistent with our approach in other areas of koha to date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:00:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:00:27 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- Please rebase and add REST API tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:11:33 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:11:36 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152877|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 156547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156547&action=edit Bug 31357: Separate holds history from intranetreadinghistory Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record. It would be helpful to allow the option of setting each of those independently. Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Run updatadatabase.pl 4) Verify the new syspref intranetReadingHistoryHolds has the same value as the existing syspref intranetreadinghistory 5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds 6) Verify you can view a patron's holds history but not reading history Signed-off-by: Sam Lau JD amended patch: * renamed syspref intranetReadingHistoryHolds => IntranetReadingHistoryHolds * tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:12:21 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Kyle, I have renamed the pref to make it start with an uppercase. Hope you agree with that (otherwise say it and I will resubmit). It seems more inline with what we have already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:12:49 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 --- Comment #5 from Jonathan Druart --- It would be nice to rename intranetreadinghistory with IntranetReadingHistory for the same release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:13:24 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152824|0 |1 is obsolete| | --- Comment #14 from Emily Lamancusa --- Created attachment 156548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156548&action=edit Bug 23059: reserve_stats.pl: Simplify reservestatus This patch does the following: [1] Go back to four statuses: Cancelled, Filled, Waiting or Placed. Placed is used as collective name for all other statuses: pending (placed), processing (found==P) or transit (found==T). Placed before anyway. [2] Allow translation of these statuses in the template. Remove the sub reservestatushuman. [3] The output of changeifreservestatus is considerably shorter and less ugly in the constructed sql statement. Test plan: [1] Use reservestatus as row, as column and only as filter (clicking few statuses). [2] Verify that the shown statistics meet your expectations. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:13:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:13:26 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152825|0 |1 is obsolete| | --- Comment #15 from Emily Lamancusa --- Created attachment 156549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156549&action=edit Bug 23059: (QA follow-up) Put status strings in a span No test plan. Read the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:25:07 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |emily.lamancusa at montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa at montgomeryc | |ountymd.gov --- Comment #16 from Emily Lamancusa --- This is a nice improvement to clarity and consistency. Works as intended and QA tool is happy. One thing that would be nice to see as a follow-up would be the ability for libraries that have in-processing and in-transit statuses to be able to separate those out from "Placed". But that requires extra processing to determine whether those statuses are relevant to the library, so it's a bit out of scope for this bug, and doesn't need to block the alignment of the report with the universally-relevant hold statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:32:17 +0000 Subject: [Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 --- Comment #9 from Jonathan Druart --- Koha_Master/2668 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:40:30 +0000 Subject: [Koha-bugs] [Bug 34984] New: Canceling a hold from the holds over tab shouldn't update the last seen date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34984 Bug ID: 34984 Summary: Canceling a hold from the holds over tab shouldn't update the last seen date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: emily.lamancusa at montgomerycountymd.gov Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Canceling a waiting hold from the Holds Over tab currently updates the item's last seen date. However, the fact that the staff member is canceling the hold doesn't necessarily mean they have the item in their hand. If the item is missing from the holds shelf, the staff member may cancel the hold from the holds over tab and mark the item missing, in which case the item's last seen date certainly should not be updated. On the other hand, if the item is there, the staff member is meant to check it in after canceling the hold. That check-in will update the item's last seen date anyway, so again, it is not necessary for it to be updated when the hold is canceled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:47:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:47:40 +0000 Subject: [Koha-bugs] [Bug 34985] New: Add a quantity field to the manual invoice form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Bug ID: 34985 Summary: Add a quantity field to the manual invoice form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: hammat.wele at inlibro.com QA Contact: testopia at bugs.koha-community.org This plugin add a “quantity” field to the manual invoicing form this will allow to automatically multiply the amount when it has a default amount -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:47:55 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hammat.wele at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:52:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:52:50 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" after completing an "and" search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 jesus at medios.es changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesus at medios.es --- Comment #2 from jesus at medios.es --- The search query varies according to the browser used. For Chrome (anonymous) and Firefox the result URL is correct. For Chrome standard it is not: Started happening in 22.11, when this code in opac-advsearch.tt was introduced: window.addEventListener('pageshow', function( e ){ $('.form-control').prop('disabled' , false ); }); Result URL in Chrome https://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?advsearch=1&op=AND&idx=kw&q=keyword1&op=NOT&idx=kw&q=keyword2&do=Search&sort_by=relevance Result URL in Firefox and anonymous Chrome: https://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?advsearch=1&idx=kw&q=keyword1&op=NOT&idx=kw&q=keyword2&do=Search&sort_by=relevance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:53:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:53:17 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:53:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:53:20 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156166|0 |1 is obsolete| | Attachment #156167|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 156550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156550&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla Signed-off-by: Clemens Tubach Bug 28166: Removed comments and _add_rowdata Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored Bug 28166: (QA follow-up) Fix rebase issue Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 16:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 14:53:23 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #28 from Jonathan Druart --- Created attachment 156551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156551&action=edit Bug 28166: (QA follow-up) Fix and tidy tests and code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:26 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:27 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:29 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:30 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:31 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:33 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:34 +0000 Subject: [Koha-bugs] [Bug 33958] Add Koha::Biblio->normalized_oclc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33958 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:36 +0000 Subject: [Koha-bugs] [Bug 33958] Add Koha::Biblio->normalized_oclc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33958 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:37 +0000 Subject: [Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:38 +0000 Subject: [Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 --- Comment #24 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:40 +0000 Subject: [Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:42 +0000 Subject: [Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:44 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 17:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 15:09:45 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 18:38:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 16:38:27 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #6 from Frédéric Demians --- (In reply to David Nind from comment #5) > I was more after a test plan, so I could replicate the issue, apply the > patch, and make sure it fixes things. On an UNIMARC Koha installation, modify let say biblio record 1234: - on leader position 9, enter a blank - on 200$a, add a è Get this biblio record from OAI server with GetRecord verb. Something like that: /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=PREFIX:1234 Replace PREFIX with syspref OAI-PMH:archiveID. You will (should) get a 200$a without a è. Apply the patch, and repeat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 19:03:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 17:03:30 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #1 from Hammat wele --- This patch add a Quantity field and a Cost field to the manual invoice form this will allow to automatically multiply the amount when it has a default amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 19:13:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 17:13:54 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #68 from Andrii Nugged --- One bug in SIP here: File: C4/SIP/Sip/MsgType.pm 0999: if ( C4::Context->preference('TrackLastPatronActivity') ) { 1000: my $koha_patron = Koha::Patrons->find($patron->userid); 1001: $koha_patron->update_lastseen('connection'); 1002: } 1003: $resp .= patron_status_string( $patron, $server ); ERROR: Cannot access 'userid' field of class 'C4::SIP::ILS::Patron' at /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm That: my $koha_patron = Koha::Patrons->find($patron->userid); should be, probably, this way: my $koha_patron = Koha::Patrons->find( { cardnumber => $patron->id } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 19:38:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 17:38:07 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #2 from Hammat wele --- Created attachment 156552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156552&action=edit Bug 34985: Add a quantity field to the manual invoice form This patch add a Quantity field and a Cost field to the manual invoice form this will allow to automatically multiply the amount when it has a default amount. Test plan: 1) Apply the patch 2) Create multiple charge types some with default amount and some without default amount 1-1) Go to Administraion -> Debit types 1-2) Click on New Debit types 1-3) Fill the form check the "Can be manually invoiced?" field 1-5) Click on save 3) Create a manual invoice 2-1) Find a patrons 2-2) Click on Accounting tab 2-3) Click on Create manual invoice tab 2-4) Select a type with default amount set ->Cost field and Quantity field should be added to the form 2-5) Edit the Cost field or Quantity field ->The amount will be automatically calculate 2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 20:16:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 18:16:04 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |caroline.cyr-la-rose at inlibr | |o.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 20:53:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 18:53:09 +0000 Subject: [Koha-bugs] [Bug 34925] Favorite reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34925 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 20:59:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 18:59:10 +0000 Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 --- Comment #9 from Christopher Brannon --- So, my concern is, we don't want to just turn this system preference on for everything, but we have had to, because we have a mixed bag of records. Usually, a record has multiple copies of the same thing. We don't need one person monopolizing those items. However, we also have records that contain many different things. Like serials. Every copy for a title is under one bib. We do want patrons to have the liberty of placing holds on other items while they have an issue from that bib checked out. We currently have to have this preference on. The original function works as it should. We also use the Holds per record rule set to 1 for most items where we don't want people to place a second hold. But that does not account for an item that a patron has checked out. They can still place a hold. What needs to happen is that we need to define if this Holds per record rule includes current issues or not. I think that is the key element that is being overlooked here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:06:27 +0000 Subject: [Koha-bugs] [Bug 34986] New: Display public Z39.50 host and port on about.pl (if enabled) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34986 Bug ID: 34986 Summary: Display public Z39.50 host and port on about.pl (if enabled) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: ian at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If Koha is configured with a public-facing Z39.50 server, display the connection information in the About Koha section so that librarians can easily share this information with anyone they want to be able to connect to them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:07:44 +0000 Subject: [Koha-bugs] [Bug 34986] Display public Z39.50 host and port on about.pl (if enabled) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34986 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ian at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:16:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:16:26 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:17:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:17:02 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:17:04 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #1 from Salah Ghedda --- Created attachment 156553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156553&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:22:40 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Katrin Fischer --- Please switch to failed QA if there is a bug in testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:31:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:31:24 +0000 Subject: [Koha-bugs] [Bug 28224] Make date range for order search configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #6) > Having a syspref for that purpose feels wrong to me. > > You could even do it using some JS code. Not really, because that won't work for the simple search on top. It's what we did in the past, this is a more complete fix. Usually it's not a setting that every person will want to change, it depends on your workflow and the data - like if you have standing orders you will want to have it set to a date further in the past. But it's not so much something you'd need individually per person. And it probably be a bit annoying to have to reset it with every session for that reason. We have a similar setting for the holds to pull page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 21:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 19:44:44 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156553|0 |1 is obsolete| | --- Comment #2 from Salah Ghedda --- Created attachment 156554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156554&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete one list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:05:01 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156539|0 |1 is obsolete| | --- Comment #2 from Émily-Rose Francoeur --- Created attachment 156555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156555&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:16:19 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #125 from Tomás Cohen Arazi --- Created attachment 156556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156556&action=edit Bug 30719: Atomic update fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:20:58 +0000 Subject: [Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156555|0 |1 is obsolete| | --- Comment #3 from Émily-Rose Francoeur --- Created attachment 156557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156557&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:22:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:22:53 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154551|0 |1 is obsolete| | --- Comment #7 from Zeno Tajoli --- Created attachment 156558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156558&action=edit patch for custom.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:25:25 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #126 from Tomás Cohen Arazi --- Hi all. I know the history of this bug and am willing to overlook some things, but as-is I believe this requires some more work. High * The GET /illbatches endpoint is not /ill/batchess? * Illbatches.pm is too old school. Entirely relying on fetching the whole resultset: #FIXME: This should be $c->objects-search my @batches = Koha::Illbatches->search()->as_list; * And crafting the response manually, even the 'patron' attribute is done manually instead of an embed * The request body needs to be manually translated into the DB model: my $batch = Koha::Illbatch->new($body); we have Koha::Illbatches->new_from_api to avoid that. But there's obviously a reason it wasn't done like that. Lower * Table names, and column names: this is using old school naming for things. We can solve it on the API front, but even that is not entirely done. Please let me know if there's anything I can do to help you with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:25:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:25:28 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Zeno Tajoli --- I do a new test and now the warning is not present. So in fact is not more a bug fix but only a refactor / update of defaults. I reformat the patch and rewrite test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:49 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:51 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #78 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:53 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:55 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:56 +0000 Subject: [Koha-bugs] [Bug 34153] Add ability to allow items with additional materials notes to be checked out via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:58 +0000 Subject: [Koha-bugs] [Bug 34153] Add ability to allow items with additional materials notes to be checked out via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:43:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:43:59 +0000 Subject: [Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:00 +0000 Subject: [Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:02 +0000 Subject: [Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:03 +0000 Subject: [Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:05 +0000 Subject: [Koha-bugs] [Bug 34859] reports-home.pl has unnecessary syspref template parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:06 +0000 Subject: [Koha-bugs] [Bug 34859] reports-home.pl has unnecessary syspref template parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:07 +0000 Subject: [Koha-bugs] [Bug 34921] Tabs on Additional Content page need space above In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34921 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:09 +0000 Subject: [Koha-bugs] [Bug 34921] Tabs on Additional Content page need space above In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34921 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:10 +0000 Subject: [Koha-bugs] [Bug 34923] OPAC hold page flatpickr does not allow direct input of dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34923 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 22:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 20:44:12 +0000 Subject: [Koha-bugs] [Bug 34923] OPAC hold page flatpickr does not allow direct input of dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34923 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 23:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 21:11:16 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g --- Comment #3 from Kristi --- Created attachment 156559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156559&action=edit NoDefaultValue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 23:11:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 21:11:44 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #4 from Kristi --- Created attachment 156560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156560&action=edit QuantityFieldDisplay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 23:15:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 21:15:26 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 --- Comment #5 from Kristi --- "2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form" Just to clarify here, these fields are present in the form, but if no default value is set for the Debit Type, the cost is listed as 0.00, and the quantity is 1. See screenshot 34985_NoDefault.PNG This does not seem like problematic behavior, but wanted to call it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 4 23:16:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 21:16:03 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156552|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes --- Created attachment 156561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156561&action=edit Bug 34985: Add a quantity field to the manual invoice form This patch add a Quantity field and a Cost field to the manual invoice form this will allow to automatically multiply the amount when it has a default amount. Test plan: 1) Apply the patch 2) Create multiple charge types some with default amount and some without default amount 1-1) Go to Administraion -> Debit types 1-2) Click on New Debit types 1-3) Fill the form check the "Can be manually invoiced?" field 1-5) Click on save 3) Create a manual invoice 2-1) Find a patrons 2-2) Click on Accounting tab 2-3) Click on Create manual invoice tab 2-4) Select a type with default amount set ->Cost field and Quantity field should be added to the form 2-5) Edit the Cost field or Quantity field ->The amount will be automatically calculate 2-6) Select a type with no default amount set ->Cost field and Quantity field should not be added to the form Signed-off-by: Kristi Krueger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 00:13:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 22:13:00 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 00:13:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 22:13:02 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156554|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 156562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156562&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 00:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 22:15:02 +0000 Subject: [Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |selecting and deleting | |multiple patron lists at | |once, instead of having to | |delete patron lists one at | |a time. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 00:25:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 22:25:54 +0000 Subject: [Koha-bugs] [Bug 34982] admin currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 00:25:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Oct 2023 22:25:56 +0000 Subject: [Koha-bugs] [Bug 34982] admin currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156520|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156563&action=edit Bug 34982: Add pagination to the currencies table Otherwise we only display the first 20. Test plan: Create more than 20 currencies and confirm that you can know filter the table and see all the currencies. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 03:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 01:22:04 +0000 Subject: [Koha-bugs] [Bug 34987] New: Add button to duplicate pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34987 Bug ID: 34987 Summary: Add button to duplicate pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org It would be awesome to be able to duplicate CMS pages so they can be used as templates, without doing a whole copy/paste process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 03:22:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 01:22:11 +0000 Subject: [Koha-bugs] [Bug 34987] Add button to duplicate pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 03:22:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 01:22:11 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34987 [Bug 34987] Add button to duplicate pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 08:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 06:10:29 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #17 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #15) > Signed-off-by: Emily Lamancusa Thx Emily ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 08:13:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 06:13:07 +0000 Subject: [Koha-bugs] [Bug 34988] New: reserve_stats.pl: Further improvements to refine hold status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34988 Bug ID: 34988 Summary: reserve_stats.pl: Further improvements to refine hold status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org >From 23059: "One thing that would be nice to see as a follow-up would be the ability for libraries that have in-processing and in-transit statuses to be able to separate those out from "Placed". But that requires extra processing to determine whether those statuses are relevant to the library, so it's a bit out of scope for this bug, and doesn't need to block the alignment of the report with the universally-relevant hold statuses." How do we define those 'universally-relevant hold statuses' exactly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 08:13:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 06:13:25 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #18 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #16) > This is a nice improvement to clarity and consistency. Works as intended and > QA tool is happy. > > One thing that would be nice to see as a follow-up would be the ability for > libraries that have in-processing and in-transit statuses to be able to > separate those out from "Placed". But that requires extra processing to > determine whether those statuses are relevant to the library, so it's a bit > out of scope for this bug, and doesn't need to block the alignment of the > report with the universally-relevant hold statuses. Opened bug 34988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 08:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 06:14:24 +0000 Subject: [Koha-bugs] [Bug 34988] reserve_stats.pl: Further improvements to refine hold status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 [Bug 23059] reserves_stats.pl: Simplify reserve status handling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 08:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 06:14:24 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34988 [Bug 34988] reserve_stats.pl: Further improvements to refine hold status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 10:25:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 08:25:18 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 10:27:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 08:27:53 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 jesus at medios.es changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC advanced search |OPAC advanced search |operator "not" is searching |operator "not" is searching |as "and" after completing |as "and" on chrome |an "and" search | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 10:47:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 08:47:33 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 11:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 09:26:49 +0000 Subject: [Koha-bugs] [Bug 34989] New: Subscription cannot be added if a control field is set up in "Additional Fields" parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34989 Bug ID: 34989 Summary: Subscription cannot be added if a control field is set up in "Additional Fields" parameter Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: anke.bruns at gwdg.de QA Contact: testopia at bugs.koha-community.org Subscriptions can't be created because of an HTTP 500 and the following message in the plack error log: "Control fields (generally, just tags below 010) do not have subfields, use data() at /usr/share/koha/lib/Koha/Object/Mixin/AdditionalFields.pm line 68." The workaround by Joubu (many thanks!) in the Koha chat was to look whether in Administration > Additional fields > Table 'subscription' (/cgi-bin/koha/admin/additional-fields.pl?tablename=subscription) a MARC field was present that was a control field (ie. without $ field/subfield separator). We indeed had a 001 configured there with MARC field mode "Get value from MARC record" and Searchable=Yes Removing this solved the problem, but perhaps subscriptions should also work if a control field is configured in the place mentioned above? Another thing is that we are not completely sure if the error was produced when we upgraded from 22.05 or if it was present there as well with the additional field set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 11:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 09:56:12 +0000 Subject: [Koha-bugs] [Bug 34990] New: Backgroundjob->enqueue does not send persistent header Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 Bug ID: 34990 Summary: Backgroundjob->enqueue does not send persistent header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Restarting RabbitMQ will make us loose all pending messages (jobs) in the default or long_tasks queue. Although we have a database fallback, this might be a problem when e.g. replacing/restarting a container while the workers did not yet read all messages or were down already, and the restart would activate Rabbit first. Note that this scenario places RabbitMQ in the same container; it surely would be better to put it in its own container. But also in that scenario we can loose messages if we do not add a persistent flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 11:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 09:59:55 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:00:13 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:08:55 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:08:57 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 --- Comment #1 from Marcel de Rooy --- Created attachment 156564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156564&action=edit Bug 34990: Add persistent header when sending msg to RabbitMQ Test plan: NOTE: It is very hard to add a Koha unit test for adding this single header when communicating to RabbitMQ via Stomp plugin. When we would mock the send, we are only testing if perl can pass a hashref to a subroutine ;) Do NOT yet apply this patch. Make sure that RabbitMQ runs. Stop the koha-worker for long_tasks: koha-worker --stop --queue long_tasks myclone Stage a MARC file. Check queues with rabbitmqctl list_queues. Look for: koha_myclone-long_tasks 1 (at least 1) Stop rabbitmq (something like /etc/init.d/rabbitmq-server stop) Start rabbitmq (/etc/init.d/rabbitmq-server start) Check queue again with with rabbitmqctl list_queues. Look for: koha_myclone-long_tasks 0 Your messages have been gone. Now apply this patch. Reiterate the former steps. But note that you will still see a non-empty queue in the last step: koha_myclone-long_tasks 1 (at least 1) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:10:18 +0000 Subject: [Koha-bugs] [Bug 34987] Add button to duplicate pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 34864 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:10:18 +0000 Subject: [Koha-bugs] [Bug 34864] Allow for Web Pages to be duplicated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #1 from Katrin Fischer --- *** Bug 34987 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:45:11 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155907|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 156565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156565&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_ methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:45:14 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #11 from Jonathan Druart --- Created attachment 156566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156566&action=edit Bug 34828: Move to Koha::Biblio::Metadata::Extractor We are not directly linked with the other Koha::Metadata* packages. Better to isolate this under Koha::Biblio::Metadata (at least for now). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:45:17 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #12 from Jonathan Druart --- Created attachment 156567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156567&action=edit Bug 34828: Add Koha::Biblio::Metadata::Extractor::MARC and inherit from it The new usage is now: 1. With a Koha::Biblio object my $extractor = Koha::Biblio::Metadata::Extractor->new({biblio => $biblio}); $extractor->get_normalized_upc; or 2. With a MARC::Record my $extractor = Koha::Biblio::Metadata::Extractor->new({metadata=> $biblio->metadata->record}); $extractor->get_normalized_upc; Note that there are "Inconsistent hierarchy during C3 merge of class" warnings raised by the QA script. We could remove them by replacing the 'use' by 'require' in Koha::Biblio::Metadata::Extractor::MARC (in ->new) but that's suboptimal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:45:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:45:20 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #13 from Jonathan Druart --- Created attachment 156568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156568&action=edit Bug 34828: Make normalized_oclc uses Koha::Biblio::Metadata::Extractor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:47:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:47:56 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23235 Status|ASSIGNED |In Discussion --- Comment #14 from Jonathan Druart --- Hey, what do you think of this change? Note that I don't think we should add this new concept/module/abstraction/complexity if there is no plan to move it further (i.e. a goal/roadmap we share to replace what is C4::Koha and Koha::Biblio that is parsing MARC::Record to get data). Also note that bug 23235 become even more relevant now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:47:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:47:56 +0000 Subject: [Koha-bugs] [Bug 23235] Rename Koha::Biblio->metadata with ->marc_xml to avoid ambiguity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 12:55:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 10:55:43 +0000 Subject: [Koha-bugs] [Bug 34985] Add a quantity field to the manual invoice form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34985 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 13:28:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 11:28:20 +0000 Subject: [Koha-bugs] [Bug 33925] Improve translation of title tags: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155455|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 156569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156569&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section"
where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 13:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 11:33:54 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154590|0 |1 is obsolete| | Attachment #154591|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 156570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156570&action=edit Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld Signed-off-by: AndrewA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 13:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 11:33:57 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 --- Comment #9 from Owen Leonard --- Created attachment 156571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156571&action=edit Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 13:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 11:58:35 +0000 Subject: [Koha-bugs] [Bug 15222] Add to cart option/other list options missing from OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15222 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156014|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 156572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156572&action=edit Bug 15222: Add to cart option/other list options missing from OPAC lists display This patch adds the option to add titles to the cart or a list from the view of a list's contents. To test you should have at least one public list with titles added. Apply the patch and go to the OPAC. - View a public list. - In the toolbar at the top of the table of titles you should see "Add to cart" and "Add to list." The controls should be disabled. - Check checkboxes for one or more titles on the list. - The controls should now be enabled. - Clicking the "Add to cart" button should add the selected titles to the cart. - If you are not logged into the OPAC, clicking the "Add to list" button should trigger an alert, "You must be logged in..." - Log in to the OPAC and view the list again. - Confirm that the "Add to list" control should trigger a popup allowing you to add your selected titles to an existing or a new list. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 14:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 12:11:36 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #44 from Marcel de Rooy --- Frdolin: please see former comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 14:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 12:12:28 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #45 from Marcel de Rooy --- (In reply to David Cook from comment #42) > Sounds good! Hi David Without context this is a confusing remark. What is good. The push or not backporting it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 14:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 12:25:08 +0000 Subject: [Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Marcel de Rooy --- ping Fridolin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:10:29 +0000 Subject: [Koha-bugs] [Bug 26902] Add ability to flag a patron email address as possibly invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:11:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:11:44 +0000 Subject: [Koha-bugs] [Bug 22362] Make item column in cart sortable in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22362 --- Comment #1 from Katrin Fischer --- I just ran into this again looking through old tickets - the item display in the staff interface is really useful, it would be nice if the OPAC could be adapted to be the same or more similar (including sorting!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:28:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:28:00 +0000 Subject: [Koha-bugs] [Bug 23333] Course Reserves: Instuctor search box positioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23333 --- Comment #1 from Katrin Fischer --- It looks a little less odd once some instructors have been added, but it is not clear from looking at the form that this is a search/auto-complete box. It might be nice to make it more consistent with other patron searches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:31:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:31:52 +0000 Subject: [Koha-bugs] [Bug 23125] Tabs in patron account adjust to window size but text does not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23125 --- Comment #2 from Katrin Fischer --- This is still valid in 22.11 and possibly later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:48:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:48:06 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22590 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 16:48:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 14:48:06 +0000 Subject: [Koha-bugs] [Bug 22590] Allow batch printing of routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27949 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:17:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:17:58 +0000 Subject: [Koha-bugs] [Bug 34960] Page does not load at in-page anchor after applying item template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34960 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:18:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:18:02 +0000 Subject: [Koha-bugs] [Bug 34960] Page does not load at in-page anchor after applying item template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34960 Miranda Nero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:18:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:18:14 +0000 Subject: [Koha-bugs] [Bug 34960] Page does not load at in-page anchor after applying item template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34960 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:19:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:19:47 +0000 Subject: [Koha-bugs] [Bug 34960] Page does not load at in-page anchor after applying item template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34960 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:20:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:20:06 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Miranda Nero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:35:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:35:55 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Severity|trivial |critical --- Comment #3 from Frédéric Demians --- It's not good at all :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:44:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:44:55 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 --- Comment #4 from Frédéric Demians --- The culprit is bug 33233. It should be reverted or amended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:45:31 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:45:31 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:57:13 +0000 Subject: [Koha-bugs] [Bug 34991] New: Collapsed 245 subfields still show by default in Fast Add Framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34991 Bug ID: 34991 Summary: Collapsed 245 subfields still show by default in Fast Add Framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I was trying to further simplify the Fast Add bibliographic framework for a client and collapsing 245$h, 245$n, and 245$p doesn't work. I've only had the problem with field 245. I think it may be related to the fact that in the FA framework, it's in tab 0, but I'm not sure. To recreate: 1. Go to Administration > MARC bibliographic framework 2. Click Actions > MARC structure next to the Fast Add Framework 3. Click Actions > Edit subfields next to the 245 field 4. Change visibility of subfields as follows: - 6: uncheck Editor - 8: uncheck editor - a: (leave as is) - b: (leave as is) - c: (leave as is) - d: uncheck Editor - e: uncheck Editor - f: uncheck Editor - g: uncheck Editor - h: check Collapsed - k: uncheck Editor - n: check Collapsed - p: check Collapsed - s: uncheck Editor 5. Click Save changes 6. Go to Cataloging 7. Click the arrow next to New record and choose Fast Add Framework 8. Scroll down to 245 --> h, n, and p are visible but should be collapsed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 17:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 15:58:26 +0000 Subject: [Koha-bugs] [Bug 34991] Collapsed 245 subfields still show by default in Fast Add Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34991 --- Comment #1 from Caroline Cyr La Rose --- I've had this problem as far as 22.05. I don't know for versions before that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:03:11 +0000 Subject: [Koha-bugs] [Bug 34992] New: Add language setting to vendors, so we can send translated order/claim emails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34992 Bug ID: 34992 Summary: Add language setting to vendors, so we can send translated order/claim emails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Libraries often want notices and English and the local language as they are ordering both from local and international booksellers. It would be nice if we were able to send the acq notices in different languages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:11:38 +0000 Subject: [Koha-bugs] [Bug 23134] Having an "internal notes" field which would be available throughout the suggestion process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31374 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:11:38 +0000 Subject: [Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton at educampus.ie --- Comment #25 from Katrin Fischer --- *** Bug 23134 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:18:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:18:25 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > Hey, what do you think of this change? I like it. That's how I thought we could use it. > Note that I don't think we should add this new > concept/module/abstraction/complexity if there is no plan to move it further > (i.e. a goal/roadmap we share to replace what is C4::Koha and Koha::Biblio > that is parsing MARC::Record to get data). It is done, I don't think having 'MARC' in the package name hurts, as of UNIMARC and MARC21, the different packages make sense, though. > Also note that bug 23235 become even more relevant now... Yeah, probably. Setting to NSO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:26:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:26:53 +0000 Subject: [Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:26:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:26:55 +0000 Subject: [Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 --- Comment #1 from Owen Leonard --- Created attachment 156573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156573&action=edit Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the budget and fund administration templates, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Other changes: Bootstrap tooltips have been enabled in a few places where the markup showed intent for the tooltips to be active but where the JS was not being initiated. Some translation imrovements have been added where budget planning strings could be improved with context: 'by months' -> '[% tp("Budget planning", "by months") | html %]' To test, apply the patch and go to Administration -> Budgets. Test each of these cases: - Budgets list - New budget - Edit budget - Duplicate budget - Close budget - Close a budget with and without unreceived orders. - Delete budget - Test the delete button on a budget which has funds attached to confirm that the menu item is disabled and a tooltip shows with an explanation. - Delete a budget which has no funds attached. - Add fund - Test the add fund button on a budget which is locked. The menu item should be disabled and it should show a tooltip, "Budget is locked." - Test the add fund page for a budget which is not locked. - Click the name of a budget with funds attached to see the funds view - In this view, if the budget is locked, the "New" toolbar menu should have a disabled "New fund" item with a Bootstrap tooltip. - While viewing the funds on a budget, test the "Planning" button to confirm that the view of each planning type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:27:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:27:54 +0000 Subject: [Koha-bugs] [Bug 17868] Improve display of authors in cart and list emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I think this is fixed with: Bug 3150 - Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:35:29 +0000 Subject: [Koha-bugs] [Bug 31003] WhatsApp notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31003 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:35:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:35:37 +0000 Subject: [Koha-bugs] [Bug 31002] Add ability to send notices over instant messaging services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31002 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:41:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:41:23 +0000 Subject: [Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 --- Comment #5 from jesus at medios.es --- No back browser button involved in my proof of concept. Our programmer suggests it is a race condition on two different javascript codes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 18:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 16:54:18 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:09:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:09:13 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:09:16 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #9 from David Nind --- Created attachment 156574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156574&action=edit Bug 34558: Update custom.sql for it-IT webinstaller It is an update of this file, here there are the specific customization for italian users. There are simple changes on defaults values. To test it: 1 - Start a web installation with italian language. 2 - Select Marc21 as biblio format 3 - Select all optional .sql files 4 - Conclude the installation. 5 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Sig.na' 6 - Apply the patch. 7 - Drop and recreate the mysql db 8 - Redone the installation with italian language. 9 - Use the same options written above. 10 - Conclude the installation. 11 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Dott.|Dott.ssa' 12 - Refactor is OK Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:10:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:10:24 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156558|0 |1 is obsolete| | --- Comment #10 from David Nind --- Comment on attachment 156558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156558 patch for custom.sql Mark the original patch as obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:15:40 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #11 from David Nind --- Updated testing notes (using koha-testing-docker (KTD)): 1. Install the it-IT language: 1.1 cd misc/translator 1.2 ./translate update it-IT 1.3 ./translate install it-IT 2. Initial run through the web installer: 2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1 2.2 Drop the koha_kohadev database: drop database koha_kohadev; 2.3 Create the database: create database koha_kohadev; 2.4 Add privileges (for a real installation, this would be limited): grant all on koha_kohadev.* to koha_kohadev; 2.5 Restart everything (there may be some errors listed): flush_memcached and then restart_all 2.6 Access the web installer: go to 127.0.0.1:8081 2.7 Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 2.8 Continue through the installation process 3. As per the test plan (step 5), then apply the patch and repeat 2. 4. Note that the SQL statement for step 5 should be 'SELECT' not 'SELET' in English: SELECT value FROM systempreferences where variable = 'BorrowersTitles' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:22:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:22:50 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:22:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:22:53 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156565|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 156575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156575&action=edit Bug 34828: Introduce Koha::MetadataExtractor and ->get_normalized_upc This patch introduces a new pattern for the different ->get_ methods we've been adding. The aim is that code will look more like: my $metadata_extractor = Koha::MetadataExtractor->new; while ( my $biblio = $biblios->next ) { my $record = $biblio->record; my $schema = $biblio->record_schema; $data->{$biblio->id}->{normalized_upc} = $metadata_extractor->get_normalized_upc( { record => $record, schema => $schema } ); $data->{$biblio->id}->{normalized_ean} = $metadata_extractor->get_normalized_ean( { record => $record, schema => $schema } ); } The key is that we are actually reusing the MARC::Record, and code for each schema is organized cleanly so easier to maintain. For the class names, I chose to add the 'MARC' name in the path, so we don't need to refactor anything if we want to add support for another serialization formats. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:22:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:22:56 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156566|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 156576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156576&action=edit Bug 34828: Move to Koha::Biblio::Metadata::Extractor We are not directly linked with the other Koha::Metadata* packages. Better to isolate this under Koha::Biblio::Metadata (at least for now). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:22:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:22:59 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156567|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 156577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156577&action=edit Bug 34828: Add Koha::Biblio::Metadata::Extractor::MARC and inherit from it The new usage is now: 1. With a Koha::Biblio object my $extractor = Koha::Biblio::Metadata::Extractor->new({biblio => $biblio}); $extractor->get_normalized_upc; or 2. With a MARC::Record my $extractor = Koha::Biblio::Metadata::Extractor->new({metadata=> $biblio->metadata->record}); $extractor->get_normalized_upc; Note that there are "Inconsistent hierarchy during C3 merge of class" warnings raised by the QA script. We could remove them by replacing the 'use' by 'require' in Koha::Biblio::Metadata::Extractor::MARC (in ->new) but that's suboptimal. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:23:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:23:02 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156568|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 156578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156578&action=edit Bug 34828: Make normalized_oclc uses Koha::Biblio::Metadata::Extractor Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:25:00 +0000 Subject: [Koha-bugs] [Bug 34828] Add Koha::MetadataExtractor class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #20 from David Nind --- I've signed off, as the test plan works. However, I don't really understand the changes as I'm not a developer - please feel free to change it back to needs sign off if that is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:51:33 +0000 Subject: [Koha-bugs] [Bug 34993] New: Framework don't load in existing records or duplicate as new Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Bug ID: 34993 Summary: Framework don't load in existing records or duplicate as new Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lauren_denny at sil.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The system preference, ApplyFrameworkDefaults no longer works as expected on versions of 22.11 after 22.11.09. When 'Select All' is checked the ability to load the framework in 'existing records' and 'editing as new (duplicate)' no longer loads the text from the framework into the record. Koha still works as expected with creating new records and importing with Z39.50. The system preference connected with Frameworks still works on 22.05.15 but doesn't work on 22.11.09 or 22.11.10. Something happened in between 22.11.07 or 22.11.08 and 22.11.09. This issue was connected to Bug 30250 - Configure when to apply framework defaults when cataloguing which provided this feature in earlier updates of 22.05 & 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:55:40 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 --- Comment #52 from Lauren Denny --- I created a new bug, Bug 34993 - Framework don't load in existing records or duplicate as new, and linked it to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:58:05 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 19:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 17:58:08 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156564|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 156579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156579&action=edit Bug 34990: Add persistent header when sending msg to RabbitMQ Test plan: NOTE: It is very hard to add a Koha unit test for adding this single header when communicating to RabbitMQ via Stomp plugin. When we would mock the send, we are only testing if perl can pass a hashref to a subroutine ;) Do NOT yet apply this patch. Make sure that RabbitMQ runs. Stop the koha-worker for long_tasks: koha-worker --stop --queue long_tasks myclone Stage a MARC file. Check queues with rabbitmqctl list_queues. Look for: koha_myclone-long_tasks 1 (at least 1) Stop rabbitmq (something like /etc/init.d/rabbitmq-server stop) Start rabbitmq (/etc/init.d/rabbitmq-server start) Check queue again with with rabbitmqctl list_queues. Look for: koha_myclone-long_tasks 0 Your messages have been gone. Now apply this patch. Reiterate the former steps. But note that you will still see a non-empty queue in the last step: koha_myclone-long_tasks 1 (at least 1) Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:01:51 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I've signed off, as the test plan works. However, what should happen to the jobs queued (shown under Administration > Jobs)? For me, they are staying there with a status of 'New' and progress 'null/0'. The action options I have are view and cancel. Testing notes (using KTD): 1. Add sudo in front of the commands in the test plan. For myclone, use kohadev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:06:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:06:56 +0000 Subject: [Koha-bugs] [Bug 34443] Spelling: Patron search pop-up Sort1: should be Sort 1: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34443 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:08:13 +0000 Subject: [Koha-bugs] [Bug 34716] Typo in tools/stockrotation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34716 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:08:58 +0000 Subject: [Koha-bugs] [Bug 34794] Typo in recalls_to_pull.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34794 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |String patch Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:10:00 +0000 Subject: [Koha-bugs] [Bug 34781] Add a span tag around GDPR text in opac-memberentry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34781 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:16:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:16:44 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #69 from Fridolin Somers --- Does not apply easy on 23.05.x Looks like some changes come from Bug 27378 Since it impacts preferences it may be risky for stable branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:18:37 +0000 Subject: [Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:18:39 +0000 Subject: [Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 --- Comment #1 from Owen Leonard --- Created attachment 156580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156580&action=edit Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the item search fields administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch makes some changes to the way new item search fields are added in order to keep the display consistent with other similar interfaces: The "add" form is no longer shown dynamically from the page listing item search fields. Clicking the "New search field" toolbar button will now take you to the same template used for editing existing search fields. This allows us to put the correct context into page title, breadcrumbs, and headings. To test, apply the patch and go to Administration -> Item search fields. Test the process of adding a new search field and editing an existing search field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:19:29 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When there is no valid release notes| |patron category defined in | |system preference | |PatronSelfRegistrationDefau | |ltCategory the full feature | |is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:20:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:20:33 +0000 Subject: [Koha-bugs] [Bug 34804] Translation fixes - ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34804 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:25:00 +0000 Subject: [Koha-bugs] [Bug 34885] Improve confusing pref description for OPACHoldsIfAvailableAtPickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34885 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:34:06 +0000 Subject: [Koha-bugs] [Bug 34446] Typo: Can be guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:37:48 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Enica Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:38:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:38:22 +0000 Subject: [Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #20 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:41:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:41:54 +0000 Subject: [Koha-bugs] [Bug 34836] OPAC ISBD or MARC view blows up with error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:42:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:42:37 +0000 Subject: [Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- Depends on Bug 32911 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:45:30 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 --- Comment #11 from Fridolin Somers --- Bug 30825 is not in 23.05.x I see old patches could be used, please attach a patch with [23.05.x] for stable backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 20:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 18:49:21 +0000 Subject: [Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:03:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:03:48 +0000 Subject: [Koha-bugs] [Bug 14414] Add field for processing fee for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14414 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:17:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:17:39 +0000 Subject: [Koha-bugs] [Bug 34934] Remove the use of event attributes from OPAC lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:18:40 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:19:15 +0000 Subject: [Koha-bugs] [Bug 34994] New: Consider translations in updatedatabase Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34994 Bug ID: 34994 Summary: Consider translations in updatedatabase Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr I wanted to open the discussion on this subject. Currently, when we insert things in the database using db_revs or updatedatabase, the strings are inserted in English. For a lot of things, like database structure changes and that type of stuff, it's fine. But for new letters, authorized values or additional content, it inserts in English no matter what the language of the installation is. That means that when we update Koha, we have to go in and translate all of those new things in the interface. We already translate the strings for new Koha installations through the translation of yaml files. I was wondering if it was somehow possible to use the yaml files and their translations to insert the new values? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:19:27 +0000 Subject: [Koha-bugs] [Bug 34930] Fix timezone problem in Koha/Object.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34930 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:21:33 +0000 Subject: [Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:23:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:23:10 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- When I enable ERM and Add a new data provider manually I get a type error: this.$refs.table.dt is not a function. For me this comes from KohaTable.vue on line 150: let dt = this.$refs.table.dt() I have tried restarting everything and rebuilding the js with yarn js:build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:24:31 +0000 Subject: [Koha-bugs] [Bug 34994] Consider translations in updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34994 --- Comment #1 from Caroline Cyr La Rose --- We have 60+ Koha installations, that means a lot of translating work when we update our clients. (Or a lot of unhappy people when they find a letter or authorized value in English in the cases where we didn't spot all of them.) For 23.05, I went through all the dbrev files and made an SQL file that goes in and changes the authorized values, letters and additional content that were added with the translated strings. (In addition to having already translated the strings in Pootle.) I'm probably not the only one in this situation and I'm sure there is a more elegant way of managing this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:24:50 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #77 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:26:06 +0000 Subject: [Koha-bugs] [Bug 34942] Typo: brower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Patch complexity|--- |String patch --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:27:08 +0000 Subject: [Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:27:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:27:28 +0000 Subject: [Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:28:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:28:55 +0000 Subject: [Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:31:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:31:08 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34038 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 [Bug 34038] Fix incorrect use of __() in .tt and .inc files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:31:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:31:08 +0000 Subject: [Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:33:20 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #8 from Jessie Zairo --- Created attachment 156581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156581&action=edit queued-report-fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:33:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:33:49 +0000 Subject: [Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Patch complexity|--- |Trivial patch Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 Note that in 23.05.x js-biblio-format.inc does not exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:33:58 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #9 from Jessie Zairo --- We successfully created a new data provider via SUSHI. We got a successful test - Harvester connection was successful for usage data provider. When we run the job for report type TR_J1, we get a message that the report goes to queue, but fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:35:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:35:15 +0000 Subject: [Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:36:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:36:04 +0000 Subject: [Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34918 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:36:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:36:04 +0000 Subject: [Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34932 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:36:37 +0000 Subject: [Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:42:14 +0000 Subject: [Koha-bugs] [Bug 34911] Test suite no longer run test critic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 Good catch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:43:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:43:30 +0000 Subject: [Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Small patch Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #28 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:43:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:43:31 +0000 Subject: [Koha-bugs] [Bug 34995] New: Add a test parameter to updatedatabase.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34995 Bug ID: 34995 Summary: Add a test parameter to updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In theory we could run all of updatedatabase.pl in a transaction to test it for error conditions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:43:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:43:34 +0000 Subject: [Koha-bugs] [Bug 34995] Add a test parameter to updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34995 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:43:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:43:55 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151484|0 |1 is obsolete| | Attachment #151485|0 |1 is obsolete| | --- Comment #13 from Michael Hafen --- Created attachment 156582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156582&action=edit Bug 28657: expand branches.branchip to allow for multiple ip ranges [squashed follow-up for QA 2023-10-05] Bug 28657: expand branches.branchip to allow for multiple ip ranges. change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. Change C4/Auth.pm from a regexp to using in_iprange() to check client address against branchip. (in_iprange() shouldn't work with '*' in branchip.) Change in_iprange() to default to false (which is what the POD says it should do). Change note in admin/branches.tt under branchip field to reflect changes to branchip handling. Bug 28657: (QA follow-up) Return 1 if no range, improve unit tests Bug 28657: (Follow-up for QA) Tidy the code and make it more consident remove branches.tt branchip input maxlength attribute. Have the db_rev match the kohastructure.sql for column collation and comment. Use new style db_rev skeleton. Fix comment C4::Auth. Have Koha::Library->store() watch for and remove '*' from branchip. Add a couple more test for full coverage. Test plan: 1. Turn on AutoLocation system preference 2. Change a branches branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The location check will fail. 4. Apply patch. Restart plack if necessary. 5. Try logging in again. The location check will succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:44:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:44:08 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:45:25 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:45:25 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 [Bug 34689] Add and duplicate item - Error 500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:46:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:46:13 +0000 Subject: [Koha-bugs] [Bug 34689] Add and duplicate item - Error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Patch complexity|--- |Trivial patch Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #13 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:46:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:46:32 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #10 from Jonathan Field --- (In reply to Jessie Zairo from comment #9) > We successfully created a new data provider via SUSHI. We got a successful > test - Harvester connection was successful for usage data provider. When we > run the job for report type TR_J1, we get a message that the report goes to > queue, but fails. Hi Jessie, is this on our sandbox? If so, we found a problem earlier today with the background jobs which we are looking into. I’ll let you know when resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:47:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:47:46 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #9 from Michael Hafen --- Setting back to Signed Off. Dependency is back to Needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:48:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:48:35 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29346 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:48:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:48:35 +0000 Subject: [Koha-bugs] [Bug 29346] Real-time holds queue update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:49:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:49:20 +0000 Subject: [Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:50:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:50:30 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:50:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:50:32 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #7 from David Nind --- Created attachment 156583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156583&action=edit T2211: OAI GetRecord bad encoding for Unimarc For some Unimarc biblio records, the OAI Server returns a bad XML document, ie a document with extended characters, such as accents, not encoded in UTF8. It seems to come from somewhere in MARC::Record library trying to deduce biblio record endoding from some fields. It may work for MARC21 records. It doesn't for Unimarc records. So it's necessary to send to the method transforming record into XML the marcflavour. This way there is no encoding guessing from Unimarc biblio records content. https://bugs.koha-community.org/show_bug.cgi?id=34467 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:53:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:53:34 +0000 Subject: [Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:54:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:54:13 +0000 Subject: [Koha-bugs] [Bug 34916] ArticleRequests.t may fail on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34916 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:55:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:55:35 +0000 Subject: [Koha-bugs] [Bug 34912] Account(s).t tests fail in UTC+1 and higher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34912 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:56:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:56:19 +0000 Subject: [Koha-bugs] [Bug 34944] Remove the use of event attributes from OPAC full serial issue page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:56:53 +0000 Subject: [Koha-bugs] [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 21:59:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 19:59:56 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #8 from David Nind --- Thanks Frédéric! The information on how to test helped, and I have now signed it off. David Testing notes (using KTD): 1. Edited .env and change KOHA_MARC_FLAVOUR=unimarc 2. Enabled the OAI-PMH system preference. 3. Modified record 1234: - on leader position 9, enter a blank - on 200$a, add a è - Here is what is in the leader: 01552nam 2200829 4500 - Had to add all the required subfields - Edited the item for the record so that the item has the correct entries from item dropdown list options and the item type 4. Ran flush_memcached and restart_all and use a refreshed browser/ 5. Used this URL: http://127.0.0.1:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:1234 6. Note that the 200$a does not have an è. 7. Applied the patch, run flush_memcached and restart_all 8. The OAI response now includes an è in the 200$a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:00:29 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:02:42 +0000 Subject: [Koha-bugs] [Bug 34994] Consider translations in updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34994 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:05:53 +0000 Subject: [Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Bug 32910 not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:07:48 +0000 Subject: [Koha-bugs] [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:08:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:08:31 +0000 Subject: [Koha-bugs] [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:10:01 +0000 Subject: [Koha-bugs] [Bug 34825] Move Letters.t to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34825 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:12:03 +0000 Subject: [Koha-bugs] [Bug 34887] Merge Patron.t into t/db/Koha/Patron.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34887 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:13:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:13:07 +0000 Subject: [Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:14:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:14:10 +0000 Subject: [Koha-bugs] [Bug 34865] Syspref OPACURLOpenInNewWindow not working for Library URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 23.05.x In order to avoid behavior change in a stable version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:15:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:15:16 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:19:15 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Makes more sens, I choose to backport Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:21:18 +0000 Subject: [Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:22:23 +0000 Subject: [Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:29:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:29:14 +0000 Subject: [Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:39:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:39:10 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- Arg we try to avoid double quotes in translated strings, because of JavaScript. This string may not end in a JavaScript code but better be safe. Can it be " or single quotes ? I see we use " is some places : https://git.koha-community.org/Koha-community/Koha/src/commit/af093305b8c936f20c49fa707d5bc58fc9059ba8/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc#L23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:45:17 +0000 Subject: [Koha-bugs] [Bug 34982] Administration currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|admin currencies table not |Administration currencies |showing pagination |table not showing | |pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:49:02 +0000 Subject: [Koha-bugs] [Bug 34982] Administration currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:49:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:49:05 +0000 Subject: [Koha-bugs] [Bug 34982] Administration currencies table not showing pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156563|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156584&action=edit Bug 34982: Add pagination to the currencies table Otherwise we only display the first 20. Test plan: Create more than 20 currencies and confirm that you can know filter the table and see all the currencies. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:49:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:49:49 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:51:15 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:51:17 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156511|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 156585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156585&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:51:20 +0000 Subject: [Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156521|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156586&action=edit Bug 34393: (follow-up) QA fixes and further refinement This patch addresses issues discovered during testing and fixes a couple of issues which were missed. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:51:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:51:39 +0000 Subject: [Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:51:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:51:57 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:54:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:54:21 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:54:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:54:23 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156574|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 156587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156587&action=edit Bug 34558: Update custom.sql for it-IT webinstaller It is an update of this file, here there are the specific customization for italian users. There are simple changes on defaults values. To test it: 1 - Start a web installation with italian language. 2 - Select Marc21 as biblio format 3 - Select all optional .sql files 4 - Conclude the installation. 5 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Sig.na' 6 - Apply the patch. 7 - Drop and recreate the mysql db 8 - Redone the installation with italian language. 9 - Use the same options written above. 10 - Conclude the installation. 11 - Go to MySQL command line and do: SELECT value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Dott.|Dott.ssa' 12 - Refactor is OK Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 22:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 20:55:51 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 23:00:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 21:00:34 +0000 Subject: [Koha-bugs] [Bug 34994] Consider translations in updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34994 --- Comment #2 from Katrin Fischer --- > For 23.05, I went through all the dbrev files and made an SQL file that goes > in and changes the authorized values, letters and additional content that > were added with the translated strings. (In addition to having already > translated the strings in Pootle.) We have a very similar approach for updates. It would be nice if the changes could be included somehow or even part of the translation system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 23:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 21:02:10 +0000 Subject: [Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #19 from Katrin Fischer --- (In reply to Fridolin Somers from comment #18) > Arg we try to avoid double quotes in translated strings, because of > JavaScript. > This string may not end in a JavaScript code but better be safe. > > Can it be " or single quotes ? > > I see we use " is some places : > https://git.koha-community.org/Koha-community/Koha/src/commit/ > af093305b8c936f20c49fa707d5bc58fc9059ba8/koha-tmpl/intranet-tmpl/prog/en/ > includes/background_jobs/stage_marc_for_import.inc#L23 I actually checked, but our rule only applies to JS and this is not Javascript. It should not be able to break it in translation, no matter what people use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 23:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 21:04:18 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated IP ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expand branches.branchip to |Expand branches.branchip to |allow for multiple space |allow for multiple space |separated ip ranges |separated IP ranges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 23:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 21:39:15 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 5 23:39:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 21:39:18 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #9 from Katrin Fischer --- Created attachment 156588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156588&action=edit Bug 34467: OAI GetRecord bad encoding for Unimarc For some Unimarc biblio records, the OAI Server returns a bad XML document, ie a document with extended characters, such as accents, not encoded in UTF8. It seems to come from somewhere in MARC::Record library trying to deduce biblio record endoding from some fields. It may work for MARC21 records. It doesn't for Unimarc records. So it's necessary to send to the method transforming record into XML the marcflavour. This way there is no encoding guessing from Unimarc biblio records content. https://bugs.koha-community.org/show_bug.cgi?id=34467 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 00:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Oct 2023 22:21:21 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli at gmail.com --- Comment #16 from Zeno Tajoli --- Hi Jonathan, I'm trying to develop this patch so I ask same explanation about your requests: 1)'first move the code to a module'. In this patch the new verb 'merge' is inside an existing module, 'Koha/REST/V1/Biblios.pm' and it is also a Mojo controller. So the code is in the correct place. 2)'provide test' OK, to do. 3)'then call that method from merge.pl and your Mojo controller' Yes, I need to change the merge.pl and use the REST API instead of the present code. Is it a correct work plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:25:51 +0000 Subject: [Koha-bugs] [Bug 32676] EDI message status uses varying case, breaking EDI status block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32676 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:29:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:29:19 +0000 Subject: [Koha-bugs] [Bug 34891] View restrictions button (patrons page) doesn't link to tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:30:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:30:51 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:31:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:31:22 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:32:17 +0000 Subject: [Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #25 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:33:23 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:34:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:34:25 +0000 Subject: [Koha-bugs] [Bug 34961] RSS feed link in OPAC is missing sort parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34961 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:36:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:36:19 +0000 Subject: [Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:36:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:36:45 +0000 Subject: [Koha-bugs] [Bug 33958] Add Koha::Biblio->normalized_oclc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33958 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:39:42 +0000 Subject: [Koha-bugs] [Bug 33075] Add ability to mark an item as floating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33075 --- Comment #8 from Fridolin Somers --- Is this somehow linked to Bug 9525 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:40:15 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #79 from Fridolin Somers --- New feature not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:46:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:46:31 +0000 Subject: [Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- This needs a check for permission 'CAN_user_reserveforothers_place_holds' right ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:46:38 +0000 Subject: [Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:50:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:50:52 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Patch complexity|--- |Trivial patch --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:52:57 +0000 Subject: [Koha-bugs] [Bug 34859] reports-home.pl has unnecessary syspref template parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34859 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:54:16 +0000 Subject: [Koha-bugs] [Bug 34923] OPAC hold page flatpickr does not allow direct input of dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34923 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:57:07 +0000 Subject: [Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 02:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 00:58:57 +0000 Subject: [Koha-bugs] [Bug 34153] Add ability to allow items with additional materials notes to be checked out via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- Great, but more a enhancement. Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 03:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 01:00:38 +0000 Subject: [Koha-bugs] [Bug 34921] Tabs on Additional Content page need space above In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34921 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 04:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 02:25:25 +0000 Subject: [Koha-bugs] [Bug 34996] New: In Koha Patron List, add columns "sort1" and "sort2" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34996 Bug ID: 34996 Summary: In Koha Patron List, add columns "sort1" and "sort2" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: eugenegf at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently available columns for patron list are: checkbox, card, firstname, surname, address, category, library, expires_on and circ_notes. This enhancement request will hopefully add sort1 and sort2 in the patron list column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:26:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:26:42 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 --- Comment #4 from Marcel de Rooy --- (In reply to David Nind from comment #3) > I've signed off, as the test plan works. > Thanks > However, what should happen to the jobs queued (shown under Administration > > Jobs)? For me, they are staying there with a status of 'New' and progress > 'null/0'. The action options I have are view and cancel. Thats another problem, yes. There is only a workaround for that: stop rabbitmq, restart worker. The worker will now go in 'database mode' and get the jobs that are still new in the db. Since they might be quite old, this is very questionable behavior btw. You mention null/0. I saw that too. That is another small bug. Will open two new reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:28:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:28:03 +0000 Subject: [Koha-bugs] [Bug 34997] New: Background jobs: Orphaned jobs should not be run after too much time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34997 Bug ID: 34997 Summary: Background jobs: Orphaned jobs should not be run after too much time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 34990. See comment4. There may be jobs not in MQ but in DB. If worker starts in 'db mode' they will now be processed. This should not be done after too much time. How long is too much time? Or should we leave it to the user to decide somehow? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:29:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:29:39 +0000 Subject: [Koha-bugs] [Bug 34998] New: Background jobs: Status shows null/0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34998 Bug ID: 34998 Summary: Background jobs: Status shows null/0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org This is not a status; this is a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:29:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:29:53 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 --- Comment #5 from David Nind --- Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:30:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:30:49 +0000 Subject: [Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34997, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:30:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:30:49 +0000 Subject: [Koha-bugs] [Bug 34997] Background jobs: Orphaned jobs should not be run after too much time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34997 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34990 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:30:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:30:49 +0000 Subject: [Koha-bugs] [Bug 34998] Background jobs: Status shows null/0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34998 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:42:43 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #30 from Marcel de Rooy --- The approach here feels a bit like a workaround. member-password: flagsrequired => { borrowers => 'edit_borrowers' }, Shouldnt we lower that permission? And then there is moremember. It also needs edit_borrowers. Which is a bit weird for your own account. Should we rework the checks there a bit to include seeing your account (including password change)? If we do so, there is no need to add another link (we already have my account). And no pref is needed as well. Currently, you can set a user to Staff access. He has the account link. But if he clicks, he gets No permission. Not user friendly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:48:15 +0000 Subject: [Koha-bugs] [Bug 34999] New: REST API: Typo error instead of message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34999 Bug ID: 34999 Summary: REST API: Typo error instead of message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:48:38 +0000 Subject: [Koha-bugs] [Bug 35000] New: Work in progress Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Bug ID: 35000 Summary: Work in progress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:49:02 +0000 Subject: [Koha-bugs] [Bug 35000] Work in progress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:49:09 +0000 Subject: [Koha-bugs] [Bug 35000] Work in progress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:49:26 +0000 Subject: [Koha-bugs] [Bug 34999] REST API: Typo error instead of message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34999 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:49:33 +0000 Subject: [Koha-bugs] [Bug 34999] REST API: Typo error instead of message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34999 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:53:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:53:20 +0000 Subject: [Koha-bugs] [Bug 32890] Add DataTables to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:56:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:56:45 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:56:48 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #6 from Marcel de Rooy --- Created attachment 156589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156589&action=edit Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:57:13 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Marcel de Rooy --- Trivial last patch in a series: Self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:57:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:57:25 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 08:59:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 06:59:14 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 --- Comment #12 from Julian Maurice --- (In reply to Fridolin Somers from comment #11) > Bug 30825 is not in 23.05.x > I see old patches could be used, please attach a patch with [23.05.x] for > stable backport You can use the original (obsoleted) patch. It does not depend on bug 30825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:03:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:03:12 +0000 Subject: [Koha-bugs] [Bug 33184] Warnings when running holds queue builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 --- Comment #3 from Magnus Enger --- (In reply to David Nind from comment #2) > Is there a script or some way to automatically add a large number of holds, > without having to manually add them? > > The build_holds_queue.pl runs too quickly with only a small number of holds > manually entered. Maybe you could add "sleep 5;" (5 is just an example, could be higher to slow things down even more) somewhere? build_holds_queue.pl just calls CreateQueue(), but I'm guessing there is a loop over the holds in there somwhere, where a little bit of sleep could slow things down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:06:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:06:52 +0000 Subject: [Koha-bugs] [Bug 8577] build_holds_queue.pl needs command-line options for help, verbosity, and summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8577 --- Comment #2 from Magnus Enger --- The script also has this: my $rthq = C4::Context->preference('RealTimeHoldsQueue'); if ( $rthq && !$force ) { say "RealTimeHoldsQueue system preference is enabled, holds queue not built."; say "Use --force to force building the holds queue."; exit(1); } Which means that if a site turns on RealTimeHoldsQueue, the script starts generating "unnecessary" output. Well, if you run the script interactively you might want this output, but not if you run it from a cronjob (which is set up hourly automatically by the Debian packages). So maybe a --quiet option to make the cronjob run without this output? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:10:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:10:20 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:10:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:10:22 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156526|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 156590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156590&action=edit Bug 14092: Add 'any status' option to acq order search form Sometimes it's really helpful to see all orders for a basket, a vendor or a standing order, including the cancelled ones. Currently this is not possible, as we have search options for every single status and one for "any except cancelled", but no "Any status" option. This patch adds the "Any status" option. The sometimes appearing empty entry is updated to "Any status except cancelled" as this is what it does. Testing data: * Requires multiple order lines with different order status * Must include at least one order line with status 'cancelled' To test: * Go to acquisitions * Open the advanced search page from the top search options: Order search > config icon > Advanced search link * Verify the status pull down looks as described above * Apply patch * Verify there is now an "Any status" option in the pull down * Try searches for different status, including "Any status" * Verify the results are as expected * Create a new basket * Create an order line by 'From an existing order (copy)' * Verify the search form there also works as expected Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:10:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:10:25 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156527|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 156591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156591&action=edit Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:16:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:16:58 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #102 from Marcel de Rooy --- Still applies, looking here (no promise of a full QA yet given size) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:17:55 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #103 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #47) > Amaury (from BULAC) presented this development during a French conference > (Symposium Kohala), here are the slides: > https://drive.google.com/file/d/12IclGOcVrwivCNIg0KW1mBmaiukgpdp7/ > view?usp=sharing > > It contains some screenshots. French text :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 09:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 07:48:36 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #46 from Jonathan Druart --- I personally would not backport it (or later). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 10:56:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 08:56:52 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #104 from Jonathan Druart --- Created attachment 156592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156592&action=edit Bug 30708: Pass csrf_token to the Vue app It's needed since bug 34369 to POST to the syspref route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 10:58:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 08:58:00 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #47 from Fridolin Somers --- Indeed, this is a very wide impact change, there is a risk of side-effects. 23.05.x is used in production now. We are close to the end of cycle so we may wait for 23.11 to come out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 10:58:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 08:58:56 +0000 Subject: [Koha-bugs] [Bug 33075] Add ability to mark an item as floating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33075 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9525 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 10:58:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 08:58:56 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33075 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:42:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:42:29 +0000 Subject: [Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153754|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 156593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156593&action=edit Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:42:32 +0000 Subject: [Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153755|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 156594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156594&action=edit Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:42:34 +0000 Subject: [Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 --- Comment #11 from Martin Renvoize --- Created attachment 156595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156595&action=edit Bug 34328: Make update idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:42:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:42:44 +0000 Subject: [Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:58:57 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #105 from Marcel de Rooy --- Seeing things like this in qa tools: DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 11:59:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 09:59:32 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #106 from Marcel de Rooy --- * Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/' seems invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:00:43 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #107 from Marcel de Rooy --- $c->validation errors too in qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:04:48 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #108 from Marcel de Rooy --- I do not object to signoff and pass qa but it is just a rough visual check. I understand that there was a lot of test feedback though. The module is more or less separated from core features, so it wont hurt even if we should call it experimental or so. I like to hear feedback for the DBIC stuff still. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:05:26 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:08:08 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #109 from Marcel de Rooy --- And a few (innocent) notes during the process: But keep in mind that a train can have items that have different processings (specific case, will see later). RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] ASK Shouldnt we have a few default NFL statuses added now ? POST /api/v1/preservation/waiting-list/items: unhandled exception (Koha::Exceptions::Preservation::MissingSettings)<> POST /intranet/svc/config/systempreferences Did not work at the start without warns or alerts.. Related to CSRF bug. Now solved, but error checking could be improved. Home page Kind of weird to land at an empty page constantly. user_train_item_id => $max + 1, Looking further, I wonder what is the exact use of this column? Cant really see when git grepping on it. If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. - value: "Paraguay", => Not very clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:35:36 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 [Bug 33245] Add $patron->is_active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:35:36 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:36:05 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #70 from Martin Renvoize --- Rebasing now bug 33245 is in. I think bug 33245 could be significantly simplified once this is in personally.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:45:52 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #110 from Jonathan Druart --- Created attachment 156596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156596&action=edit Bug 30708: Fix conflict with 34055 and 34219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:45:57 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #111 from Jonathan Druart --- Created attachment 156597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156597&action=edit Bug 30708: Remove c->validation in API controllers Fixed conflict with bug 33556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:29 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155534|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize --- Created attachment 156598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156598&action=edit Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:33 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155535|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize --- Created attachment 156599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156599&action=edit Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:38 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155536|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize --- Created attachment 156600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156600&action=edit Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:42 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155537|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize --- Created attachment 156601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156601&action=edit Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:46 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155538|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize --- Created attachment 156602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156602&action=edit Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:51 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155539|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 156603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156603&action=edit Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:55 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155540|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize --- Created attachment 156604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156604&action=edit Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:47:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:47:59 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #78 from Martin Renvoize --- Created attachment 156605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156605&action=edit Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:48:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:48:03 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #79 from Martin Renvoize --- Created attachment 156606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156606&action=edit Bug 15504: (follow-up) Add Triggers mock to unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:48:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:48:07 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #80 from Martin Renvoize --- Created attachment 156607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156607&action=edit Bug 15504: (follow-up) Tidy 'lastseen' section of unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:48:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:48:12 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #81 from Martin Renvoize --- Created attachment 156608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156608&action=edit Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:51:16 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:51:53 +0000 Subject: [Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #11 from Jonathan Field --- (In reply to Jessie Zairo from comment #9) > We successfully created a new data provider via SUSHI. We got a successful > test - Harvester connection was successful for usage data provider. When we > run the job for report type TR_J1, we get a message that the report goes to > queue, but fails. We've fixed our sandbox now, apologies for that, we were missing some of the very latest code which is there now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 12:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 10:58:17 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #112 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #105) > Seeing things like this in qa tools: > > DBIx::Class::Relationship::ManyToMany::many_to_many(): > *************************************************************************** > The many-to-many relationship 'bundle_items' is trying to create a utility > method > called set_bundle_items. > This will completely overwrite one such already existing method on class > Koha::Schema::Result::Item. "bundle_items", that's not related to this development. It happens between the "before" and "after" the patch, we reload the different module (and so the schema file), that's why you see the warnings. (In reply to Marcel de Rooy from comment #106) > * Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/' > seems invalid We could add the whole team, but I think is what they want here. (In reply to Marcel de Rooy from comment #107) > $c->validation errors too in qa tools Fixed. Also fixed another bug. (In reply to Marcel de Rooy from comment #109) > And a few (innocent) notes during the process: > > But keep in mind that a train can have items that have different processings > (specific case, will see later). Hum? > RewriteRule ^/cgi-bin/koha/preservation/.*$ > /cgi-bin/koha/preservation/home.pl [PT] Yes? > ASK Shouldnt we have a few default NFL statuses added now ? I don't think so. It really depends on how the library will use the module. We could however add sample data in misc4dev. > POST /api/v1/preservation/waiting-list/items: unhandled exception > (Koha::Exceptions::Preservation::MissingSettings)< settings is required: PreservationNotForLoanWaitingListIn>> > POST /intranet/svc/config/systempreferences > Did not work at the start without warns or alerts.. Related to CSRF bug. Now > solved, but error checking could be improved. I don't think so. Discussed already in PM: this was a programming error, and a programmer/reviewer must have the JS console opened (especially if something wrong happened). It's a whole global Koha question anyway, absolutely nothing directly related to this bug. > Home page > Kind of weird to land at an empty page constantly. Please see the kanban, still lot of things in mind. https://tree.taiga.io/project/joubu-koha-preservation-module/us/2 Note that we have the same for ERM. > user_train_item_id => $max + 1, > Looking further, I wonder what is the exact use of this column? Cant really > see when git grepping on it. For display/info purpose. We want the items inside a given train to be numbered. This is the "ID" column displayed on the item table of the "show train" view. > If a value is not in the AV list, or if it differs slightly, they would like > to force the modification of the value, without creating a new authorised > value. > - value: "Paraguay", > => Not very clear. (This is referring to bug 30708: Allow modifying attribute linked with AV to another value) Before this patch it was not possible de force the value of a dropdown list, you had to select a value from the AV list. With this patch it's possible to enter another value. AV list is only there as suggestions, but not to force a choice. Hence the rest of the commit message: """ Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:06:24 +0000 Subject: [Koha-bugs] [Bug 35001] New: Patron->is_active should respect TrackLastPatronActivityTriggers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 Bug ID: 35001 Summary: Patron->is_active should respect TrackLastPatronActivityTriggers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 15504 Bug 33245 beat bug 15504 into Koha.. unfortunately this leads to the new method contained a series of hard coded queries for what the author felt are 'activity'.. Bug 15504 puts this into the hands of the librarians by exposing a preference for listing various actions that should trigger the lastseen update. We should update the is_active method to reduce the hard coded database calls used and utilise the activity stored in lastseen as defined by the Triggers preference. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:06:24 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:06:59 +0000 Subject: [Koha-bugs] [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl, | |matt.blenkinsop at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:07:16 +0000 Subject: [Koha-bugs] [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:10:05 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate Blocks|35001 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:10:05 +0000 Subject: [Koha-bugs] [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15504 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:10:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:10:27 +0000 Subject: [Koha-bugs] [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:10:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:10:27 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:10:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:10:28 +0000 Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 --- Comment #31 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #30) > The approach here feels a bit like a workaround. > > member-password: > flagsrequired => { borrowers => 'edit_borrowers' }, > Shouldnt we lower that permission? Maybe we could make it 'edit_borrowers or circulate_remaining_permissions' which are the 2 permissions most of the pages use that have the 'change password' button. We don't have a real 'view borrowers' right now. > And then there is moremember. It also needs edit_borrowers. Which is a bit > weird for your own account. > Should we rework the checks there a bit to include seeing your account > (including password change)? We could make it so you can see your own with catalogue maybe, but it feels like this would be for a separate bug. 2FA uses catalog - but how do you get there in the first place if you can't access pages that have the button? > If we do so, there is no need to add another link (we already have my > account). > And no pref is needed as well. I think allowing a user to change their own password could be done without a preference. Since we started using Koha this has only caused confusion. > Currently, you can set a user to Staff access. He has the account link. But > if he clicks, he gets No permission. Not user friendly. I think we should try not to get out of scope here and maybe move some weirdness to a separate bug. But adjusting the permission checks and maybe even forego the pref would make sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:28:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:28:54 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:35:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:35:54 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:35:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:35:57 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155040|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 156609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156609&action=edit Bug 34648: Update MARC21 frameworks to Update 31 (December 2020) This patch updates the default MARC21 framework to reflect the changes brought by Update 30 (Dec. 2020). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click "Actions" next to the default framework and choose "MARC structure" 4. Check for the changes detailed in the update https://www.loc.gov/marc/up31bibliographic/bdapndxg.html - Field 043 should now be repeatable - There should be a new field 335, named EXTENSION PLAN - This field should be repeatable - Subfields: - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 2 Source (NR) - 3 Materials specified (NR) - 6 Linkage (NR) - 8 Field link and sequence number (R) - a Extension plan term (NR) - b Extension plan code (NR) **Note that subfield 7 was added in a later update and is therefore not included in this patch - Field 345 should now be named MOVING IMAGE CHARACTERISTICS - There should be two new subfields - c Aspect ratio value (R) - d Aspect ratio designator (R) - There should be two new subfields in field 384 - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - The following subfields of field 856 should have an [OBSOLETE] mention and be hidden (shown in OPAC and intranet, but not editor) - b Access number [OBSOLETE] - h Processor of Request [OBSOLETE] - i Instruction [OBSOLETE] - j Bits per second [OBSOLETE] - k Password [OBSOLETE] - l Logon [OBSOLETE] - n Name of location of host [OBSOLETE] - r Settings [OBSOLETE] - t Terminal emulation [OBSOLETE] - There should be a new field 881, named MANIFESTATION STATEMENTS - This field should be repeatable - Subfields: - 3 Materials specified (NR) - 6 Linkage (NR) - 8 Field link and sequence number (R) - a Manifestation statement, high-level/general (R) - b Manifestation identifier statement (R) - c Manifestation title and responsibility statement (R) - d Manifestation edition statement (R) - e Manifestation production statement (R) - f Manifestation publication statement (R) - g Manifestation distribution statement (R) - h Manifestation manufacture statement (R) - i Manifestation copyright statement (R) - j Manifestation frequency statement (R) - k Manifestation designation of sequence statement (R) - l Manifestation series statement (R) - m Manifestation dissertation statement (R) - n Manifestation regional encoding statement (R) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:35:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:35:59 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155041|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 156610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156610&action=edit Bug 34648: (follow up) updated comment Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:36:02 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155042|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 156611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156611&action=edit Bug 34648: (fixup) Update MARC21 frameworks to Update 31 (December 2020) Added missing 881$a subfield. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:36:37 +0000 Subject: [Koha-bugs] [Bug 34648] Update MARC21 frameworks to Update 31 (December 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34648 --- Comment #14 from Katrin Fischer --- A lot of fiddly work - thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:37:45 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:39:39 +0000 Subject: [Koha-bugs] [Bug 34405] Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:39:41 +0000 Subject: [Koha-bugs] [Bug 34405] Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 --- Comment #1 from Owen Leonard --- Created attachment 156612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156612&action=edit Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers This patch fixes some inconsistencies in templates for EDI accounts and Library EANs, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> EDI accounts - New EDI account - Edit EDI account - Confirm deletion of EDI account - Administration -> Library EANs - New library EAN - Edit library EAN - Confirm deletion of EDI account - With an account for a specific library - With an account for any library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:42:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:42:20 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 --- Comment #9 from Katrin Fischer --- The test plan is a little wrong: 1. Apply patch and restart - you need to do a reset_all actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:21 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:24 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154989|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 156613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156613&action=edit Bug 34649: Update MARC21 default framework to Update 32 (June 2021) This patch updates the default MARC21 framework to reflect the changes brought by Update 32 (June 2021). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click Actions next to the default framework and choose MARC structure 4. Check for the changes detailed in the update https://www.loc.gov/marc/up32bibliographic/bdapndxg.html - There should be two new subfields in field 022 - 0 Authority record control number or standard number (NR) - 1 Real World Object URI (R) - There should be three new subfields in field 046 - 3 Materials specified (NR) - x Nonpublic note (R) (this one should be hidden from the OPAC) - z Public note (R) **Note that subfield 7 was added in a later update and is therefore not included in this patch - Subfield 082$2 should now be named Edition information - Subfield 083$2 should now be named Edition information - There should be a new field 334, named MODE OF ISSUANCE - This field should be repeatable - Subfields: - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 2 Source (NR) - 6 Linkage (NR) - 8 Field link and sequence number (R) - a Mode of issuance term (NR) - b Mode of issuance code (NR) - There should be one new subfield in field 344 - i Sound content (R) **Note that subfield j was added in a later update and is therefore not included in this patch - Field 348 should now be named NOTATED MUSIC CHARACTERISTICS - There should be two new subfields - c Form of musical notation term (R) - d Form of musical notation code (R) **Note that subfield 7 was added in a later update and is therefore not included in this patch - There should be a new field 353, named SUPPLEMENTARY CONTENT CHARACTERISTICS - This field should be repeatable - Subfields: - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 2 Source (NR) - 3 Materials specified (NR) - 6 Linkage (NR) - 8 Field link and sequence number (R) - a Supplementary content term (NR) - b Supplementary content code (NR) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:26 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154990|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 156614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156614&action=edit Bug 34649: Updated code list for 008 value builder for continuing resources This patch updates the code list for 008/21 for continuing resources in concordance with Update 32 to the MARC21 format. g - Magazine h - Blog j - Journal r - Repository s - Newsletter t - Directory Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:29 +0000 Subject: [Koha-bugs] [Bug 34649] Update MARC21 default framework to Update 32 (June 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154991|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 156615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156615&action=edit Bug 34649: (fixup) Update MARC21 default framework to Update 32 (June 2021) Fixes a small typo that prevented the yaml from loading correctly Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:54 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:45:57 +0000 Subject: [Koha-bugs] [Bug 34336] Test::DBIx::Class should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156589|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 156616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156616&action=edit Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:46:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:46:14 +0000 Subject: [Koha-bugs] [Bug 34658] Update MARC21 default framework to Update 33 (Nov. 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:54:40 +0000 Subject: [Koha-bugs] [Bug 34658] Update MARC21 default framework to Update 33 (Nov. 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:54:42 +0000 Subject: [Koha-bugs] [Bug 34658] Update MARC21 default framework to Update 33 (Nov. 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155166|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156617&action=edit Bug 34658: Update MARC21 default framework to Update 33 (Nov. 2021) iThis patch updates the default MARC21 framework to reflect the changes brought by Update 33 (November 2021). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click Actions next to the default framework and choose MARC structure 4. Check for the changes detailed in the update https://www.loc.gov/marc/up33bibliographic/bdapndxg.html - There should be a new subfield in field 340 - l Binding (R) - There should be a new subfield in field 344 - j Original capture and storage technique (R) - There should be two new subfields in field 490 - y Incorrect ISSN (R) - z Canceled ISSN (R) **Note that subfield 7 was added in a later update and is therefore not included in this patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:54:44 +0000 Subject: [Koha-bugs] [Bug 34658] Update MARC21 default framework to Update 33 (Nov. 2021) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155167|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 156618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156618&action=edit Bug 34658: Update to 007 value builder to reflect changes brought by Update 33 (Nov. 2021) This patch updates the terms used in the 007 value builder in concordance with the MARC21 format update 33. To test: 1. Apply patch and restart 2. Go to Cataloguing > New recordGo to Cataloguing > New record 3. Click the small tag editor icon next to 007 3. Change Material type to Sound recording --> Position 13 should now be named Original capture and storage technique 4. Open the 13 Original capture and storage technique drop-down menu --> The values should be renamed a - Acoustical capture, analog direct storage b - Electrical capture, analog direct storage d - Electrical capture, digital storage e - Electrical capture, analog electrical storage u - Unknown capture and storage z - Other **Unchanged | - No attempt to code **Unchanged Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 13:55:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 11:55:00 +0000 Subject: [Koha-bugs] [Bug 34659] Update MARC21 default framework to Update 34 (July 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:21:24 +0000 Subject: [Koha-bugs] [Bug 34406] Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:25:27 +0000 Subject: [Koha-bugs] [Bug 34727] Update Sample OAI conf file docs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34727 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #2 from Aude Charillon --- Hello, thanks again for submitting this request to the Manual! When creating a new bug for Documentation, there is a now a new status you can set the bug to straightaway: it's "Needs documenting". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:27:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:27:13 +0000 Subject: [Koha-bugs] [Bug 34727] Update Sample OAI conf file docs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34727 --- Comment #3 from Ere Maijala --- Hi, okay, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:29:50 +0000 Subject: [Koha-bugs] [Bug 34727] Update Sample OAI conf file docs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34727 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #4 from Aude Charillon --- Once the GitLab merge request has been accepted, you should switch the status from "Needs documenting" to "Resolved" on Bugzilla. This has two outcomes: 1) We know this bug doesn't need documenting anymore. 2) It makes your name appear on the Koha community dashboard in the Documentation leaderboards https://dashboard.koha-community.org/ There's a longer explanation of the Bugzilla / GitLab workflow on the Wiki: https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual I'll let you switch the status and enjoy seeing your name of the dashboard! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:37:58 +0000 Subject: [Koha-bugs] [Bug 34659] Update MARC21 default framework to Update 34 (July 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:38:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:38:01 +0000 Subject: [Koha-bugs] [Bug 34659] Update MARC21 default framework to Update 34 (July 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155168|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156619&action=edit Bug 34659: Update MARC21 default framework to Update 34 (July 2022) This patch updates the default MARC21 framework to reflect the changes brought by Update 34 (July 2022). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click Actions next to the default framework and choose MARC structure 4. Check for the changes detailed in the update https://www.loc.gov/marc/up34bibliographic/bdapndxg.html - There should be one new subfield in field 041 - 7 Data provenance (R) - There should be one new subfield in field 082 - 7 Data provenance (R) - There should be one new subfield in field 083 - 7 Data provenance (R) - There should be one new subfield in field 084 - 7 Data provenance (R) - There should be one new subfield in field 100 - 7 Data provenance (R) - There should be one new subfield in field 110 - 7 Data provenance (R) - There should be one new subfield in field 111 - 7 Data provenance (R) - There should be one new subfield in field 130 - 7 Data provenance (R) - There should be one new subfield in field 210 - 7 Data provenance (R) - There should be one new subfield in field 240 - 7 Data provenance (R) - There should be one new subfield in field 245 - 7 Data provenance (R) - There should be one new subfield in field 246 - 7 Data provenance (R) - There should be one new subfield in field 247 - 7 Data provenance (R) - There should be one new subfield in field 250 - 7 Data provenance (R) - There should be one new subfield in field 255 - 7 Data provenance (R) - There should be one new subfield in field 256 - 7 Data provenance (R) - There should be one new subfield in field 264 - 7 Data provenance (R) - There should be one new subfield in field 300 - 7 Data provenance (R) - There should be one new subfield in field 335 - 7 Data provenance (R) - There should be one new subfield in field 336 - 7 Data provenance (R) - There should be one new subfield in field 340 - q Reduction ratio designator (R) - Subfield f should now be named Reduction ratio value - There should be one new subfield in field 348 - 7 Data provenance (R) - There should be one new subfield in field 370 - 7 Data provenance (R) - There should be one new subfield in field 377 - 7 Data provenance (R) - There should be one new subfield in field 380 - 7 Data provenance (R) - There should be one new subfield in field 381 - 7 Data provenance (R) - There should be one new subfield in field 382 - 7 Data provenance (R) - There should be one new subfield in field 383 - 7 Data provenance (R) - There should be one new subfield in field 384 - 7 Data provenance (R) - There should be one new subfield in field 385 - 7 Data provenance (R) - There should be one new subfield in field 386 - 7 Data provenance (R) - There should be a new field 387, named REPRESENTATIVE EXPRESSION CHARACTERISTICS - This field should be repeatable - Subfields: - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 2 Source of term (NR) - 3 Materials specified (NR) - 6 Linkage (NR) - 7 Data provenance (R) - 8 Field link and sequence number (R) - a Aspect ratio of representative expression (R) - b Color content of representative expression (R) - c Content type of representative expression (R) - d Date of capture of representative expression (R) - e Date of representative expression (R) - f Duration of representative expression (R) - g Intended audience of representative expression (R) - h Language of representative expression (R) - i Place of capture of representative expression (R) - j Projection of cartographic content of representative expression (R) - k Scale of representative expression (R) - l Script of representative expression (R) - m Sound content of representative expression (R) - There should be one new subfield in field 388 - 7 Data provenance (R) - There should be one new subfield in field 490 - 7 Data provenance (R) - There should be one new subfield in field 500 - 7 Data provenance (R) - There should be one new subfield in field 501 - 7 Data provenance (R) - There should be one new subfield in field 502 - 7 Data provenance (R) - There should be one new subfield in field 505 - 7 Data provenance (R) - Field 507 should now be named SCALE NOTE FOR VISUAL MATERIALS - There should be one new subfield in field 508 - 7 Data provenance (R) - There should be one new subfield in field 510 - 7 Data provenance (R) - There should be one new subfield in field 515 - 7 Data provenance (R) - There should be one new subfield in field 518 - 7 Data provenance (R) - There should be one new subfield in field 520 - 7 Data provenance (R) - There should be one new subfield in field 533 - y Data provenance (R) - There should be one new subfield in field 546 - 7 Data provenance (R) - There should be one new subfield in field 550 - 7 Data provenance (R) - There should be one new subfield in field 555 - 7 Data provenance (R) - There should be one new subfield in field 583 - 7 Data provenance (R) - There should be one new subfield in field 600 - 7 Data provenance (R) - There should be one new subfield in field 610 - 7 Data provenance (R) - There should be one new subfield in field 611 - 7 Data provenance (R) - There should be one new subfield in field 630 - 7 Data provenance (R) - There should be one new subfield in field 648 - 7 Data provenance (R) - There should be one new subfield in field 650 - 7 Data provenance (R) - There should be one new subfield in field 651 - 7 Data provenance (R) - There should be one new subfield in field 653 - 7 Data provenance (R) - There should be one new subfield in field 655 - 7 Data provenance (R) - There should be one new subfield in field 700 - 7 Data provenance (R) - There should be one new subfield in field 710 - 7 Data provenance (R) - There should be one new subfield in field 711 - 7 Data provenance (R) - There should be one new subfield in field 751 - 7 Data provenance (R) - There should be one new subfield in field 760 - l Data provenance (R) - There should be one new subfield in field 762 - l Data provenance (R) - There should be one new subfield in field 765 - l Data provenance (R) - There should be one new subfield in field 767 - l Data provenance (R) - There should be one new subfield in field 770 - l Data provenance (R) - There should be one new subfield in field 772 - l Data provenance (R) - There should be one new subfield in field 773 - l Data provenance (R) - There should be one new subfield in field 774 - l Data provenance (R) - There should be one new subfield in field 775 - l Data provenance (R) - There should be one new subfield in field 776 - l Data provenance (R) - There should be one new subfield in field 777 - l Data provenance (R) - There should be one new subfield in field 780 - l Data provenance (R) - There should be one new subfield in field 785 - l Data provenance (R) - There should be one new subfield in field 786 - l Data provenance (R) - There should be one new subfield in field 787 - l Data provenance (R) - There should be a new field 788, named PARALLEL DESCRIPTION IN ANOTHER LANGUAGE OF CATALOGING - This field should be repeatable - Subfields: - 4 Relationship (R) - 5 Institution to which field applies (NR) - 6 Linkage (NR) - 8 Field link and sequence number (R) - a Main entry heading (NR) - b Edition (NR) - d Place, publisher, and date of publication (NR) - e Language of cataloging (NR) - i Relationship information (R) - l Data provenance (R) - n Note (R) - s Uniform title (NR) - t Title (NR) - w Record control number (R) - x International Standard Serial Number (NR) - There should be one new subfield in field 800 - y Data provenance (R) - There should be one new subfield in field 810 - y Data provenance (R) - There should be one new subfield in field 811 - y Data provenance (R) - There should be one new subfield in field 830 - y Data provenance (R) - There should be one new subfield in field 856 - e Data provenance (R) - Subfield l is renamed Standardized information governing access (R) - Subfield n is renamed Terms governing access (R) - Subfield r is renamed Standardized information governing use and reproduction (R) - Subfield t is renamed Terms governing use and reproduction (R) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:38:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:38:20 +0000 Subject: [Koha-bugs] [Bug 34665] Update MARC21 default framework to Update 35 (Dec. 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:41:08 +0000 Subject: [Koha-bugs] [Bug 34665] Update MARC21 default framework to Update 35 (Dec. 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:41:10 +0000 Subject: [Koha-bugs] [Bug 34665] Update MARC21 default framework to Update 35 (Dec. 2022) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155169|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156620&action=edit Bug 34665: Update MARC21 default framework to Update 35 (Dec. 2022) This patch updates the default MARC21 framework to reflect the changes brought by Update 35 (December 2022). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click Actions next to the default framework and choose MARC structure 4. Check for the changes detailed in the update https://www.loc.gov/marc/up35bibliographic/bdapndxg.html - There should be one new subfield in field 856 - g Persistent identifier (R) - Subfield h should now be named Non-functioning Uniform Resource Identifier - Subfield q should now be repeatable Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:41:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:41:45 +0000 Subject: [Koha-bugs] [Bug 34667] Update MARC21 default framework to Update 36 (June 2023) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:54:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:54:52 +0000 Subject: [Koha-bugs] [Bug 34150] Personal name (100a) field missing tag editor on acquisition framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34150 --- Comment #3 from Aude Charillon --- The library ended up switching UseACQFrameworkForBiblioRecords to "Don't use". But they would really like a way to force a selection from the authority file for author fields everywhere - including when creating a new record in Acquisitions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:55:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:55:02 +0000 Subject: [Koha-bugs] [Bug 35002] New: Identity Providers stop working after Apache Reload/Restart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35002 Bug ID: 35002 Summary: Identity Providers stop working after Apache Reload/Restart Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: agostino.nigro at nigroweb.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Upon restarting my Koha Instance via Apache Reload / Apache Restart, when the instance comes back up and I go to use the built in (New) Identity Providers (Oauth/OIDC)... it gives an error of: "There was an error authenticating to external identity provider No configuration found for your provider" Work around at this time is for me SSH into the Linux VM and reboot the entire machine which does not seem to be the correct way that the Identity Provider should work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:55:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:55:15 +0000 Subject: [Koha-bugs] [Bug 35002] Identity Providers stop working after Apache Reload/Restart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35002 agostino.nigro at nigroweb.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 14:55:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 12:55:31 +0000 Subject: [Koha-bugs] [Bug 34727] Update Sample OAI conf file docs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34727 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 15:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 13:59:35 +0000 Subject: [Koha-bugs] [Bug 34667] Update MARC21 default framework to Update 36 (June 2023) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 15:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 13:59:37 +0000 Subject: [Koha-bugs] [Bug 34667] Update MARC21 default framework to Update 36 (June 2023) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155175|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156621&action=edit Bug 34667: Update MARC21 default framework to Update 36 (June 2023) This patch updates the default MARC21 framework to reflect the changes brought by Update 36 (June 2023). To test: 1. Apply patch and restart 2. Go to Administration > MARC bibliographic framework 3. Click Actions next to the default framework and choose MARC structure 4. Check for the changes detailed in the update https://www.loc.gov/marc/bibliographic/bdapndxg.html - There should be one new subfield in field 041 - 3 Materials specified (NR) - There should be a new field 361, named STRUCTURED OWNERSHIP AND CUSTODIAL HISTORY - This field should be repeatable - Subfields: - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 3 Materials specified (NR) - 5 Institution to which field applies (NR) - 6 Linkage (NR) - 7 Data provenance (R) - 8 Field link and sequence number (R) - a Name (NR) - f Ownership and custodial history evidence term (R) - k Formatted date (NR) - l Date (NR) - o Type of ownership and custodial history information (R) - s Shelf mark of copy described (NR) - u Uniform Resource Identifier (R) - x Nonpublic note (R) **This should not be visible in the OPAC - y Identifier of the copy described (NR) - z Public note (R) - There should be three new subfields in field 653 - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 5 Institution to which field applies (NR) - There should be two new subfields in field 658 - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - There should be four new subfields in field 720 - 0 Authority record control number or standard number (R) - 1 Real World Object URI (R) - 5 Institution to which field applies (NR) - 7 Data provenance (R) - There should be a new field 857, named ELECTRONIC ARCHIVE LOCATION AND ACCESS - This field should be repeatable - Subfields - 2 Access method (NR) - 3 Materials specified (NR) - 5 Institution to which field applies (NR) - 6 Linkage (NR) - 7 Access status (NR) - 8 Field link and sequence number (R) - b Name of archiving agency (NR) - c Name of Web archive or digital archive repository (NR) - d Date range of archived material (NR) - e Data provenance (R) - f Archive completeness (NR) - g Persistent identifier (R) - h Non-functioning Uniform Resource Identifier (R) - l Standardized information governing access (R) - m Contact for access assistance (R) - n Terms governing access (R) - q Electronic format type (R) - r Standardized information governing use and reproduction (R) - s File size (R) - t Terms governing use and reproduction (R) - u Uniform Resource Identifier (R) - x Nonpublic note (R) - y Link text (R) - z Public note (R) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:03:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:03:28 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:15:01 +0000 Subject: [Koha-bugs] [Bug 34406] Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:15:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:15:04 +0000 Subject: [Koha-bugs] [Bug 34406] Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 --- Comment #1 from Owen Leonard --- Created attachment 156622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156622&action=edit Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the templates for identity providers and identity provider domains, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> Identity providers - New identity provider - Edit identity provider - Confirm deletion of identity provider - Manage domains - New domain - Edit domain - Confirm deletion of domain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:17:04 +0000 Subject: [Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:17:04 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:27 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:29 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155029|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 156623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156623&action=edit Bug 34677: Update to MARC21 relator terms list (May 31, 2013 technical notice) This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the May 31, 2013 technical notice. https://www.loc.gov/marc/relators/tn130531rel.html To test: 1. Apply patch and restart 2. Go to Administration > Authorized values > RELTERMS --> New terms should be there and deprecated terms should have been removed Additions: abr - Abridger apl - Appellant ape - Appellee adi - Art director ato - Autographer brl - Braille embosser brd - Broadcaster cas - Caster cor - Collection registrar cou - Court-governed crt - Court reporter edc - Editor of compilation edm - Editor of moving image work enj - Enacting jurisdiction fds - Film distributor fmk - Filmmaker fmd - Film director fmp - Film producer his - Host institution isb - Issuing body jud - Judge jug - Jurisdiction governed osp - On-screen presenter pan - Panelist pra - Praeses pre - Presenter prn - Production company prs - Production designer rdd - Radio director rpc - Radio producer rsr - Restorationist sll - Seller sgd - Stage director tld - Television director tlp - Television producer wac - Writer of added commentary wat - Writer of added text wal - Writer of added lyrics Deprecated relators: clb - Collaborator voc - Vocalist Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:31 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155153|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 156624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156624&action=edit Bug 34677: Update to MARC21 relator terms list (Feb 21, 2014 technical notice) This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the February 21, 2014 technical notice. https://www.loc.gov/marc/relators/tn140221rel.html To test: 1. Apply patch and restart 2. Go to Administration > Authorized values > RELTERMS --> New terms should be there and modified terms should be changed Additions: dgs - Degree supervisor med - Medium mtk - Minute taker vac - Voice actor wst - Writer of supplementary textual content win - Writer of introduction wpr - Writer of preface Changes: orm - Organizer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:34 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155154|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 156625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156625&action=edit Bug 34677: Update to MARC21 relator terms list (Dec. 14, 2020 technical notice) This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the December 21, 2020 technical notice. https://www.loc.gov/marc/relators/tn201214src.html To test: 1. Apply patch and restart 2. Go to Administration > Authorized values > RELTERMS --> New term should be there Addition: dgc - Degree committee member Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:37 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155155|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 156626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156626&action=edit Bug 34677: Update to MARC21 relator terms list (Apr. 26, 2021 technical notice) This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the April 26, 2021 technical notice. https://www.loc.gov/marc/relators/tn210426rel.html To test: 1. Apply patch and restart 2. Go to Administration > Authorized values > RELTERMS --> New term should be there Addition: pad - Place of address Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:39 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155156|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 156627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156627&action=edit Bug 34677: Update to MARC21 relator terms list (August 8, 2023 technical notice) This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the August 8, 2023 technical notice. https://www.loc.gov/marc/relators/tn230808rel.html To test: 1. Apply patch and restart 2. Go to Administration > Authorized values > RELTERMS --> New terms should be there anc - Announcer aue - Audio engineer aup - Audio producer bka - Book artist cad - Casting director cop - Camera operator dbd - Dubbing director djo - DJ edd - Editorial director fon - Founder mka - Makeup artist mup - Music programmer mxe - Mixing engineer nan - News anchor onp - Onscreen participant rap - Rapporteur rxa - Remix artist sde - Sound engineer sfx - Special effects provider swd - Software developer tau - Television writer tlg - Television guest tlh - Television host vfx - Visual effects provider Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:41 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155157|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 156628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156628&action=edit Bug 34677: (follow-up) Update transposed value Update sdg Stage director to sgd (May 31, 2013 technical notice). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:44 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156132|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 156629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156629&action=edit Bug 34677: (follow-up) Additional updates to match the LOC list This patch makes additional updates to the RELTERMS authorized value list to make it match the MARC Code List for Relators at https://www.loc.gov/marc/relators/relaterm.html and https://www.loc.gov/marc/relators/relacode.html It also updates the description displayed in the authorized values list. Test plan: 1. Apply the patch. 2. Reload the values (reset_all if using KTD). 3. Go to Administration > Authorized values. 4. Note that the description for RELTERMS is changed (now says 'MARC Code List for Relators (https://www.loc.gov/marc/relators/).' instead of 'French terms of relations'). 5. Check that the changes listed are incorporated into the RELTERMS authorized values list. Additions: prv - Provider rcd - Recordist stg - Setting Changes: aui - Author of introduction -> Author of introduction, etc. aus - Author of screenplay -> Screenwriter coe - Contestant -appellee -> Contestant-appellee cot - Contestant -appellant -> Contestant-appellant cou - Court-governed -> Court governed dpb -> dbp - Distribution place dgg - Degree grantor -> Degree granting institution osp - On-screen presenter -> Onscreen presenter pte - Plaintiff -appellee -> Plaintiff-appellee rcp - Recipient -> Addressee red - Redactor -> Redaktor wde - Wood-engraver -> Wood engraver Removals: -grt - Graphic technician Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:32:46 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 --- Comment #24 from Katrin Fischer --- Created attachment 156630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156630&action=edit Bug 34677: (QA follow-up) Update description of RELTERMS authorised value The patch as is kind of undid the change of bug 34679. The new proposal is a mix of this and the old version with a link that opens in a new tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:33:05 +0000 Subject: [Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:36:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:36:51 +0000 Subject: [Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:36:53 +0000 Subject: [Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155701|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156631&action=edit Bug 31832: Add reference for EnableItemGroups to EnableItemGroupHolds system preference This patch adds a note and a link to the EnableItemGroups system preference from the description of EnableItemGroupHolds. To test: 1. Apply patch 2. Go to Administration > System preference 3. Search for EnableItemGroup 4. Read the description of EnableItemGroupHolds, make sure the grammar and spelling are OK. 5. Click the link, it should bring you to EnableItemGroups Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:37:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:37:11 +0000 Subject: [Koha-bugs] [Bug 32890] Add DataTables to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 --- Comment #7 from Owen Leonard --- I'm not sure I'm seeing the issue with the default sort under each tab. Can someone take another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:38:39 +0000 Subject: [Koha-bugs] [Bug 34562] Update more pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:42:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:42:13 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:42:17 +0000 Subject: [Koha-bugs] [Bug 34562] Update more pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:42:19 +0000 Subject: [Koha-bugs] [Bug 34562] Update more pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155555|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156632&action=edit Bug 34562: Update more pop-up windows with consistent footer markup This patch updates a few more pop-up window templates to standardize the markup of footer controls. The patch also updates the way catalog.js triggers the "Add to list" pop-up so that it uses the same window-opening JS function that similar pages do, since the default gives us consistent popup features. To test, apply the patch and perform a catalog search in the staff interface which will return multiple results. - Check the box next to one or more results. - Click the "Add to list" button. - Test the various options here: Add to an existing list, a new list, or choose "More lists." - In each case the pop-up window which appears should have a consistent fixed footer with "Save" and "Cancel" buttons. - Confirm that these controls can be navigated to using the tab key. - Confirm that each one works correctly. - Go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button by the "SRU Search fields mapping" field. - Inspect and test the resulting pop-up window. - Switch the "Record type" dropdown to "Authority," click the "Modify" button again, and test this version of the pop-up window too. Signed-off-by: Émily-Rose Francoeur Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 16:47:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 14:47:43 +0000 Subject: [Koha-bugs] [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 --- Comment #1 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #0) > Bug 33245 beat bug 15504 into Koha.. unfortunately this leads to the new > method contained a series of hard coded queries for what the author felt are > 'activity'.. Bug 15504 puts this into the hands of the librarians by > exposing a preference for listing various actions that should trigger the > lastseen update. > > We should update the is_active method to reduce the hard coded database > calls used and utilise the activity stored in lastseen as defined by the > Triggers preference. 'for what the author felt' Does not sound very good? But okay. The 'author' asked for feedback on report 28688 which is still in the pipeline but was the starting point actually. Alas he got no feedback at all. Waited quite a bit too. So yes, I made a choice. Will have a look at the other report soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 17:14:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 15:14:41 +0000 Subject: [Koha-bugs] [Bug 35003] New: Holds with cancellation requests table on waitingreserves.tt does not filter by branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 Bug ID: 35003 Summary: Holds with cancellation requests table on waitingreserves.tt does not filter by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the waitingreserves.tt page the Holds with cancellation requests table does not initial filter by branch. The holds waiting and holds over table both do this. To recreate: 1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules. 2. Make several holds at different branches holds and set them to waiting 3. Request to cancel those holds, making sure you cancel some for different branches. 4. Go to waitingreserves.tt and notice that you see all of the holds from all branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 17:14:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 15:14:52 +0000 Subject: [Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 17:18:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 15:18:44 +0000 Subject: [Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 17:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 15:18:47 +0000 Subject: [Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 --- Comment #1 from Lucas Gass --- Created attachment 156633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156633&action=edit Bug 35003: Make cancelled hold requests filter by branch To recreate: 1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules. 2. Make several holds at different branches holds and set them to waiting 3. Request to cancel those holds, making sure you cancel some for different branches. 4. Go to waitingreserves.tt and notice that you see all of the holds from all branches. 5. APPLY PATCH and restart services 6. Vist the waitingreserves.tt page and notice that the "Holds with cancellation requests" table can now filters by branch. 7. Use the "View all libraries" and make sure you can see all the holds with a cancellation request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 17:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 15:19:04 +0000 Subject: [Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:01:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:01:11 +0000 Subject: [Koha-bugs] [Bug 33075] Add ability to mark an item as floating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33075 --- Comment #9 from Andrew Fuerste-Henry --- (In reply to Fridolin Somers from comment #8) > Is this somehow linked to Bug 9525 ? It seems like the changes in 9525 will require changes here, yeah. This patch treats floating rules as a binary, either on or off. Bug 9525 added a third option that is not represented here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:15:00 +0000 Subject: [Koha-bugs] [Bug 35004] New: Error about no quantity set on acquisitions order receive confirmation. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 Bug ID: 35004 Summary: Error about no quantity set on acquisitions order receive confirmation. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: slavashishkin at gmail.com Reporter: slavashishkin at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 8179, 34736, 33864 An error occurs when receiving the order. This happens if the user does not change the "Quantity received" field value, thereby not triggering the "OnChange" event. By default, the "Quantity received" field value is set to 1 by JS, but there is a row.quantity_received variable which serves as a shadow value which sent in a POST Ajax request after clicking "Confirm", yet row.quantity_received stays undefined despite the fact that we changed the form value by JS. row.quantity_received is expected to be updated on the "onChange" event for the form field, but that event does not fired when JS changes the form field value to 1. So if the user does not change the form field, it has a value of "1" but the form sends an empty value from the shadow value. This leads to an error from the backend which says "No quantity to receive set. No items will be created." in the popup. To test: 1. Add a new basket. 2. Create an order line 3. Receive shipment and create an invoice 4. Start receiving your order: Verify: - Quantity ordered: X - Quantity received: 1 (pre-filled, don't touch or change it) 5. Click "Confirm" 6. Observe the Receive error popup: "Order ZZZ: No quantity to receive set. No items will be created." 7. Verify that "Order receive" was not happen (received orders remains empty) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Problems in order receive modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:15:00 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:15:00 +0000 Subject: [Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:15:00 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:15:00 +0000 Subject: [Koha-bugs] [Bug 33867] Quantity received should default to number of unreceived items when creating items on cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35004 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:29:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:29:33 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 18:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 16:29:36 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 --- Comment #1 from Slava Shishkin --- Created attachment 156634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156634&action=edit Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we're in 'cataloguing' mode Before the code changes only field value was set to 1, but "row.quantity_received" still had an undefined value. After correction row.quantity_received set to 1 if it is empty, but only when effective_create_items == 'cataloguing', and after that its value assigned to the form field. To test: 1. Add a new basket. 2. Create an order line 3. Receive shipment and create an invoice 4. Start receiving your order: Verify: - Quantity ordered: X - Quantity received: 1 (pre-filled, don't touch or change it) 5. Click "Confirm" 6. Observe the Receive error popup: "Order ZZZ: No quantity to receive set. No items will be created." 7. Verify that "Order receive" was not happen (received orders remains empty) 8. Apply the patch and make sure your order is received correctly after step 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 19:31:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 17:31:58 +0000 Subject: [Koha-bugs] [Bug 27187] Cannot delete/update local cover image with LocalCoverImages off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27187 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #2 from Noémie Labine --- This also doesn't make sense if a library uses Local Cover Images as a CoceProviders option. If Coce is enabled and the provider Local Cover Images is used, LocalCoverImages still have to be set to Display if they want to add or edit an image in a record... I have a hard time understanding the benefit to hide the options related to the images... I believe the simplest way to correct that would be to just have the images options always visible in a bib details... Otherwise, we would need to change the behavior to hide the options only if LocalCoverImages, OPACLocalCoverImages AND Local Cover Images in CoceProviders (if Coce is used for OPAC or staff interface) are all disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 20:23:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 18:23:36 +0000 Subject: [Koha-bugs] [Bug 33928] Improve translation of title tags: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33928 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 20:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 18:23:38 +0000 Subject: [Koha-bugs] [Bug 33928] Improve translation of title tags: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33928 --- Comment #1 from Owen Leonard --- Created attachment 156635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156635&action=edit Bug 33928: Improve translation of title tags: Various This patch updates various templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have the correct title tags: - Staff interface -> Log in - Staff interface home page - Error page (e.g. for a missing page 404 error) - About page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 20:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 18:45:17 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 --- Comment #25 from David Nind --- (In reply to Katrin Fischer from comment #24) > Created attachment 156630 [details] [review] > Bug 34677: (QA follow-up) Update description of RELTERMS authorised value > > The patch as is kind of undid the change of bug 34679. The new > proposal is a mix of this and the old version with a link that > opens in a new tab. Thanks for picking that up and fixing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 22:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 20:40:28 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 22:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 20:46:48 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #6 from Katrin Fischer --- Is it safe to moderate account requests again or are the emails still not sent? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:45:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:45:04 +0000 Subject: [Koha-bugs] [Bug 8577] build_holds_queue.pl needs command-line options for help, verbosity, and summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8577 --- Comment #3 from Katrin Fischer --- So quiet would be used to suppress the warning, while the holds queue is only rebuilt for instances with RelTimeHoldsQueue off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:46:35 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:49:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:49:57 +0000 Subject: [Koha-bugs] [Bug 34991] Collapsed 245 subfields still show by default in Fast Add Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34991 --- Comment #2 from Katrin Fischer --- I think there might be some specific rule for 245 that prevents it from being hidden (which might go a bit too far here) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:53:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:53:09 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 --- Comment #2 from Katrin Fischer --- Hi Slava, did you test on latest master? This reads like bug 34880. + $("#creator").html(__("Account has been deleted")); This won't work, the __ is only for .js files, not for JavaScript in general. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:54:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:54:34 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 --- Comment #3 from Katrin Fischer --- In your test plan, which value did you set for creating items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:54:44 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:54:44 +0000 Subject: [Koha-bugs] [Bug 34880] Receive impossible if items created 'in cataloguing' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35004 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 6 23:55:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 21:55:05 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > In your test plan, which value did you set for creating items? Standing order? Subscription order? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:08:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:08:27 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #20 from Fridolin Somers --- Arf for UNIMARC there is a strange behavior, we had to patch to always set MARCFlavor : https://git.biblibre.com/biblibre/kohac/commit/cdb6e4cd1d56ae2904f7f722f21ba0f424a82190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:12:21 +0000 Subject: [Koha-bugs] [Bug 34909] Show collection when receiving items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show collection code when |Show collection when |receiving items |receiving items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:20:05 +0000 Subject: [Koha-bugs] [Bug 26500] Automatic renewals show incorrect count of renewals allowed when CircControl is set to "the library you're logged in at" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26500 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:21:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:21:07 +0000 Subject: [Koha-bugs] [Bug 34925] Favorite reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- This is an old idea :) *** This bug has been marked as a duplicate of bug 9567 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:21:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:21:07 +0000 Subject: [Koha-bugs] [Bug 9567] Favorite reports per user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Katrin Fischer --- *** Bug 34925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:31:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:31:43 +0000 Subject: [Koha-bugs] [Bug 9567] Favorite reports per user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 --- Comment #6 from Christopher Brannon --- (In reply to paxed from comment #3) > I see couple "easy" ways of doing this, without needing database changes: 1) > All in the client side, with cookies and javascript, or 2) Using a borrower > attribute to store the favorite report IDs I would not be in favor of anything that wouldn't follow you. Staff bounce around on different computers. This would be a difficult way to manage favorites. A table for tracking pages/tables/and borrower ids would be ideal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 00:37:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Oct 2023 22:37:31 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #43 from Katrin Fischer --- Can we have this backported now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 02:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 00:07:43 +0000 Subject: [Koha-bugs] [Bug 34637] Wiki - email notifications aren't being sent (account registrations, password resets, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34637 --- Comment #7 from David Nind --- (In reply to Katrin Fischer from comment #6) > Is it safe to moderate account requests again or are the emails still not > sent? I think everything is working now. It looks like confirmation emails are going out, as requesters confirmations are showing up. I have about 3 or 4 older requests to sort out, but for all future ones I think we are good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 03:26:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 01:26:56 +0000 Subject: [Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- Hi Kelly. It looks like you've signed off but haven't updated the status... David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:39:44 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:39:47 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154167|0 |1 is obsolete| | --- Comment #113 from Marcel de Rooy --- Created attachment 156636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156636&action=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:39:51 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154168|0 |1 is obsolete| | --- Comment #114 from Marcel de Rooy --- Created attachment 156637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156637&action=edit Bug 30708: Add Koha Objects Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:39:55 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154169|0 |1 is obsolete| | --- Comment #115 from Marcel de Rooy --- Created attachment 156638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156638&action=edit Bug 30708: Add tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:39:59 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154170|0 |1 is obsolete| | --- Comment #116 from Marcel de Rooy --- Created attachment 156639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156639&action=edit Bug 30708: REST API specs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:03 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154171|0 |1 is obsolete| | --- Comment #117 from Marcel de Rooy --- Created attachment 156640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156640&action=edit Bug 30708: Vue app This commit contains the main commit message The description of the original need is described in documents attached by the sponsor on the bug report specifically "[En] Preservation module - Main principles". The idea is to develop a whole new module to track the status of the documents that are sent for processings/treatments in order to preserve them (eg. covering). This is a first step, more are certainly coming later. The author and sponsors have worked for several months before providing this MVP version. The different discussion and needs can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban Some ideas of the next steps are also listed. The first iterations have been done using the classic .pl/.tt Koha style but we finally switched to a new Vue module, for more fun. These patches made the following main changes: New files * Koha objects under Koha/Preservation * REST API controllers under Koha/REST/V1/Preservation * preservation/home.pl and preservation/home.tt * Vue components under js/vue/components/Preservation * tests under t/db_dependent/Koha/Preservation and t/db_dependent/api/v1/preservation_* * Cypress tests under t/cypress/integration/Preservation DB: * 3 new sysprefs PreservationModule, PreservationNotForLoanWaitingListIn, PreservationNotForLoanDefaultTrainIn * 1 new permission "preservation" (will be split into subpermissions later) * 5 new tables: - preservation_processings - preservation_trains - preservation_processing_attributes - preservation_trains_items - preservation_processing_attributes_items Terminology and workflow: *Processings* are the different treatments an item can receive during its stay in the preservation module A *processing* is defined by a list of *attributes*. To make the module as easy to use for the librarians in charge of the preservation area a list of processings will be defined when the module will be set up. An *attribute* is a name and a value. That's it. However it also has a type, to define what the value is coming from: *free text*, *authorised value* or *database column*. For instance if you are defining a processing that will handling the book cover you could have 3 *attributes*: - first named "Barcode" that will be automatically filled with "items.barcode" (type *database column*" - second attribute named "color" linked with a new PRES_COLOR authorised value category you would have previously defined with "red", "blue", "green", etc. (type *authorised value*) - third attribute named "notes", because librarians like notes (type *free text*) Important: Even if the attribute is linked with a DB column or AV category, the value will be automatically pre filled but will stay editable (could be a config option to restrict the edition, later, if needed). The *status* of an item will change during the preservation process. First it will arrive in the preservation area and be on a *waiting list*. It is not processed already but is not available anymore for the patrons of the library. That's why we are going to use the "not for loan" (items.notforloan) value for this. This *waiting list* is a fictional concept, it simply lists all the items in the library with a specific *status*. A *train* is... how they call that at the BULAC, a train (same in French!). And we quite like the word so we kept it. It is what it is: a list of items/waggons, one after each other. We could have picked "cart", "list", but the concepts were already used in different places. We are not strongly attached to the term and it can be modified (but it's spread all over the code already and will be tedious to modify!) if you have a very good suggestion :) So, a *train* is where items are going after they have been sent to the waiting list. It's a stack of items that will be sent to a provider. When you create a new train you will be asked for the "Status for item added to this train", that will be the "not for loan" value to set to the items added to this train, and a "Default processing" that will be the processing used. But keep in mind that a train can have items that have different processings (specific case, will see later). When all items have been added to a *train*, you can *close* it. You cannot add items anymore to it! Then you can *send* it, and finally *receive* it. They are just statuses to keep track of the dates, and filter trains by status. However when a train is received you can *copy* an item to another (opened) train. It means that you have the item on hand but something went wrong, you are not happy with the work done by the supplier and want to send it back, so you create a new train (that can have different items, and it is the case where you will have items in a train that don't all have the same processing!). Test plan: A. Prerequisites 0. Just `reset_all` and jump to B, or: 1. Apache configuration You will need to edit /etc/koha/apache-shared-intranet-git.conf and add the following lines after the RewriteRule for erm (line.24?) RewriteCond %{REQUEST_URI} !^/cgi-bin/koha/preservation/.*.pl$ RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] The RewriteCond is only useful if you are testing the "print slips" bugs as well, but it cannot hurt to have it! 2. `yarn js:build` to regenerate the Vue app for the preservation module 3. `updatedatabase` 4. `restart_all` B. Settings 0. Create 2 different values for NOTLOAN, eg. 'In preservation' and 'In preservation external' Create different authorised values for a new category, eg. PRES_COLORS: RED, BLUE, GREEN. Feel free to create more categories. 1. You can turn on the "PreservationModule" syspref and go to the Koha homepage to see a new "Preservation" link 2. You landed on the empty home page of the preservation, no worry! We need to fill this page with useful information! (see #2 on the kanban) 3. Go to settings 4. Set "Status for item added to waiting list" to "In preservation" and "Default status for item added to train": "In preservation external" Create a new processing and define some attributes. Ideally at least one of each type. 5. Go to "Waiting list" and add some items 6. Go to "Trains" and create several trains (at least 2). Notice that the "Status for item added to this train" value is set to the value defined in the settings, but can be modified. Notice that this status can be set when a train is created but it won't be possible to edit later. 7. Add items to a train. You can only add items that are already in the waiting list. Add values for the attributes. Notice that the attributes linked with a database column are automatically pre filled. Notice that attributes linked with an authorised value are displayed with a dropdown list but that a different value can be set (remember, this is a feature!). Notice that attributes can be multivalued. 8. Add other items to the waiting list, notice the "Add last X items to a train" link at the top of the waiting list table, click it 9. You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list). Values can be set for the batch, but attributes linked with a database column are not editable (they will be prefilled automatically) 10. Once you have a train with several items, look at the "show train" view and notice the item list. If all of them are using the same processing then a table is displayed, one column per attribute. However if at least one item of the train has a different processing then the items are not listed in a table. 11. Edit items and confirm that the values are correctly saved. 12. Close, send and receive a train 13. Once a train is closed you can no longer add items to it 14. Once a train is received notice that you can "copy" an item to another (opened) train QA notes: The patch is huge! New enhancements and improvements have been moved to separate bug reports but this cannot be split. We need a ground base to build on top. The size is mainly coming from Vue components, Koha::Objects, REST API controllers and specs, and tests. Nothing hard ;) More to come: - See the kanban! - Print slips (bug 33547 and bug 34030) - Put something on the landing page! - Link with the acquisition module (suppliers, funds, etc.) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:07 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154172|0 |1 is obsolete| | --- Comment #118 from Marcel de Rooy --- Created attachment 156641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156641&action=edit Bug 30708: DB changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:10 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154173|0 |1 is obsolete| | --- Comment #119 from Marcel de Rooy --- Created attachment 156642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156642&action=edit Bug 30708: Add apache RewriteRule Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:14 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154174|0 |1 is obsolete| | --- Comment #120 from Marcel de Rooy --- Created attachment 156643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156643&action=edit Bug 30708: Koha controller script and template changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:19 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154175|0 |1 is obsolete| | --- Comment #121 from Marcel de Rooy --- Created attachment 156644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156644&action=edit Bug 30708: Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:22 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154176|0 |1 is obsolete| | --- Comment #122 from Marcel de Rooy --- Created attachment 156645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156645&action=edit Bug 30708: Do not allow edition of 'status for item added to train' It does not seem useful to enforce it at lower level, it is not a condition that will break the feature, but it does not feel correct to allow the modification of this value Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:26 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154177|0 |1 is obsolete| | --- Comment #123 from Marcel de Rooy --- Created attachment 156646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156646&action=edit Bug 30708: Keep item attributes when editing a new processing Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:29 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154178|0 |1 is obsolete| | --- Comment #124 from Marcel de Rooy --- Created attachment 156647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156647&action=edit Bug 30708: Show the copy button right after the train is received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:33 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154179|0 |1 is obsolete| | --- Comment #125 from Marcel de Rooy --- Created attachment 156648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156648&action=edit Bug 30708: Duplicate/copy items to an opened train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:37 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154180|0 |1 is obsolete| | --- Comment #126 from Marcel de Rooy --- Created attachment 156649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156649&action=edit Bug 30708: Do not allow deletion of processings that are used Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:41 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154181|0 |1 is obsolete| | --- Comment #127 from Marcel de Rooy --- Created attachment 156650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156650&action=edit Bug 30708: Do not allow copy item to a train if the item already exists in a non-received train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:44 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154182|0 |1 is obsolete| | --- Comment #128 from Marcel de Rooy --- Created attachment 156651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156651&action=edit Bug 30708: Do not allow adding new items to a closed train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:48 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154183|0 |1 is obsolete| | --- Comment #129 from Marcel de Rooy --- Created attachment 156652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156652&action=edit Bug 30708: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:52 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154184|0 |1 is obsolete| | --- Comment #130 from Marcel de Rooy --- Created attachment 156653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156653&action=edit Bug 30708: DBIC specific Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:55 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154185|0 |1 is obsolete| | --- Comment #131 from Marcel de Rooy --- Created attachment 156654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156654&action=edit Bug 30708: Allow attributes to be multivalued This is not working as it, but we are going to fix the problem when working on the "Set default values for items added in batch to a train" Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:40:59 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154186|0 |1 is obsolete| | --- Comment #132 from Marcel de Rooy --- Created attachment 156655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156655&action=edit Bug 30708: DO NOT PUSH - ONLY FOR DB UPDATE DURING TESTING STAGE Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:02 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154187|0 |1 is obsolete| | --- Comment #133 from Marcel de Rooy --- Created attachment 156656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156656&action=edit Bug 30708: DBIC Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:06 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154188|0 |1 is obsolete| | --- Comment #134 from Marcel de Rooy --- Created attachment 156657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156657&action=edit Bug 30708: Allow modifying attribute linked with AV to another value If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:10 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154189|0 |1 is obsolete| | --- Comment #135 from Marcel de Rooy --- Created attachment 156658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156658&action=edit Bug 30708: Set default values for items added in batch to a train Technical notes: Ideally we would have split TrainsFormAddItem to make some part reusable, but it turned out into a complicated component that would have been hard to maintain. It seems easier to have two different components. Ideas to improve this area are welcome! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:13 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154190|0 |1 is obsolete| | --- Comment #136 from Marcel de Rooy --- Created attachment 156659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156659&action=edit Bug 30708: Display AV descriptions instead of codes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:17 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154191|0 |1 is obsolete| | --- Comment #137 from Marcel de Rooy --- Created attachment 156660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156660&action=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:20 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154192|0 |1 is obsolete| | --- Comment #138 from Marcel de Rooy --- Created attachment 156661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156661&action=edit Bug 30708: Prevent dropdown list to be hidden behind the modal Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:24 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154193|0 |1 is obsolete| | --- Comment #139 from Marcel de Rooy --- Created attachment 156662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156662&action=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:28 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154194|0 |1 is obsolete| | --- Comment #140 from Marcel de Rooy --- Created attachment 156663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156663&action=edit Bug 30708: Add missing action buttons for non-table view If items with different processings are in a train, there is only the "edit" action button. It's missing "Remove" and "Copy". Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:32 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154195|0 |1 is obsolete| | --- Comment #141 from Marcel de Rooy --- Created attachment 156664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156664&action=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:35 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154196|0 |1 is obsolete| | --- Comment #142 from Marcel de Rooy --- Created attachment 156665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156665&action=edit Bug 30708: Fix Trains.ts tests Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:39 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154197|0 |1 is obsolete| | --- Comment #143 from Marcel de Rooy --- Created attachment 156666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156666&action=edit Bug 30708: Remove q_header from specs It broke the REST API routes. Adjustement for bug 33971. Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:42 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154198|0 |1 is obsolete| | --- Comment #144 from Marcel de Rooy --- Created attachment 156667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156667&action=edit Bug 30708: (bugfix) Redirect to train list view after the train is deleted Do not stay on the show train view. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:46 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154199|0 |1 is obsolete| | --- Comment #145 from Marcel de Rooy --- Created attachment 156668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156668&action=edit Bug 30708: Rebase - Rewrite toolbar Bug 33417 has changed how we handle the toolbars in Vue apps, this patch is adjusting the 'Preservation' module code on top of it, but also adds to make it more flexible (see bug 34215). Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:50 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154200|0 |1 is obsolete| | --- Comment #146 from Marcel de Rooy --- Created attachment 156669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156669&action=edit Bug 30708: Rebase - Use name instead of url for router-links Adjust code to match changes done by bug 32932. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:54 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154201|0 |1 is obsolete| | --- Comment #147 from Marcel de Rooy --- Created attachment 156670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156670&action=edit Bug 30708: Rebase - Adjust breadcrumbs To match what has been done on bug 33169 and bug 34418. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:41:57 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154202|0 |1 is obsolete| | --- Comment #148 from Marcel de Rooy --- Created attachment 156671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156671&action=edit Bug 30708: Rebase - Use a dedicated 'config' endpoint To retrieve the sysprefs, instead of using the svc script. See bug 33606. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:42:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:42:01 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154203|0 |1 is obsolete| | --- Comment #149 from Marcel de Rooy --- Created attachment 156672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156672&action=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:42:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:42:05 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156592|0 |1 is obsolete| | --- Comment #150 from Marcel de Rooy --- Created attachment 156673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156673&action=edit Bug 30708: Pass csrf_token to the Vue app It's needed since bug 34369 to POST to the syspref route Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:42:08 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156596|0 |1 is obsolete| | --- Comment #151 from Marcel de Rooy --- Created attachment 156674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156674&action=edit Bug 30708: Fix conflict with 34055 and 34219 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:42:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:42:12 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156597|0 |1 is obsolete| | --- Comment #152 from Marcel de Rooy --- Created attachment 156675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156675&action=edit Bug 30708: Remove c->validation in API controllers Fixed conflict with bug 33556 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 08:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 06:44:25 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #153 from Marcel de Rooy --- See former comments. Looks good to me. Another set of QA eyes would not hurt but I do not feel that it is a must. Feel free to change status back and have another QA round if so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 14:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 12:45:14 +0000 Subject: [Koha-bugs] [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 --- Comment #5 from Slava Shishkin --- (In reply to Katrin Fischer from comment #2) > Hi Slava, > > did you test on latest master? This reads like bug 34880. Hi Katrin, Yes, I checked this on the latest master. (In reply to Katrin Fischer from comment #4) > > In your test plan, which value did you set for creating items? > > Standing order? > Subscription order? The basket was closed before receiving items. It wasn't "Orders are standing" or "Subscription order". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:25:24 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:25:27 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156467|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156676&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:25:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:25:30 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156497|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 156677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156677&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:25:43 +0000 Subject: [Koha-bugs] [Bug 34390] Inconsistencies in Credit types page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:26:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:26:10 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:29:09 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156449|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156678&action=edit Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:29:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:29:44 +0000 Subject: [Koha-bugs] [Bug 34873] "Sending your cart/list" headings are inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:29:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:29:57 +0000 Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:33:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:33:41 +0000 Subject: [Koha-bugs] [Bug 33916] Improve translation of title tags: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Couldn't this be simplified? + [% IF ( label_element == 'layout' ) %] +

[% PROCESS translate_label_element element=label_element_title %]

+ [% ELSIF ( label_element == 'template' ) %] +

[% PROCESS translate_label_element element=label_element_title %]

+ [% ELSIF ( label_element == 'profile' ) %] +

[% PROCESS translate_label_element element=label_element_title %]

+ [% ELSIF ( label_element == 'batch' ) %] +

[% PROCESS translate_label_element element=label_element_title %]

+ [% END %] To just be?

[% PROCESS translate_label_element element=label_element_title %]

If the outcome is always the same, why do the if/else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:39:36 +0000 Subject: [Koha-bugs] [Bug 34796] Improve translation of title tags: Tools - Additional tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:39:39 +0000 Subject: [Koha-bugs] [Bug 34796] Improve translation of title tags: Tools - Additional tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155807|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156679&action=edit Bug 34796: Improve translation of title tags: Tools - Additional tools This patch modifies templates for tools under the "Additional tools" heading so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. To test, apply the patch and go to Tools. Test each page below and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Calendar - CSV profiles - Main page - New CSV profile - Modify CSV profile - Confirm deletion of CSV profile - Log viewer - Search results - News, HTML customizations, and pages - Create and modify each content type: news, pages, HTML customizations - Task scheduler - Quote editor - Main page - New quote - Edit quote - Import quotes - Uploads - Main page - Upload file - Delete file - Search for file - Access files - OPAC problem reports (with OPACReportProblem enabled) Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:40:39 +0000 Subject: [Koha-bugs] [Bug 34031] Move various translatable strings out of opac-bottom.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:41:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:41:43 +0000 Subject: [Koha-bugs] [Bug 34031] Move various translatable strings out of opac-bottom.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #4 from Katrin Fischer --- We need a sign-off on the dependency here, please! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:43:12 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:54:12 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:54:15 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156136|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 156680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156680&action=edit Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:55:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:55:08 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 --- Comment #5 from Katrin Fischer --- (In reply to Lucas Gass from comment #2) > Owen, > > I am having trouble getting content to appear when language packs are > installed. > > I have installed both fr-FR and es-ES, turned them on, and added content in > the right place for that language. Then I am switching to that language and > registering. > > Maybe I am missing something but can you check once more? I did some double checking and it seemed to work all ok. Some thing to keep in mind is that we need to set a publication date for things to show up at all. That's something that trapped me at first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 16:55:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 14:55:44 +0000 Subject: [Koha-bugs] [Bug 34869] Convert OPACResultsSidebar system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:01:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:01:15 +0000 Subject: [Koha-bugs] [Bug 34869] Convert OPACResultsSidebar system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:01:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:01:18 +0000 Subject: [Koha-bugs] [Bug 34869] Convert OPACResultsSidebar system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156126|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 156681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156681&action=edit Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:02:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:02:40 +0000 Subject: [Koha-bugs] [Bug 34034] Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #4 from Katrin Fischer --- We need a sign-off on one of the dependencies here, please! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:03:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:03:36 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in OPAC search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Accessibility: More |Accessibility: More |description required in |description required in |opac search breadcrumbs |OPAC search breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:23:27 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in OPAC search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 --- Comment #6 from Katrin Fischer --- I am not entirely sure about the presentation. With a complicated search query it could get rather long and lost in the end. Maybe it could be a new 'part'/section of the breadcrumb? Home > Results of search for 'p', page 6 of 21 Could then be: Home > Results of search for 'p' > Page 6 of 21 I guess thinking hierarchies it would not be quite right... Also: we lost Owen's sign-off line in the rebase. I'll re-add it in QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:24:09 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in OPAC search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:24:12 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in OPAC search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154500|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 156682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156682&action=edit Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. To test: 1) Apply patch 2) Run a search in the OPAC that will return more than 20 results. 3) The breadcrumb should say "Results of search for 'search term', page x of y" 4) Run a search that will return less than 20 results 5) The breadcrumb should say "Results of search for 'search term' Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:25:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:25:10 +0000 Subject: [Koha-bugs] [Bug 34566] Update MARC21 cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:29:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:29:39 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 --- Comment #4 from Katrin Fischer --- Not sure if we have a real dependency here on bug 34630 here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:32:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:32:05 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:38:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:38:15 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:38:18 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155573|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156683&action=edit Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:42:28 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156683|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 156684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156684&action=edit Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:42:32 +0000 Subject: [Koha-bugs] [Bug 34657] Merge cataloging plugins for UNIMARC 123d, e, f, and g In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34657 --- Comment #7 from Katrin Fischer --- Created attachment 156685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156685&action=edit Bug 34657: (QA follow-up) Fix plugin link in UNIMARC default framework Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 17:43:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 15:43:17 +0000 Subject: [Koha-bugs] [Bug 34630] Update MARC21 cataloging plugin templates with consistent body class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:24:42 +0000 Subject: [Koha-bugs] [Bug 34630] Update MARC21 cataloging plugin templates with consistent body class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:24:45 +0000 Subject: [Koha-bugs] [Bug 34630] Update MARC21 cataloging plugin templates with consistent body class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155565|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156686&action=edit Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Émily-Rose Francoeur Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:27:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:27:26 +0000 Subject: [Koha-bugs] [Bug 34566] Update MARC21 cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:27:30 +0000 Subject: [Koha-bugs] [Bug 34566] Update MARC21 cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155568|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 156687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156687&action=edit Bug 34566: Update MARC21 cataloging plugins with consistent footers This patch updates MARC21 cataloging plugin templates so that submit and cancel controls are consistently displayed in a fixed footer. To test, apply the patch and go to Cataloging. - Create or edit a bibliographic record - Test the cataloging plugins for these fields: - 000 (Leader) - 006 - 007 - 008 - In each case, confirm that the correct popup window is shown when you click the plugin link. - Confirm that clicking the "Cancel" button closes the window without copying any data to the field in the MARC editor. * Note that if the plugin is also triggered by cursor focus in the input field, some data may be automatically filled anyway. - Confirm that filing in data and clicking "Submit" will copy the correct information into the field. - Go to Authorities and create or edit an authority record. - Test the plugin for these fields: - 000 (Leader) - 008 - Perform the same tests as above. I don't think the marc21_field_008_classifications is used at all, but the template has been updated anyway. To test, edit your authority record to use the plugin: - Administration -> Authority types -> Default -> MARC structure -> 008 -> Subfields -> Edit. - Under Advanced constraints -> Plugin, select "marc21_field_008_classifcations.pl" - Re-test the behavior of the authority editor's tag 008 plugin to confirm that this plugin is used and works correctly. Signed-off-by: Émily-Rose Francoeur Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:36:57 +0000 Subject: [Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:37:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:37:01 +0000 Subject: [Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155725|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 156688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156688&action=edit Bug 34661: Update UNIMARC cataloging plugins with consistent footers This patch updates UNIMARC cataloging plugin templates so that they have consistent fixed footers in the plugin popup window. Plugins for the following UNIMARC fields have been updated: 000 (Leader) 123$f 128$a 181$b 100$a 123$g 128$b 182$2 105$a 123$i 128$c 182$a 106$a 123$j 130$a 182$c 110$a 124$a 135$a 183$2 115$a 124$b 140$a 183$a 115$b 124$c 141$a 210$c 116$a 124$d 146$a 225$a 117$a 124$e 146$c 225$a 120$a 124$f 146$d 283$2 121$a 124$g 146$e 283$a 121$b 125$a 146$f 325$h 122$a 125$b 146$h 325$j 123$a 126$a 146$i 123$d 126$b 181$2 123$e 127$a 181$a Most of these will be pre-configured in a test system with default UNIMARC data. In KTD you can use the 'reset_all_unimarc' command. Go to Cataloging -> New record and test the plugin link for each of the fields listed above. - In each case, confirm that the correct popup window is shown when you click the plugin link. - Confirm that clicking the "Cancel" button closes the window without copying any data to the field in the MARC editor. * Note that if the plugin is also triggered by cursor focus in the input field, some data may be automatically filled anyway. - Confirm that filing in data and clicking "Submit" will copy the correct information into the field. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:37:04 +0000 Subject: [Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155726|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 156689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156689&action=edit Bug 34661: FOR TESTING ONLY, a database update to configure MARC plugins This patch is for testing purposes only: An update to change the default framework's plugin settings for various fields in order to make all the updated UNIMARC plugin available. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:37:19 +0000 Subject: [Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:50:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:50:36 +0000 Subject: [Koha-bugs] [Bug 34270] Upgrade and prune jQueryUI assets in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:50:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:50:41 +0000 Subject: [Koha-bugs] [Bug 34270] Upgrade and prune jQueryUI assets in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155560|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 156690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156690&action=edit Bug 34270: Upgrade and prune jQueryUI assets in the staff interface This patch updates jQueryUI assets in the staff interface with an upgraded and trimmed version which includes only support for jQueryUI autocomplete. Global staff interface CSS has been modified to remove unused jQueryUI-related styles and to accommodate the updated assets. The patch also removes some unused jQueryUI image assets from the OPAC templates. To test, apply the patch and rebuild the staff interface CSS. Test the "Check out" form in the header to confirm that it still looks correct and works correctly. Signed-off-by: Émily-Rose Francoeur Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:50:58 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:51:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:51:02 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154387|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 156691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156691&action=edit Bug 34457: Added cardnumber view to hold details page Signed-off-by: Rebecca Coert Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:55:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:55:35 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- I really like this, but there is a small caveat: This works for the case where the sort fields are used with free text input, but not when you are using it with the bsort1 and bsort2 authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 19:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 17:56:04 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) (tested with a long name and long card number, page layout is still good) @Laura it seem the test plan was put in the bugzilla comment when attaching the commit. It works better to put it in the commit message directly. That way a signoff doesn't cause the test plan to be lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:02:46 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:13 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:16 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156416|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 156692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156692&action=edit Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:19 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156417|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 156693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156693&action=edit Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:22 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156418|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 156694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156694&action=edit Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:26 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156419|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 156695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156695&action=edit Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:29 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156420|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 156696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156696&action=edit Bug 33845: (follow-up) Rename config and add a second configuration section This patch renames the table in the columns configuration to match the id used in the templates It also adds a section for the moremember table to alllow config of each page as we do for issues Lastly we add the table controls as they exist on the issues tables Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:19:33 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156421|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 156697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156697&action=edit Bug 33845: Tidy and add update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:38:54 +0000 Subject: [Koha-bugs] [Bug 35005] New: Add subscription and order count to new batch record deletion tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35005 Bug ID: 35005 Summary: Add subscription and order count to new batch record deletion tool Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The batch record deletion tool checks for items, holds and checkouts. It would be a nice enhancement to also show linked subscriptions and orders. This would then match the checks done in acquisitions in order to be able to delete the record when cancelling an order line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:58:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:58:24 +0000 Subject: [Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35005 Summary|Add subscription and order |Add warnings about |count to new batch record |subscriptions and orders |deletion tool |when deleting items --- Comment #6 from Katrin Fischer --- Hi Thibaud, I was excited to see this, but it turned out a little bit different to what I had expected: 1) The bug was filed for the 'batch record deletion tool'. Your patch deals with deleting single items. This can be fixed rather easily by changing the bug description and re-filing (see bug 35005) 2) For orders, I think we need to make some difference between an order that has been completed and one that is still pending. Deleting an item that is linked to a pending order would get us in trouble. Throwing out an old item purchased long ago not. Concerning order status would be: new, ordered, partial OK to delete: cancelled, complete 4) This line appears unrelated to the intention of the patch: + $i->{nomod} = 1 unless $patron->can_edit_items_from($item->homebranch); 5) The warnings messages you created are untranslatable, they need to be moved into the templates: cataloguing/additem.pl + if ($i_order) { + $warning_messages{$i->{itemnumber}} = sprintf('There is an order (ordernumber %s) on this item', $i_order->{ordernumber} ); + } + if ($i_serialid) { + $warning_messages{$i->{itemnumber}} = 'A subscription is linked to this item' 6) The subscription count on item batch modification doesn't seem to work right. I added a subscription and created an item on receiving an issue, so it's linked to the subscription. But it still said "None" on the batch mod page. 7) The order count on item batch modification doesn't appear to work either. I added an order with 'create items on order' and that item to the batch edit - The column remained at "None". 8) The notes work OK on the normal item editing form. I like the approach with the little warning sign. 9) QA tools are failing for a missing filter and tidiness. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 20:58:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 18:58:24 +0000 Subject: [Koha-bugs] [Bug 35005] Add subscription and order count to new batch record deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13870 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 21:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 19:13:33 +0000 Subject: [Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 21:13:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 19:13:36 +0000 Subject: [Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152529|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 156698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156698&action=edit Bug 34035: (preparatory cleanup) Convert indentation to spaces. This patch converts tabs to spaces in tags.js. No other changes are made. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 7 21:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Oct 2023 19:13:39 +0000 Subject: [Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152530|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 156699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156699&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the [% END %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:40:28 +0000 Subject: [Koha-bugs] [Bug 33688] ApplyFrameworkDefaults does not work When adding a record to basket with the "from a new (empty) record" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 34993 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:40:28 +0000 Subject: [Koha-bugs] [Bug 34993] Framework don't load in existing records or duplicate as new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca --- Comment #5 from Katrin Fischer --- *** Bug 33688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:40:56 +0000 Subject: [Koha-bugs] [Bug 34499] Framework defaults don't work when adding records with the option "from a new (empty) record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 34993 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:40:56 +0000 Subject: [Koha-bugs] [Bug 34993] Framework don't load in existing records or duplicate as new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 --- Comment #6 from Katrin Fischer --- *** Bug 34499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:41:37 +0000 Subject: [Koha-bugs] [Bug 34993] Framework don't load in existing records or duplicate as new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 [Bug 30250] Configure when to apply framework defaults when cataloguing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:41:37 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 [Bug 34993] Framework don't load in existing records or duplicate as new -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:41:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:41:59 +0000 Subject: [Koha-bugs] [Bug 34993] Framework doesn't load defaults in existing records or duplicate as new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Framework don't load in |Framework doesn't load |existing records or |defaults in existing |duplicate as new |records or duplicate as new -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:47:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:47:53 +0000 Subject: [Koha-bugs] [Bug 35181] New: Can no longer edit sample records with advanced cataloguing editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Bug ID: 35181 Summary: Can no longer edit sample records with advanced cataloguing editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I wonder if this is a side effect on the recent work on 'invalid metadata'. * Activate * Make sure you open any record with the advanced editor * Try to open: Perl best practices / Damian Conway. * You get stuck in loading * Javascript error shows "Invalid-metadata" on top of the MARC record, causing a syntax error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 10:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 09:58:15 +0000 Subject: [Koha-bugs] [Bug 30356] Author facets for names with single quotes (') don't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- I just retested this with "Kum'a N'dumbe" and "Test'me" and both work nicely in newer versions. I believe this has been fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:01:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:01:32 +0000 Subject: [Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #7 from Katrin Fischer --- I think the last bit about the display in the OPAC could maybe be simplified, but I like the optional/mandatory approach. Right now the notices are hardcoded to 3 levels, we could try to make the code more flexible, but it feels like it might things more complex while there is no development on bug 12771. Maybe easier to do it once it's actually required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:01:48 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:14:12 +0000 Subject: [Koha-bugs] [Bug 35182] New: Activating "UnseenRenewals" causes problems in circulation rules editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35182 Bug ID: 35182 Summary: Activating "UnseenRenewals" causes problems in circulation rules editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have some JavaScript to avoid copying values like "Default" and "unlimited" into the input fields when a circulation rule is edited. The JavaScript uses the column index to identify the fields. This gets broken when "UnseenRenewals" is activated moving the column index numbers by 1. See also bug 8367 for a possible fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:14:12 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35182 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:12 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:19 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157697|0 |1 is obsolete| | --- Comment #299 from Katrin Fischer --- Created attachment 158023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158023&action=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:27 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157698|0 |1 is obsolete| | --- Comment #300 from Katrin Fischer --- Created attachment 158024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158024&action=edit Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:34 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157699|0 |1 is obsolete| | --- Comment #301 from Katrin Fischer --- Created attachment 158025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158025&action=edit Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:42 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157700|0 |1 is obsolete| | --- Comment #302 from Katrin Fischer --- Created attachment 158026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158026&action=edit Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:50 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157701|0 |1 is obsolete| | --- Comment #303 from Katrin Fischer --- Created attachment 158027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158027&action=edit Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:16:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:16:58 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157702|0 |1 is obsolete| | --- Comment #304 from Katrin Fischer --- Created attachment 158028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158028&action=edit Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:07 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157703|0 |1 is obsolete| | --- Comment #305 from Katrin Fischer --- Created attachment 158029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158029&action=edit Bug 8367: (follow-up) Remove unnecessary code and atomic update Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:16 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157704|0 |1 is obsolete| | --- Comment #306 from Katrin Fischer --- Created attachment 158030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158030&action=edit Bug 8367: (follow-up) possible to delete circ rule Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:24 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157705|0 |1 is obsolete| | --- Comment #307 from Katrin Fischer --- Created attachment 158031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158031&action=edit Bug 8367: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:32 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157706|0 |1 is obsolete| | --- Comment #308 from Katrin Fischer --- Created attachment 158032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158032&action=edit Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:40 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157707|0 |1 is obsolete| | --- Comment #309 from Katrin Fischer --- Created attachment 158033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158033&action=edit Bug 8367: Add holds_pickup_period fallback circulation rule Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:48 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157708|0 |1 is obsolete| | --- Comment #310 from Katrin Fischer --- Created attachment 158034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158034&action=edit Bug 8367: (QA follow-up) Fix QA script * Add +x to atomic database update file * Perltidy * Add spans to rewritten tab label for translatability Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:17:55 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157715|0 |1 is obsolete| | --- Comment #311 from Katrin Fischer --- Created attachment 158035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158035&action=edit Bug 8367: (follow-up) Fix for circ rules editor Make sure holds pickup period field is empty when editing a 'default' rule. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:20:10 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #312 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #298) > > This means we need to adjust the column from 31 to 32, but I didn't write > > the follow-up for that, because I found what broke the behavior: > > > > * Turn on UnseenRenewals system preference > > > > It throws the column count...and then we are back at the default copying > > into the input field. > > > > Could you try to fix that? > > Hi Katrin, I've done a new fix for this. I noticed the UnseenRenewals circ > rule breaks a bunch of other rules in the same way, so maybe we can adopt > this new way of identifying those columns in another bug report. Hi Aleisha, thanks for that! I failed to come up with the right syntax :) I have filed a new bug to deal with the pre-existing problem for the other circulation rules: Bug 35182 - Activating "UnseenRenewals" causes problems in circulation rules editor Happy to pass QA now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:24:57 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #15 from Katrin Fischer --- (In reply to mathieu saby from comment #14) > Hi > you marked https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34049 > as a duplicate, but I am not sure of that. > By "logs", do you mean logs visible in /tools/viewlog.pl ? > > What I meant in 34049 was not to "log" modifications that way, because logs > are often disabled in production Koha for performance issues, and not easy > to consult for the average librarian. I was thinking of a real "feature" > permitting any fund owner/user to see the modifications of their fund. It > means at least (very quick draft) > - creating a new column inital_amount in aqbudgets > - creating a new SQL table like aqbudgets_changes > - each new line aqbudgets_changes would add or substract money (with an > optional comment) to aqbudgets.budget_amount, without altering > aqbudgets.inital_amount > and of course some substantial modifications to the templates Hi Mathieu, I have to admit I have never heard of people turning off logs for perfomance. I know that we keep the CatalougingLog off for the size it creates. My suggestion here would be to create a log for the funds/budgets only and then we could use the entries to build a nicer display than the log viewer gives us if required. A separate table could also be an option. I believe the idea of the two bugs is the same, so we can have the discussion about requirements and implementation in one place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:27:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:27:00 +0000 Subject: [Koha-bugs] [Bug 19062] Don't queue check-in/checkout messages if patron has no e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- I am closing this WONTFIX then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:38:37 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 --- Comment #6 from Katrin Fischer --- I think it would be nicer if we also had the option here to see the option groups with the budgets. But this fixes the immediate problem of the inactive funds showing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:41:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:41:46 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:41:49 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157751|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 158036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158036&action=edit Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets This requires enabling MarcItemFieldsToOrder, see bug 34645 Add an inactive Budget and some funds to your system Import a file with multiple biblios Confirm the button hids/displays the funds for all item orders Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:43:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:43:09 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #97 from Katrin Fischer --- (In reply to Katrin Fischer from comment #96) > I tried testing this, but have run into 2 dead ends: > > * Manually added a HOLD_CANCELLATION notice > * Added email address to my patron, created a bunch of holds > * Verified the AV exists and has values > * Verified my patron has a primary email set > > 1) From the patron account > * Switch No to Yes for cancelling a hold > * Choose reason, leave notify patron checked > * Cancelled hold > * Hold was cancelled, but: No notice was created > > 2) Record detail page, holds tab: > * Click on "garbage can" - modal comes up without cancellation reason pull > down or notify option I'd love to see this moving. We initially wanted to fix it right away after introducing the feature... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:46:42 +0000 Subject: [Koha-bugs] [Bug 26547] Move context from msgid to msgctxt in pref PO files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Katrin Fischer --- Adding Jonathan because of his work on Weblate/translations. Only a note here: we need to take care that the Do/Don't etc. are not ending up 'collapsed'. In order to form proper sentences for the system preferences they are not always translated the same way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:52:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:52:20 +0000 Subject: [Koha-bugs] [Bug 27460] News: Remove title from author display on news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Yes, it's still the case: * Make sure your patron has a firstname, surname and title * Set NewsAuthorDisplay to "both OPAC and staff interface" * Create a new news entry, remember to set publication date in the past * Save * Verify that the title shows in the staff interface and in the OPAC on the news entry. I am no longer sure if this is fully unintentional. Some libraries don't use the title for Mr. Mrs. etc. but for Prof., Dr. etc. in that case the display would probably be intended. And: the title has it's own class for easy hiding. Closing WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 11:53:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 10:53:40 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Katrin Fischer --- Adding Jonathan, maybe with his recent work on the manual/translations he knows about a possible solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:00:20 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 --- Comment #2 from Katrin Fischer --- Hi Caroline, I think these are all good points! I was curious about how to mark the versions in the new one manual. I think we'd need possibly: * Appears in version x * Removed in version x * Moved into in version x How to deal with backported features: do we give the exact version to the third number? 22.11.12? Or only the first 'big' release it went into? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:02:56 +0000 Subject: [Koha-bugs] [Bug 35183] New: Rename intranetreadinghistory to IntranetReadingHistory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35183 Bug ID: 35183 Summary: Rename intranetreadinghistory to IntranetReadingHistory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31357 Taken from Jonathan's suggestion on bug 31357: (In reply to Jonathan Druart from comment #5) > It would be nice to rename intranetreadinghistory with > IntranetReadingHistory for the same release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 [Bug 31357] Separate holds history from intranetreadinghistory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:02:56 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35183 [Bug 35183] Rename intranetreadinghistory to IntranetReadingHistory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:05:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:05:45 +0000 Subject: [Koha-bugs] [Bug 35183] Rename [opac|intranet]readinghistory to [Opac/Intranet]ReadingHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename |Rename |intranetreadinghistory to |[opac|intranet]readinghisto |IntranetReadingHistory |ry to | |[Opac/Intranet]ReadingHisto | |ry --- Comment #1 from Katrin Fischer --- Hm, not as eaasy, if we want to stay consistent with the OPAC version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:06:24 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #5) > It would be nice to rename intranetreadinghistory with > IntranetReadingHistory for the same release. Filed as: Bug 35183 - Rename [opac|intranet]readinghistory to [Opac/Intranet]ReadingHistory Turns out not quite as easy as we also should take care of opacreadinghistory at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:07:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:07:45 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #22 from Katrin Fischer --- Could we get a sign-off here please? It's not only a translations problem, but also a problem with using this form in any other language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:13:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:13:41 +0000 Subject: [Koha-bugs] [Bug 32508] Translation gives incorrect menu text in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32508 --- Comment #1 from Katrin Fischer --- Hi Elaine, I haven't seen this happening for us. Did you do any update since and did the problem remain? To check the correct po files, which was the exact version you saw/see this in? (to the third number). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:16:56 +0000 Subject: [Koha-bugs] [Bug 34205] Default server checkbox not working when editing an SMTP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34622, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34616 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I tested and it seems to work OK now, either fixed by bug 34622 or bug 34616 I reckon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:16:56 +0000 Subject: [Koha-bugs] [Bug 34622] SMTP server edit page unsets is_default if editing default server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34205 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:16:56 +0000 Subject: [Koha-bugs] [Bug 34616] "Edit SMTP server" page - Default SMTP configuration dialog has some issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34205 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:24:29 +0000 Subject: [Koha-bugs] [Bug 34087] [22.11] Required label displays twice for Hold end and start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Required label displays |[22.11] Required label |twice for Hold end date |displays twice for Hold end | |and start date --- Comment #1 from Katrin Fischer --- I can confirm this in 22.11: * Set both hold dates to required via OPACMandatoryHoldDates * Set OPACAllowHoldDateInFuture to Allow * Place a hold in the OPAC, leave dates empty * Verify the Required in red appears twice on each date field The problem is not present in the current development version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:35:19 +0000 Subject: [Koha-bugs] [Bug 34606] Advanced editor doesn't populate framework defaults when creating a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 34993 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:35:19 +0000 Subject: [Koha-bugs] [Bug 34993] Framework doesn't load defaults in existing records or duplicate as new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #7 from Katrin Fischer --- *** Bug 34606 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:39:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:39:30 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:39:33 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145875|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 158037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158037&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:41:33 +0000 Subject: [Koha-bugs] [Bug 33842] Search for authid not returning right results with QueryAutoTruncate ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32707 --- Comment #2 from Katrin Fischer --- Maybe bug 32707 would fix this as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:41:33 +0000 Subject: [Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:45:48 +0000 Subject: [Koha-bugs] [Bug 32699] Patron browse 'forgets' how many entries to show In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I just tested this in the current development version and in 22.11: * Searched for 'all' patrons with an empty search * Changed per page setting to 10 * Clicked on an entry in the list, going to the patron account * Used the browser back button - setting remained I think we cannot save longer than this right now - there is no cookie or similar for this type of setting on the tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:46:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:46:57 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #9 from Katrin Fischer --- Is this a duplicate of bug 32783 now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:47:07 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32783 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:47:07 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35095 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:47:55 +0000 Subject: [Koha-bugs] [Bug 34783] Update list of 'Contributing companies and institutions' on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34783 --- Comment #3 from Katrin Fischer --- (In reply to Martin Renvoize from comment #2) > Coming up to release.. please remind me a little closer and I can work with > Tomas to get it done.. must admit, I've forgotten how the scripts work at > this point. *ping* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:50:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:50:20 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #1 from Katrin Fischer --- It looks like this is still the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 12:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 11:54:07 +0000 Subject: [Koha-bugs] [Bug 7827] After creating a new biblio to be used in a subscription, the subscription entry form should be populated with the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7827 --- Comment #3 from Katrin Fischer --- I just tested this and the biblionumber was not sent back to the form when closing the window. 1) Add new subscription 2) Create record link 3) Downloaded a record from Z39.50 4) Fixed errors 5) Saved 6) Went to item form, instead of closing 7) Closing window manually - biblionumber remains empty. If this is not supposed to work, maybe we should open the cataloguing form in a new tab instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:00:06 +0000 Subject: [Koha-bugs] [Bug 34504] Elasticsearch error when updating mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I just tested and believe this was fixed by patches on other bugs. The sortable pull down now shows Yes/No. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:02:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:02:23 +0000 Subject: [Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 --- Comment #3 from Katrin Fischer --- The display issue here might be fixed by Bug 8367 - How long is a hold waiting for pickup at a more granular level It removes the number from the tab, as with it being in the circulation rules multiple different values might apply. For the timing, I am not sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:02:31 +0000 Subject: [Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8367 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:02:31 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:12:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:12:51 +0000 Subject: [Koha-bugs] [Bug 32479] Replace sort: ~ by sort: 0 in mappings.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32479 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- It looks like this was fixed with the first patch of: Bug 33594 - Sorting results by Title A-Z might use wrong title field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:40:26 +0000 Subject: [Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #22 from Alex Buckley --- (In reply to David Nind from comment #21) > (In reply to Alex Buckley from comment #16) > > Hi David, > > > > Sorry for my delay, I've just back from a long holiday. I hope you are doing > > well :) > > > > I've rebased these patches against master. Ready to test again now. > > > > Alex > > Hi Alex. > > Welcome back! I hope you had a great holiday! (I'm doing well, thanks!) > > I've now signed off. > > I've also updated the system preference description, mainly for consistency > with other system preferences (such as NOTE in capitals, script name in a > code block) as well as some other wording changes. Feel free to remove if > you prefer the original description. > > David Hi David Thanks so much, yes I did have a very nice holiday around Italy with my parents it was lovely. That's great to hear you're doing well :) Thank you for testing and signing off, also appreciate your update to the system preference description that is much better now! Kind regards, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:47:49 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #16 from mathieu saby --- Well, our vendor (Biblibre) told us not to activate the logs in general, but we did not ask specifically if logging acquisition activities could impact performances... Anyway, my colleagues asked recently for a way to *easily* track changes to their funds by the acquisition coordinator (quite often at the end of the year). We will give a try to the logging system, maybe it could suit our needs, but I doubt that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 13:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 12:50:25 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #17 from Katrin Fischer --- (In reply to mathieu saby from comment #16) > Well, our vendor (Biblibre) told us not to activate the logs in general, but > we did not ask specifically if logging acquisition activities could impact > performances... > > Anyway, my colleagues asked recently for a way to *easily* track changes to > their funds by the acquisition coordinator (quite often at the end of the > year). We will give a try to the logging system, maybe it could suit our > needs, but I doubt that. It doesn't work right now. There is no logging implemented for fund changes, but only other acq activities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:11:33 +0000 Subject: [Koha-bugs] [Bug 33842] Search for authid not returning right results with QueryAutoTruncate ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #3 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #2) > Maybe bug 32707 would fix this as well? Yes, it would--in a more general way, IMHO, also solving a problem of sn:1 and the like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:39:47 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #4 from Katrin Fischer --- This is a data loss bug, marking as major. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:42:27 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:42:30 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157221|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 158038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158038&action=edit Bug 35073: Rename additional_fields to available_additional_fields 'additional_fields' is ambiguous and in other places we name this available_additional_fields instead. Do the same here. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:42:33 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157222|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 158039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158039&action=edit Bug 35073: Default to existing value if there is one For values that dont exist in the batch edit submission, i.e. UI says 'No change', we default to existing value if there is one. Test plan: Preparation - Additional fields: 1) Add a new 'additional field', visit: /cgi-bin/koha/admin/additional-fields.pl 2) Click 'subscription' and '+ New field'. Enter a 'name' and hit 'save'. Serials: 1) Add a new serial, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Put a biblionumber in the 'record' field, i.e. '112'. Press 'next' and click 'ok' on the alert box 3) Fill all the required fields and click 'test prediction' 4) Input something in the additional field created previously. 5) Click 'save subscription'. Notice the additional field is as expected. 6) Repeat steps 1-5 to create a second serial. Batch edit: 1) Visit serials and hit the 'Search' button: /cgi-bin/koha/serials/serials-home.pl 2) Click the 2 checkboxes for the 2 serials we created previously and click the new link that pops up 'edit selected serials'. 3) Click 'Save' without changing anything. 4) Go back to either of the serials, notice the value for the additional field is unchanged. Visit: /cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:42:36 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157223|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 158040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158040&action=edit Bug 35073: perltidy subscription-batchedit.pl git show -w Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:46:06 +0000 Subject: [Koha-bugs] [Bug 34989] Subscription cannot be added if a control field is set up in "Additional Fields" parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master --- Comment #1 from Katrin Fischer --- Confirmed in current development version. Tested with 001 and 001 at . It would be nice if we could add support as the 001 would be really useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:52:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:52:05 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 14:52:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 13:52:05 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:01:20 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #2 from Katrin Fischer --- OK, now I totally confused myself here: kohastructure.sql: reserves CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE This means, that when the item_group is deleted, we delete the reserve. I think this could create possible issues as we usually should not delete but cancel (move to old_reserves). If we set to null, it turns itself into a title level hold, which seems safer at least. I think SET NULL would make more sense here too. old_reserves CONSTRAINT `old_reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE SET NULL So, when an item_group is deleted, we set it to null in old_reserves. This makes sense, as we would want to keep the entry for hold statistics. Database update: unless ( column_exists( 'reserves', 'item_group_id' ) ) { $dbh->do(q{ ALTER TABLE reserves ADD COLUMN `item_group_id` int(11) NULL default NULL AFTER biblionumber, ADD CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE; }); } unless ( column_exists( 'old_reserves', 'item_group_id' ) ) { $dbh->do(q{ ALTER TABLE old_reserves ADD COLUMN `item_group_id` int(11) NULL default NULL AFTER biblionumber, ADD CONSTRAINT `old_reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE SET NULL; }); } I suggest to alter the database definition to fit the original updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:19:33 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:19:36 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #3 from Katrin Fischer --- Created attachment 158041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158041&action=edit Bug 34520: Fix FK for item_groups in reserves for new installations There was a discrepancy between the database update for reserves and the kohastructure.sql definition. This makes sure that the FK is always "ON DELETE SET NULL". To test: * Before applying this path * sudo koha-mysql kohadev * show create table reserves; CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE * Apply patch * Run database update * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE * reset_all (create a new database) * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:19:51 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:21:01 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #4 from Katrin Fischer --- In the end, it wasn't that confusing, but check my patch carefully please :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:33:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:33:09 +0000 Subject: [Koha-bugs] [Bug 34488] Import default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master --- Comment #1 from Katrin Fischer --- I can confirm this. * Export default MARC framework - works OK * Change field description of LEADER * Import default MARC framework * Confirm security question "Do you really..." * Watch loading... * Get redirected to the page, that you see when editing an empty framework * Go back to the Default framework * Confirm the LEADER description hasn't been changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:33:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:33:16 +0000 Subject: [Koha-bugs] [Bug 34488] Cannot import default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Import default framework |Cannot import default | |framework -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:37:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:37:42 +0000 Subject: [Koha-bugs] [Bug 34424] Update release team on about page for new QA team member In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:38:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:38:13 +0000 Subject: [Koha-bugs] [Bug 34424] Update release team on about page for new QA team member In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:38:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:38:15 +0000 Subject: [Koha-bugs] [Bug 34424] Update release team on about page for new QA team member In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 --- Comment #1 from Katrin Fischer --- Created attachment 158042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158042&action=edit Bug 34424: Add Emily Lamancusa to QA Team Long overdue. To test: * Apply patch * Verify that Emiley shows as part on the QA Team on the About page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:38:43 +0000 Subject: [Koha-bugs] [Bug 34424] Update release team on about page for new QA team member In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Katrin Fischer --- Self SO and directly for QA team review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:53:44 +0000 Subject: [Koha-bugs] [Bug 31029] ILL request ID in ILL history table should link to the ILL request if permissions allow for it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Confirmed, this works now: http://localhost:8081/cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:57:00 +0000 Subject: [Koha-bugs] [Bug 35184] New: Consolidate UNIMARC value builders for 100, 124, 125, 125 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35184 Bug ID: 35184 Summary: Consolidate UNIMARC value builders for 100, 124, 125, 125 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It looks like all these plugins do the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:57:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:57:34 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #8 from Katrin Fischer --- (In reply to Julian Maurice from comment #7) > (In reply to Katrin Fischer from comment #4) > > This works, but doesn't really seem to make sense. > > It's not linked by default anywhere and it uses the template of UNIMARC 100. > > Looking at the definition of 125 doesn't clear things up either. > > (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) > > Can this issue be moved to another bug report ? This is blocking bug 30975 > and the patch doesn't change anything functionally Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:58:06 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:58:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:58:09 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146789|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 158045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158045&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:59:24 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 --- Comment #6 from Katrin Fischer --- (In reply to Julian Maurice from comment #5) > (In reply to Katrin Fischer from comment #4) > > Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look > > like that in the manual. Any hints? > Can this issue be moved to another bug report ? This is blocking bug 30975 > and the patch doesn't change anything functionally Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:59:49 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 15:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 14:59:51 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146792|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 158046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158046&action=edit Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:02:16 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:04:20 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #24 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #23) > My current thought would be: I do not oppose this as a workaround with > commitment to follow up and improve. Hi Marcel, what would you ask for as follow-up/improvements here in order to pass? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:09:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:09:18 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #25 from Alex Buckley --- (In reply to Katrin Fischer from comment #24) > (In reply to Marcel de Rooy from comment #23) > > My current thought would be: I do not oppose this as a workaround with > > commitment to follow up and improve. > > Hi Marcel, what would you ask for as follow-up/improvements here in order to > pass? Hi Katrin and Marcel, Thanks for your replies. Yes, Marcel if you wouldn't mind noting what you would want as follow-ups/improvements here that would be helpful so we can raise them with our sponsoring library. Thanks so much, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:15:22 +0000 Subject: [Koha-bugs] [Bug 35185] New: Remove is_html flag from sample notices for text notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Bug ID: 35185 Summary: Remove is_html flag from sample notices for text notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have a few notices that are not formatted using HTML tags, but are still marked as "is_html". This will cause issues with line breaks. Example: - module: members code: 2FA_OTP_TOKEN branchcode: "" name: "two-authentication step token" is_html: 1 title: "Two-authentication token" message_transport_type: email lang: default content: - "Dear [% borrower.firstname %] [% borrower.surname %] ([% borrower.cardnumber %])" - "" - "Your authentication token is [% otp_token %]." - "It is valid one minute." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:23:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:23:33 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:23:35 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #1 from Katrin Fischer --- Created attachment 158047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158047&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY * WELCOME We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:24:15 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:24:15 +0000 Subject: [Koha-bugs] [Bug 34704] Print templates are formatted incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 [Bug 35185] Remove is_html flag from sample notices for text notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:24:21 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:26:36 +0000 Subject: [Koha-bugs] [Bug 35186] New: Remove html tags from sample notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Bug ID: 35186 Summary: Remove html tags from sample notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Blocks: 34704 HTML notices don't require that we explicitly add tags. We have 2 notices where these are included in the sample notices and should be removed: PASSWORD_RESET STAFF_PASSWORD_RESET Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:26:36 +0000 Subject: [Koha-bugs] [Bug 34704] Print templates are formatted incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 [Bug 35186] Remove html tags from sample notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:26:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:26:41 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:47:29 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:47:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:47:32 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #1 from Katrin Fischer --- Created attachment 158048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158048&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 16:55:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 15:55:13 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #2 from Katrin Fischer --- The WELCOME notice needs to be fixed to be proper HTML as it includes a link to the catalog. Removing from patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:01:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:01:04 +0000 Subject: [Koha-bugs] [Bug 35187] New: Fix line breaks in some HTML notices, including WELCOME Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Bug ID: 35187 Summary: Fix line breaks in some HTML notices, including WELCOME Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Blocks: 34704 When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:01:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:01:04 +0000 Subject: [Koha-bugs] [Bug 34704] Print templates are formatted incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 [Bug 35187] Fix line breaks in some HTML notices, including WELCOME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:01:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:01:18 +0000 Subject: [Koha-bugs] [Bug 35018] Welcome notice contains just a bit of HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35018 --- Comment #2 from Katrin Fischer --- I'll fix this as part of bug 35187 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:01:30 +0000 Subject: [Koha-bugs] [Bug 35018] Welcome notice contains just a bit of HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 35187 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:01:30 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Katrin Fischer --- *** Bug 35018 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:24:13 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:24:15 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 --- Comment #2 from Katrin Fischer --- Created attachment 158049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158049&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:25:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:25:03 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158049|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 158050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158050&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 17:26:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 16:26:59 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 158051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158051&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 19:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 18:19:04 +0000 Subject: [Koha-bugs] [Bug 35184] Consolidate UNIMARC value builders for 100, 124, 125, 125 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35184 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 21:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 20:56:16 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 21:57:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 20:57:12 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Aleisha Amohia --- Hi Kelly, I think you may have been seeing that message if you forgot to apply the patches from Bug 33478 first. Bug 33478 now needs to be rebased so will update when this patchset can be tested again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:13:44 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:13:47 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158041|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 158052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158052&action=edit Bug 34520: Fix FK for item_groups in reserves for new installations There was a discrepancy between the database update for reserves and the kohastructure.sql definition. This makes sure that the FK is always "ON DELETE SET NULL". To test: * Before applying this path * sudo koha-mysql kohadev * show create table reserves; CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE * Apply patch * Run database update * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE * reset_all (create a new database) * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:21:49 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:21:51 +0000 Subject: [Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158051|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 158053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158053&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:22:24 +0000 Subject: [Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #27 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #25) > (In reply to Martin Renvoize from comment #23) > > I had a look to see if there was any obvious way to get the instance name or > > track up to find the parent PID so we could call the HUP call mentioned > > above.. but I failed so far. > > Is a SIGHUP on all starmans running on a large shared hosting server a > paralyzing load? On the occasional plugin install/upgrade/uninstall. If you ran ./misc/devel/install_plugins.pl against all instances, it would be a paralyzing load on a large shared hosting server, yes. If it was just on a web upload or a single install for ./misc/devel/install_plugins.pl then it should be fine since it would just be restarting 1 starman master process. Certainly something to be careful with... I'm a bit apprehensive about giving a web user the ability to restart Starman. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:30:08 +0000 Subject: [Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #24 from David Cook --- (In reply to Jonathan Druart from comment #22) > Why do you want to remove C4::Context from updatedatabase? What would be the > gain? While I don't directly accuse C4::Context in bug 34088, it is one reason for slowness when running updatedatabase.pl against a large number of instances. Philippe, you might find that bug interesting. That one isn't for the memory footprint per se but rather speed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:39:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:39:06 +0000 Subject: [Koha-bugs] [Bug 27236] Package PO translation files separately to koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27236 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #11 from David Cook --- *** This bug has been marked as a duplicate of bug 35174 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:39:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:39:06 +0000 Subject: [Koha-bugs] [Bug 35174] Remove .po files from the codebase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #1 from David Cook --- *** Bug 27236 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:47:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:47:56 +0000 Subject: [Koha-bugs] [Bug 34704] Print templates are formatted incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #27 from Katrin Fischer --- I wanted to check the 'size' of this problem a bit more and did some testing. And it's not as bad as one would think: I tested the HTML notices especially and the results are interesting: 1) Slips: use explicit line breaks When a slip template is printed in the browser, only br and other block elements will cause a line break. I fixed some of our sample notices on bug 35187. 2) E-mail notices: use explicit line breaks When an email is sent in HTML format, only br and other block elements will cause a line break. I fixed the WELCOME notice also on bug 35187. 3) Print notices with gather_print_notices and --html: implicit line breaks ------------ Note that we have a known display bug on the notices tab: bug 30287. It shows implicit line breaks, not reflecting how the actual email will look later. ----------- (In reply to Martin Renvoize from comment #24) > OK, I see you're points now. > > This was meant to be "least invasive", but I do agree it would be nice to > drop it entirely and require proper HTML throughout for these notices. > > The challenge will be to write a DB update that looks at all the existing > notices and fixes them for all current html notices to include the breaks. We have never used the --html option on this job so I can't tell about how widely it would be used. I am not sure it's worth messing with the existing notices. * If you have a working email template that is used as a fallback for print, it will definitely add unnecessary/additional line breaks. * So only explicit print layouts that use HTML could be affected negatively. I'd like to avoid a system preference for this inconsistent behavior... but could a command line switch for 'implicit_line_breaks' help some? > Also, we'd need to update all the existing default notices for install. It's not as big an issue as one would think. I already did it: I fixed all HTML notices in the 3 bugs dependent on this one: 35185, 35186, 35187 With these 3 bugs I believe we can consider the sample notices fixed and improved. It helps that most our notices are still plain text (is_html: 0) > This is all a much larger job that we were expecting to undertake here.. > worthwhile I suppose, but I'm not sure where I'm going to find funding for > that extra time. We can have this go in as is, but I believe removing would be better instead of changing the output somewhat arbitrarily. Maybe we should just "bite the bullet" here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 29 23:51:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 22:51:51 +0000 Subject: [Koha-bugs] [Bug 34596] Items in transit should not show up in the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #3 from Katrin Fischer --- Any update on this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:05:15 +0000 Subject: [Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Katrin Fischer --- We should definitely add these to sysprefs.sql. I feel like we used to have an automated test or something in the QA script to catch these, but couldn't find it. Joubu, do you know maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:07:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:07:15 +0000 Subject: [Koha-bugs] [Bug 32980] Checkouts for guarantees are not shown if patron also has a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32980 --- Comment #20 from Katrin Fischer --- (In reply to Katrin Fischer from comment #19) > Hm, I can double check the OPAC behaviour maybe. But I think having > different behaviour for staff and OPAC is also at least confusing. I didn't get back to test this one yet. I am happy to have someone else take the lead here and won't block any decision made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:10:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:10:42 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:10:45 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158048|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 158054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158054&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:11:27 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #3 from Katrin Fischer --- Thanks David :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:21:58 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes unnecessary release notes| | tags in two | |email notices: | |* | |PASSWORD_RESET | |* | |STAFF_PASSWORD_RESET | |These | |notices are only updated in | |new installations, for | |existing installation | |manually change the | |notices. CC| |david at davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. After applying the patch, ran reset_all, so that the notices are updated. 2. Needed to set the OpacResetPassword and KohaAdminEmailAddress system preference. OpacResetPassword required for Patron account > More > Send password reset option to appear. 3. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:31:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:31:11 +0000 Subject: [Koha-bugs] [Bug 34428] Update database creates a wrong table transport_cost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > Bug 23995 removed it from kohastructure.sql but still exists in > updatedatabase.pl That's not great... right? It's this update here, still in updatedatabase: $DBversion = "3.09.00.037"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('UseTransportCostMatrix',0,'Use Transport Cost Matrix when filling holds','','YesNo')"); $dbh->do("CREATE TABLE `transport_cost` ( `frombranch` varchar(10) NOT NULL, `tobranch` varchar(10) NOT NULL, `cost` decimal(6,2) NOT NULL, `disable_transfer` tinyint(1) NOT NULL DEFAULT 0, CHECK ( `frombranch` <> `tobranch` ), -- a dud check, mysql does not support that PRIMARY KEY (`frombranch`, `tobranch`), CONSTRAINT `transport_cost_ibfk_1` FOREIGN KEY (`frombranch`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `transport_cost_ibfk_2` FOREIGN KEY (`tobranch`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8"); print "Upgrade to $DBversion done (creating `transport_cost` table; adding UseTransportCostMatrix systempref, in circulation)\n"; SetVersion($DBversion); } Should we fix and try to drop the CHECK in a database update? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 00:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Oct 2023 23:32:57 +0000 Subject: [Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Katrin Fischer --- 22.11 is the LTS... it would be great to get some help here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 01:11:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 00:11:02 +0000 Subject: [Koha-bugs] [Bug 34899] Circulation Rules: Only Allow "Local Use" Patron Category to Place Hold on Specific Branch Copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34899 --- Comment #4 from Katrin Fischer --- On first glance, I would have expected that the hold policy: >From home library: Only patrons from the item's home library may put this book on hold. would do the trick. I haven't tested, but mine would look a little different than the ones from your example: | 27 | NULL | NULL | BK | hold_fulfillment_policy | homebranch | | 28 | NULL | NULL | BK | returnbranch | homebranch | | 29 | NULL | NULL | BK | holdallowed | from_home_library | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 01:56:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 00:56:56 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 01:56:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 00:56:58 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158050|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 158055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158055&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 02:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 01:04:26 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |david at davidnind.com --- Comment #5 from David Nind --- All nice improvements! The only thing I noticed with the WELCOME notice, is that it displayed OK for me before the patch under Patrons > [Account] > Notices, but the email received was all on one line. After the patch, there are extra lines displayed under Patrons > [Account] > Notices, but the email received is now nicely formatted. I tried using

s instead of
s - no visible change for email message received, and only slightly better under Patrons > [Account] > Notices. Better that the email message that goes out is correct by default. I changed the bug assignee 8-) Testing notes (using KTD): 1. Add email to KohaAdminEmailAddress system preference. 2. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 3. WELCOME - Before the patch: . Displays OK for me if you view the message under Patron > [Account] > Notices . The email received (after running misc/cronjobs/process_message_queue.pl) is all on one line - After the patch: . There are extra lines if you view the message under Patron > Notices (not a showstopper for me - better that the email that goes out is correct) . The email received (after running misc/cronjobs/process_message_queue.pl) is now correctly formatted and looks great! . I tried using

tags instead of
tags: the email message comes through the same, the preview under Patrons > [Account] > Notices looks slightly better, but still has extra lines . Not sure what the best way to do this is! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 02:08:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 01:08:02 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 --- Comment #6 from David Nind --- (In reply to David Nind from comment #5) > The only thing I noticed with the WELCOME notice, is that it displayed OK > for me before the patch under Patrons > [Account] > Notices, but the email > received was all on one line. After the patch, there are extra lines > displayed under Patrons > [Account] > Notices, but the email received is now > nicely formatted. I tried using

s instead of
s - no visible change > for email message received, and only slightly better under Patrons > > [Account] > Notices. Better that the email message that goes out is correct > by default. Please ignore these comments - just read the comments for the other bugs to address/look at this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 02:20:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 01:20:27 +0000 Subject: [Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 02:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 01:20:30 +0000 Subject: [Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158022|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 158056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158056&action=edit Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode This fixes a typo in the comment. To test: * Please check diff of the patch closely. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 02:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 01:22:38 +0000 Subject: [Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. To show the comments column for the table in the database: SHOW FULL COLUMNS FROM biblioitems; 2. To see the updated comments: apply the patch, reset_all, repeat step 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 07:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 06:44:46 +0000 Subject: [Koha-bugs] [Bug 12532] Copy guarantee email to guarantor (or redirect if guarantee has no email set) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #170 from Kati Sillgren --- Thanks for this new feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 08:13:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 07:13:04 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #60 from M --- > Don't use the asterisk - then it should work Huh, this behavior is good to know. Though I actually had all rules with filter "bulkmarcimport", only then changed the one for 942 to "*" just for a test (after noticing what I described)... > But there should be no difference for different fields. Do you have a second rule for 942 by chance? Not a second rule either. It was all somewhat strange to me too, I couldn't notice anything too special about this field when reading code... By the way, on an unrelated note, it'd be really nice to have this patchset and the dependent Bug 29440 merged for the next release soon, we want record updates from upstream central library, but it's only gonna work nicely if we can set the overlay rules while using the script... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 08:26:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 07:26:22 +0000 Subject: [Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 --- Comment #7 from Katrin Fischer --- (In reply to David Nind from comment #6) > (In reply to David Nind from comment #5) > > The only thing I noticed with the WELCOME notice, is that it displayed OK > > for me before the patch under Patrons > [Account] > Notices, but the email > > received was all on one line. After the patch, there are extra lines > > displayed under Patrons > [Account] > Notices, but the email received is now > > nicely formatted. I tried using

s instead of
s - no visible change > > for email message received, and only slightly better under Patrons > > > [Account] > Notices. Better that the email message that goes out is correct > > by default. > > Please ignore these comments - just read the comments for the other bugs to > address/look at this! Thx David! For the next one looking at this, what David describes is bug 30287. The notices tab doesn't distinguish between plain text and HTML notices correctly adding extra line breaks to the latter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:07:32 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Add a few missing foreign keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #25 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #23) > Generally the code looks good, and the dbrev is idempotent. > > One big concern, though - should all of the foreign keys be ON DELETE > CASCADE? With the exception of additional_fields, the field is nullable, and > when removing conflicts before applying the foreign key, the dbrev sets them > to null. Shouldn't the foreign key constraint do the same if the authorized > value is deleted? Good catch. (In reply to Katrin Fischer from comment #24) > I agree with Emily, I think we should set NULL and not delete on cascade > here. > > + 'additional_fields' => 'authorised_value_category', > + 'auth_subfield_structure' => 'authorised_value', > + 'auth_tag_structure' => 'authorised_value', > + 'borrower_attribute_types' => 'authorised_value_category', > + 'club_template_enrollment_fields' => > 'authorised_value_category', > + 'club_template_fields' => 'authorised_value_category', > + 'marc_tag_structure' => 'authorised_value', > > Especially the removals from the MARC bibliographic/authority data can lead > to data loss easily if we remove the tag and subfield definitions. Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:09:37 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #61 from M --- I ran another test and it does seem to be the case somehow still. Original record in Koha has fields 866 and 942 (the latter is Koha metadata, including required item type). The imported record has both of these fields missing. Both of these fields have exact same overlay rules setup up, the field ID being the only different thing between them. I did a dirty patch to the script to copy over field 942 from found record for matching, and only that seems to help... Weird thing, it'd be nice if someone else could try to reproduce this situation, maybe I'm doing something wrong, but I can't seem to spot what's the difference either... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:15:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:15:49 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #26 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #24) > (In reply to Marcel de Rooy from comment #23) > > My current thought would be: I do not oppose this as a workaround with > > commitment to follow up and improve. > > Hi Marcel, what would you ask for as follow-up/improvements here in order to > pass? Actually nothing here. See comment23. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:16:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:16:53 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #27 from Marcel de Rooy --- Back to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:17:54 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #28 from Marcel de Rooy --- (In reply to Alex Buckley from comment #25) > Yes, Marcel if you wouldn't mind noting what you would want as > follow-ups/improvements here that would be helpful so we can raise them with > our sponsoring library. Please reconstruct from earlier discussion. Not having this sharp right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:18:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:18:20 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #62 from Katrin Fischer --- (In reply to M from comment #61) > I ran another test and it does seem to be the case somehow still. Original > record in Koha has fields 866 and 942 (the latter is Koha metadata, > including required item type). The imported record has both of these fields > missing. Both of these fields have exact same overlay rules setup up, the > field ID being the only different thing between them. I did a dirty patch to > the script to copy over field 942 from found record for matching, and only > that seems to help... > > Weird thing, it'd be nice if someone else could try to reproduce this > situation, maybe I'm doing something wrong, but I can't seem to spot what's > the difference either... Could you post the rules from the database maybe? So we can make sure we set them up the same and it's not a display issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:18:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:18:54 +0000 Subject: [Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #20 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #19) > Regardless, as far a doing a simple signoff I can since the test plan is > just about no-regression checking. So here it is so it's possible to swap > roles with Marcel if they feel confident enough to pass QA. Sure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:48:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:48:47 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #63 from M --- "id","tag","module","filter","add","append","remove","delete" "1","942","source","bulkmarcimport","1","1","0","0" "2","967","source","bulkmarcimport","0","0","0","0" "3","852","source","bulkmarcimport","1","1","0","0" "4","866","source","bulkmarcimport","1","1","0","0" "6","003","source","bulkmarcimport","1","0","0","0" I initially had add+append set to 0, and I think setting them to 1 like 8xx was one of attempts at finding the root cause. Last few attempts were done with this exact settings, after changing the filter back to be the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:54:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:54:57 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:54:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:54:59 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157981|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 158057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158057&action=edit Bug 35074: Add patron relationship alias This patch adds the 'patron' relationship alias to the Acountline DBIx::Class schema. Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:55:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:55:01 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157982|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 158058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158058&action=edit Bug 35074: Use patron relationship alias This patch updates the existing Koha::Account::Line->patron accessor to use the new aliased 'patron' relation in the schema class Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:55:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:55:04 +0000 Subject: [Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157983|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 158059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158059&action=edit Bug 35074: Add support for category_code to writeoff_debts This patch adds support for passing category_code as a limiter for the writeoff_debts script. Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 09:56:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 08:56:59 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 --- Comment #24 from Marcel de Rooy --- (In reply to Julian Maurice from comment #23) > (In reply to Marcel de Rooy from comment #22) > > Which has its drawbacks of course ;) But yes. > > A big drawback in my opinion: asking everyone using Shibboleth to update > their configuration file, while there is a patch available that works and > don't require configuration changes. I don't understand. Will have another look. If it 'works', is the crux, yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:06:58 +0000 Subject: [Koha-bugs] [Bug 33685] We should display both backend and local status for ILL loan requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Pedro Amorim --- (In reply to Katrin Fischer from comment #1) > Is this a duplicate to bug 34431? Yes. Thanks! *** This bug has been marked as a duplicate of bug 34431 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:06:58 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #19 from Pedro Amorim --- *** Bug 33685 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:11:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:11:35 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Pedro Amorim --- *** This bug has been marked as a duplicate of bug 35095 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:11:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:11:35 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #10 from Pedro Amorim --- *** Bug 32783 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:11:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:11:56 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #11 from Pedro Amorim --- (In reply to Katrin Fischer from comment #9) > Is this a duplicate of bug 32783 now? Yes. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 10:12:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 09:12:37 +0000 Subject: [Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 --- Comment #8 from Pedro Amorim --- Cool! Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 11:30:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 10:30:51 +0000 Subject: [Koha-bugs] [Bug 34899] Circulation Rules: Only Allow "Local Use" Patron Category to Place Hold on Specific Branch Copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34899 --- Comment #5 from Steve, OSLRI, USA --- Hi Katrin, We are setup for "owning library rules". Therefore, unfortunately, the settings that you reference in your reply can only be set by default for all locations or by each location. Essentially, we can turn holds off or on for all borrower categories at a given location, but we can not give different permissions to different types of borrowers. It is interesting that under the heading "Default holds policy by item type" for a given owning library location, we can tweak those settings, but that there isn't similar functionality under the heading "Default checkout, hold policy by patron category". Perhaps the fix is to mirror the settings under those headings? In this case, that would be adding the following as configuration options under the "Default checkout, hold policy by patron category" heading: * hold_fulfillment_policy * holdsallowed * returnbranch Those do appear to be the settings that are both not possible for us to fully manage and necessary to tweak holds privileges for specific borrower categories when using owning library rules. Best, Steve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 11:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 10:44:51 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 11:48:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 10:48:57 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 11:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 10:48:59 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157768|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy --- Created attachment 158060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158060&action=edit Bug 31393: Koha::Config: handle the special case for 'content' attribute was wrongly parsed as { key => 'value' } whereas it should be { key => { content => 'value' } } The 'content' attribute is used in shibboleth config Test plan: 1 Run `prove t/Koha/Config.t` Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 11:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 10:52:12 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 --- Comment #26 from Marcel de Rooy --- Reading back, I saw that there was use of _content elsewhere instead of content. I do not really like the handling of 'content' in read_from_dom_node. This feels more like a hack. But I wont block it. We have some other exceptions in this code btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:02:56 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:02:58 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:01 +0000 Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:02 +0000 Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:04 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:06 +0000 Subject: [Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 --- Comment #27 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:08 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:10 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:12 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:14 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:15 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:17 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:19 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:21 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:22 +0000 Subject: [Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:24 +0000 Subject: [Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:26 +0000 Subject: [Koha-bugs] [Bug 35147] Add classes to Shibboleth text on OPAC login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:03:27 +0000 Subject: [Koha-bugs] [Bug 35147] Add classes to Shibboleth text on OPAC login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:12:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:12:00 +0000 Subject: [Koha-bugs] [Bug 34598] Error 500 is shown when ILL request is not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major QA Contact| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:16:23 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:16:42 +0000 Subject: [Koha-bugs] [Bug 35027] Add holds to patron activity triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:36:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:36:44 +0000 Subject: [Koha-bugs] [Bug 35112] [22.11] Return claims table showing on all patron tabs and not behaving as normal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > I have both pages with/without patch. But I am overlooking it ? > What is strange exactly? I am seeing it now. Confirm that it is resolved under 22.11. Should we change status or alert the RMaint ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:38:16 +0000 Subject: [Koha-bugs] [Bug 35112] [22.11] Return claims table showing on all patron tabs and not behaving as normal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:39:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:39:56 +0000 Subject: [Koha-bugs] [Bug 34227] Add persistent selections and batch operations to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 158061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158061&action=edit Bug 34227: (follow-up) Adjust selenium tests This patch adjusts the selenium tests to address the renamed ID for the elements. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:45:06 +0000 Subject: [Koha-bugs] [Bug 35188] New: force_checkout permission can override all blocks on a patron account but only shows when they are restricted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Bug ID: 35188 Summary: force_checkout permission can override all blocks on a patron account but only shows when they are restricted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When the force_checkout permission was added, the script circulation.pl was altered to allow overriding any block on the patron's account (expired, gonenoaddress, etc) The last follow-up on that bug, however, moved the button to override into the section for restrictions, limiting the scope for users to the case where a patron had a debarment. To recreate: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions I think the intent here should be that 'force_checkout' allows overriding any of the statuses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:45:07 +0000 Subject: [Koha-bugs] [Bug 34692] Koha Manual Link for latest manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34692 --- Comment #2 from Aude Charillon --- Yes! Thank you Katrin; you got there before me :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:45:59 +0000 Subject: [Koha-bugs] [Bug 35112] [22.11] Return claims table showing on all patron tabs and not behaving as normal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 --- Comment #11 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #7) > > I have both pages with/without patch. But I am overlooking it ? > > What is strange exactly? > > I am seeing it now. Confirm that it is resolved under 22.11. > Should we change status or alert the RMaint ? I was wondering the same thing, hoping the CC and the keyword together will do the trick now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:49:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:49:57 +0000 Subject: [Koha-bugs] [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:49:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:49:59 +0000 Subject: [Koha-bugs] [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 --- Comment #1 from Nick Clemens --- Created attachment 158062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158062&action=edit Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:50:14 +0000 Subject: [Koha-bugs] [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de Depends on| |643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 [Bug 643] Allow override of 'debarred' status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:50:14 +0000 Subject: [Koha-bugs] [Bug 643] Allow override of 'debarred' status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:51:21 +0000 Subject: [Koha-bugs] [Bug 34588] Override patron expired at checkout. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34588 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 35188 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:51:21 +0000 Subject: [Koha-bugs] [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crose at mercantilelibrary.com --- Comment #2 from Nick Clemens --- *** Bug 34588 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:55:03 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #64 from Katrin Fischer --- (In reply to M from comment #63) > "id","tag","module","filter","add","append","remove","delete" > "1","942","source","bulkmarcimport","1","1","0","0" > "2","967","source","bulkmarcimport","0","0","0","0" > "3","852","source","bulkmarcimport","1","1","0","0" > "4","866","source","bulkmarcimport","1","1","0","0" > "6","003","source","bulkmarcimport","1","0","0","0" > > I initially had add+append set to 0, and I think setting them to 1 like 8xx > was one of attempts at finding the root cause. Last few attempts were done > with this exact settings, after changing the filter back to be the same. David, can you maybe help? Is this related to the reported bug or maybe should be moved elsewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 13:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 12:56:06 +0000 Subject: [Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:03:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:03:15 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:33:23 +0000 Subject: [Koha-bugs] [Bug 32551] API requests don't carry language related information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:34:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:34:01 +0000 Subject: [Koha-bugs] [Bug 19097] Koha to MARC mappings (Part 3): Correct remaining GetMarcFromKohaField and TransformMarcToKoha calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #6 from Marcel de Rooy --- Created attachment 158063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158063&action=edit Bug 19097: GetMarcSubfieldStructureFromKohaField - remove wantarray Replacing wantarray by a list parameter. Adding comment to calls where simply one return is assumed. Test plan: Look at results of git grep GetMarcSubfieldStructureFromKohaField Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:35:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:35:03 +0000 Subject: [Koha-bugs] [Bug 19097] Koha to MARC mappings (Part 3): Correct remaining GetMarcFromKohaField and TransformMarcToKoha calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Marcel de Rooy from comment #3) > > > Looks like bug 30813 did most of the work now. > > > > But not all. Will make it more concrete. > > ? First patch addresses sub GetMarcSubfieldStructureFromKohaField. Still another follow-up needed for GetMarcFromKohaField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:39:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:39:00 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140810|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Comment on attachment 140810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140810 Bug 30975: Fix framework plugins on cloned fields/subfields Patch obsoleted as it was pushed in bug 33744 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:39:53 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146146|0 |1 is obsolete| | Attachment #146817|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 158064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158064&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:40:53 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #50 from Julian Maurice --- Patch rebased on master. All dependencies have been pushed. It's ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:57:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:57:02 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34913 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:58:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:58:49 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 --- Comment #3 from Caroline Cyr La Rose --- I did some tests with directives and "admonitions" (this sounds so bad... like we did something wrong but anyway, it's what it's called). This is what the code looks like Tests for version notes .. Admonition:: Version note This feature|button|option appears in version 23.05 .. Warning:: This feature|button|option was removed in version 23.05 .. Warning:: This feature|button|option is deprecated as of version 23.05. Use :ref:`YXZ ` instead. .. Admonition:: Version note This feature|button|option was removed in version 23.05 .. Admonition:: Version note This feature|button|option was moved to :ref:`wherever ` in version 23.05 And this is what it looks like once generated https://snipboard.io/fw3eX0.jpg I added some css to custom.css to change the colour if the title of the admonition is "Version note" .rst-content .admonition-version-note { background: #dffcd7; } .rst-content .admonition-version-note .admonition-title { background: #4a9b32; } This is the result https://snipboard.io/THSpGn.jpg Open to comments/suggestions - Is "Version note" ok as a title? - Do we prefer the green box or do we keep the blue (same as the Notes) - Anything else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 14:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 13:59:24 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #47 from Katrin Fischer --- Testing here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:02:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:02:23 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 --- Comment #4 from Caroline Cyr La Rose --- Created attachment 158065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158065&action=edit Screenshot of generated version notes This is the rendering without the custom css. The boxes are the same colour as the "Notes", but the title says "Version note" instead. It is the same as https://snipboard.io/fw3eX0.jpg I juste wanted to have the image attached to the bug just in case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:04:20 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 --- Comment #5 from Caroline Cyr La Rose --- Created attachment 158066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158066&action=edit Screenshot of generated version notes with custom css This is the rendering *with* the custom css. The boxes are green (I took the same green as the sidebar title part, but open to change it if you have a strong preference for something else) It is the same as https://snipboard.io/THSpGn.jpg I just wanted to have the image attached to the bug just in case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:13:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:13:38 +0000 Subject: [Koha-bugs] [Bug 34955] One Koha manual (to rule them all) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34955 --- Comment #3 from Caroline Cyr La Rose --- I tested some ways to add notes about the versions in bug 29712 Let me know if you have any comments or suggestions... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:30:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:30:43 +0000 Subject: [Koha-bugs] [Bug 35189] New: Itemtypes SVG icons should be limited in height/width Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Bug ID: 35189 Summary: Itemtypes SVG icons should be limited in height/width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 158067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158067&action=edit Screenshot Steps to reproduce the issue: 1. On Staff interface, on Administration > Item types, modify any item 2. Choose an SVG image as a remote image for an Item type, for eg https://raw.githubusercontent.com/FortAwesome/Font-Awesome/afecf2af5d897b763e5e8e28d46aad2f710ccad6/svgs/solid/bolt.svg Save changes. When listed on itemtypes.pl the icon is not too big, but if you edit again the itemtype (using above SVG, more than 1200px width). This also impact at some degree on Advanced search (staff and OPAC, search.pl, opac-search.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:31:28 +0000 Subject: [Koha-bugs] [Bug 35189] Itemtypes SVG icons should be limited in height/width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:35:46 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #18 from Tomás Cohen Arazi --- Working on follow-ups for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:39:41 +0000 Subject: [Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:46:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:46:34 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:46:38 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #5 from Pedro Amorim --- Created attachment 158068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158068&action=edit Bug 19605: Add 'ill_backend' plugin category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:46:42 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #6 from Pedro Amorim --- Created attachment 158069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158069&action=edit Bug 19605: Update expandTemplate to expand_template method name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:46:44 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #7 from Pedro Amorim --- Created attachment 158070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158070&action=edit Bug 19605: Add support for ILL backends as plugins This is designed to maintain existing functionality of loading ILL backends through the backend_dir config (default Koha/Illbackends/). A check for a plugin of a given backend name takes precedence over a backend of the same name loaded the old way through backend_dir, this means that if this happens, the backend plugin is used and NOT the backend present in backend_dir. Old backend_dir backends AND new backend plugins coexist. Test plan, k-t-d: 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install the plugin ILL backend example .kpz located at: https://github.com/ammopt/koha-ill-backend-plugin/releases/tag/1.0.0 3) koha-plack --restart kohadev 4) Visit ILL requests: /cgi-bin/koha/ill/ill-requests.pl 5) Click "+ New ILL request". Notice it lists 'FreeForm' and 'PluginBackend' 6) Click 'PluginBackend'. Enter a '123' in pubmedid, '42' in cardnumber and pick a library. Click 'Marke request' 7) Notice the request is created successfully. 8) Visit plugins: /cgi-bin/koha/plugins/plugins-home.pl 9) Click "View plugin by class". Pick "ill backend plugins". Notice the correct plugin is listed. 10) Click "configure" on the ILL backend plugin. Notice it's a normal plugin configuration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:48:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:48:05 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #8 from Pedro Amorim --- Instructions on converting old ILL backend into a plugin can be found at the PluginBackend sample plugin https://github.com/ammopt/koha-ill-backend-plugin: - Create your plugin, copy the contents from your old ILL backend into the plugin folder. - Copy the code from your old Base.pm file into the plugin file named after the plugin. - Rename the old backend 'metadata' method to 'backend_metadata'. - Rename the old backend 'new' method to 'new_backend'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:49:58 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #9 from Pedro Amorim --- My suggestions is that we support both ways of loading ILL backends (old backend_dir way and this new plugin way) for a while (1 year? 2 years?) and after that period we deprecate the old backend_dir way of doing things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:52:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:52:02 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer --- I am sorry, but my testing didn't go as well as I had hoped for :( Problems: 1) One of the commit messages needs to be fixed 2) When there is no barcode, it appears as 'null' in the column 3) 'Host records' column should not be available, when EasyAnalytics is turned off. 4) Table configuration doesn't appear to be used as expected. I checked: Catalog > holdings_table has only holdings_issues and holdings_renewals hidden by default. But the table keeps appearing with only a minimum number of columns and a lot of them hidden. Unfortunately the hidden column also includes much neded ones like callnumber. Any changes I make don't seem to stick. 5) SpineLabelShowPrintOnBibDetails: the callnumber print on longer opens in small size modal. This also has the effect, that there is no way to close this window without printing. 6) The status column is no longer sortable. It's sortable in 22.11 and works well there. Alos: I can't activate a filter for this column and the normal filter doesn't find the contents of the column. There is no way to find the 'checked out' or 'ordered' items in that list. 7) When an item is checked out, there is no longer a link to the patron's account. 8) hidepatronname doesn't seem to have any effect. 9) Using the single search box on top of the table: "checked" doesn't find the checked out items. In 22.11 that works. 10) StaffDetailItemSelection: when disabled, not only the checkboxes are gone, but I can also no longer activate the column specific filters. In 22.11 this is still possible when the select feature is disabled. Notes/Questions: 1) Currently some column only show when there is data for them, like course reserves. this is very helpful in preserving space, but doesn't seem to be the case anymore. 2) Right now we see all items immediately in the table, one the page has loaded. Now we only see the first 20. Libraries might feel this is a too low default setting. It would be great if we could have that configurable in table settings from the start. Works well: 1) Date sorting with dd.mm.yyyy 2) Checkboxes between pages are preserved. 3) SeparateHoldings*: works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:52:59 +0000 Subject: [Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #27 from Nick Clemens --- Created attachment 158071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158071&action=edit Bug 33960: (follow-up) Add to description to highlight that deleted limits query options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:53:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:53:38 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:53:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:53:56 +0000 Subject: [Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:54:16 +0000 Subject: [Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 15:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 14:54:19 +0000 Subject: [Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157438|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim --- Created attachment 158072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158072&action=edit Bug 35107: Show type disclaimer value and date in request details Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Set ILLModuleDisclaimerByType system preference , visit: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow 3) Copy the example code, click the 'Click to edit' link to open the text area, and paste the example yaml: all: text: |

HTML title

This is an HTML paragraph

This is another HTML paragraph

av_category_code: YES_NO article: text: copyright text for all article type requests av_category_code: YES_NO bypass: 1 4) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put'9780822370451' in ISBN, put '42' in the cardnumber, and pick a library 6) You should now be in the type disclaimer stage, click 'Submit' 7) Notice the disclaimer value and date are displayed under 'Details from supplier' 8) Click the top 'Switch provider' button and pick BLDSS 9) You should get one result, click the 'Request BLL01018665793' link to finish the migration 10) You should now be in the ILL table, click the request that was just migrated to BLDSS 11) Notice the type disclaimer information is no longer visible 12) Apply patch, restart plack: koha-plack --restart kohadev 13) Refresh the BLDSS request, the information should now be visible in the 'Request details' section Signed-off-by: Richard Bridgen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:00:23 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m CC| |katrin.fischer at bsz-bw.de, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:00:45 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #10 from Katrin Fischer --- (In reply to Pedro Amorim from comment #9) > My suggestions is that we support both ways of loading ILL backends (old > backend_dir way and this new plugin way) for a while (1 year? 2 years?) and > after that period we deprecate the old backend_dir way of doing things. That sounds like a good plan. We should make sure the deprecation warning is well visible, in the Relase notes and on the wiki page and maybe the manual? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:00:59 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158011|0 |1 is obsolete| | --- Comment #23 from Lucas Gass --- Created attachment 158073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158073&action=edit Bug 27992: Call AddReturn on stats patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared. 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. Item is checked in. 8. Set BlockReturnOfLostItems to Block. 9. Have a checkout to another patron then mark it as lost. 10. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 12. Conform the item remains on the patron's account. 13. Turn off BlockReturnOfLostItems, check out the same item to the Statistical Patron. You should see a message "Item was lost, now found." 14. Conform the item was actually checked in. 15. Set BlockReturnOfWithdrawnItems to Block. 16. Have a checkout to another patron then mark it as withdrawn. 17. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 18. Conform the item remains on the patron's account. 19. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 20. Conform the item was actually checked in. 21. Have an item on a regular patron account that has a hold on it. 22. Check it out to the Statistical Patron 23. See the message "Item on hold, please checkin." 24. Have an item on a regular patron account that has a claim return on it. 25. Checkit it out to the Statistical Patron. 26. See the message "Item claimed returned, please checkin." 27. Have an item on a regular patron account that has been recalled. 28. Checkit it out to the Statistical Patron. 29. See the message "Item can fill a recall, please checkin." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:04:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:04:58 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #17) > I made some suggestions on the wiki page you added: > https://wiki.koha-community.org/wiki/Item_types_endpoint_RFC > > From looking at the other endpoints I concluded: > * we usually don't use abbreviations > * we use underscores to separate words > * items endpoint uses not_for_loan_status - so we should use: not_for_loan Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:05:48 +0000 Subject: [Koha-bugs] [Bug 35190] New: additional_fields table should allow null values for authorised_value_category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 Bug ID: 35190 Summary: additional_fields table should allow null values for authorised_value_category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: emily.lamancusa at montgomerycountymd.gov Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org Blocks: 29390 When creating an Additional Field in the staff interface, the UI explicitly allows the Additional Field not to be linked to an authorized value. However, the database doesn't allow NULL values for authorised_value_category in the additional_fields table. Instead, an empty string is inserted into the database if the user chooses not to link an authorized value. This is not good practice, and does not allow a foreign key constraint to be properly implemented. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 [Bug 29390] Authorised values: Add a few missing foreign keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:05:48 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Add a few missing foreign keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 [Bug 35190] additional_fields table should allow null values for authorised_value_category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:08:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:08:43 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Add a few missing foreign keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #26 from Emily Lamancusa --- Hmm, looking more at additional_fields, it doesn't make sense that its authorised_value_category field isn't nullable like the other tables. The UI explicitly has "None" as the default option when selecting an authorized value category. Seems to me like the best approach would be to make that nullable, then remove the special handling for additional_fields on this bug and simply make everything ON DELETE SET NULL. I filed bug 35190 for that and will upload a patch shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:10:35 +0000 Subject: [Koha-bugs] [Bug 35112] [22.11] Return claims table showing on all patron tabs and not behaving as normal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:21:34 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:21:36 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #10 from Owen Leonard --- Created attachment 158074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158074&action=edit Bug 34900: Simplify text of about page license information This patch simplifies the language describing third-party libraries and their licenses so that translation are not so complicated. The patch also removes information about some assets which are no longer part of Koha. The license information now lists only the library name, version (if possible) and license. To test, apply the patch and go to the about page in the staff interface. Open the "Licenses" tab and check the content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:32:48 +0000 Subject: [Koha-bugs] [Bug 35159] New edit item limitation to library groups also prevents batch modification of items owned by other libraries. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 Rudy Hinojosa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudy.hinojosa at lifeafter.sol | |utions --- Comment #1 from Rudy Hinojosa --- This bug is also breaking the plugin https://github.com/bywatersolutions/koha-plugin-batch-permissions-modifier Staff members that are not super librarians will not be able to edit their own items. A temporary fix is to change the permissions template for normal staff members to Super Librarian roles. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:35:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:35:30 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157979|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 158075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158075&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:35:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:35:33 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #10 from Katrin Fischer --- Created attachment 158076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158076&action=edit Bug 33664: (follow-up) Move check for 'received' to include Modify link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:35:35 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #12 from Pedro Amorim --- Hi Caroline, thank you for the mapping info. I believe, ideally, we'd stick to koha fields instead of direct MARC fields, as this way we're able to use TransformKohaToMarc and I think that handles the MARC flavour for us. Inserting MARC fields here directly may open a can of worms in regards to MARC flavour. I'm not sure here. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:41:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:41:11 +0000 Subject: [Koha-bugs] [Bug 35144] 'Required' mention for patron attributes is not red in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35144 --- Comment #1 from Caroline Cyr La Rose --- I noticed that if the attribute is a text field, the "Required" flag is aligned on the left. But if the attribute is a drop-down, the "Required" flag is correctly aligned with the field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:45:30 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:45:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:45:33 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158075|0 |1 is obsolete| | Attachment #158076|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 158077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158077&action=edit Bug 33664: Add ability to cancel order lines in closed baskets At the moment it's only possible to cancel order lines while the basket is still open or from the pending orders page during processing a shipment. The latter requires you to add a shipment and fake an invoice. To make things easier we want to optionally allow cancelling order lines in closed baskets from the basket summary page. Before applying the patch: 1) Set up data * Create a new basket * Create a few order lines, at least 3 * Close the basket * Receive shipment and receive one order line 2) Verify current behaviour * On basket summary page: you cannot cancel while the basket is closed * On the pending orders page you can cancel Apply patch, run database update, restart_all 3) Verify new behaviour * Verify that nothing has changed on pending orders and basket summary * Switch new system preference CancelOrdersInClosedBaskets to "Allow" * Verify that pending orders hasn't changed a bit * Verify that you now can cancel your order lines in the closed basket Exception: the received order line should not be cancellable Test anything else that you think might make sense ;) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:45:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:45:35 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #12 from Nick Clemens --- Created attachment 158078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158078&action=edit Bug 33664: (follow-up) Move check for 'received' to include Modify link Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:45:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:45:49 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:46:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:46:13 +0000 Subject: [Koha-bugs] [Bug 35159] New edit item limitation to library groups also prevents batch modification of items owned by other libraries. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 --- Comment #2 from Katrin Fischer --- (In reply to Rudy Hinojosa from comment #1) > This bug is also breaking the plugin > https://github.com/bywatersolutions/koha-plugin-batch-permissions-modifier > > Staff members that are not super librarians will not be able to edit their > own items. A temporary fix is to change the permissions template for normal > staff members to Super Librarian roles. Please file this with the plugin maintainers, they probably need to adapt the plugin, not vice versa. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 16:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 15:54:32 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #13 from Katrin Fischer --- kohafields could be very limiting, there is a lot of things we don't have fields in biblio/biblioitems for or no good default mappings. Example: Date the monograph is first published in print: date_monograph_published_print = 008/07-10 (not mapped to db) or 264$c (biblio.copyrightdate); for books only? Without the 008 the date range search won't work for these records. Publication type: publication_type = 000/07 (m for monograph or s for serial), KBART only gives those two options even if there is an extensive list in Koha Having the right material type would be very helpful, but probably is also not covered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:05:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:05:56 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:05:58 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158054|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 158079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158079&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:06:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:06:08 +0000 Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:10:45 +0000 Subject: [Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #14 from Caroline Cyr La Rose --- I'm in favour of mapping all the fields to the marc record but I understand that it is not ideal from the code standpoint. I just think it's a shame that staff would enter all this information in this form and not have it anywhere else than in the ERM module. If they want to have it also in the catalog, they would have to enter it twice. Could we maybe flip it around and enter the information in a cataloging framework and map that to the kbart form? I want to mention however that I have never managed electronic resources in any ILS when I worked in a library and so far none of our clients have this (we update them only on .05.04 or .05.05, they will be getting 23.05.05 later this fall) so I don't really have any "real world" use experience... Please take my comments with a grain of salt... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:12:26 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:12:28 +0000 Subject: [Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158052|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 158080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158080&action=edit Bug 34520: Fix FK for item_groups in reserves for new installations There was a discrepancy between the database update for reserves and the kohastructure.sql definition. This makes sure that the FK is always "ON DELETE SET NULL". To test: * Before applying this path * sudo koha-mysql kohadev * show create table reserves; CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE * Apply patch * Run database update * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE * reset_all (create a new database) * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:16:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:16:36 +0000 Subject: [Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:16:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:16:38 +0000 Subject: [Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158056|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 158081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158081&action=edit Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode This fixes a typo in the comment. To test: * Please check diff of the patch closely. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:18:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:18:16 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157915|0 |1 is obsolete| | Attachment #157976|0 |1 is obsolete| | Attachment #157977|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi --- Created attachment 158082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158082&action=edit Bug 34008: Add REST endpoint for list of itemtypes Test plan: * Enable the system preference RESTBasicAuth * curl -s --request GET http://kohadev-intra.mydnsname.org:8081/api/v1/itemtypes should give 401 Unauthorized * curl -s -u koha:koha --request GET http://kohadev-intra.mydnsname.org:8081/api/v1/itemtypes should produce JSON-list of itemtypes * curl -s -u koha:koha --header "x-koha-embed: translated_descriptions" --request GET http://kohadev-intra.mydnsname.org:8081/api/v1/itemtypes should include the field translated_descriptions containing the translated descriptions, if any Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] perltidy -b t/db_dependent/api/v1/itemtypes.t # Resolve bad score of 44 [EDIT] chmod 755 t/db_dependent/api/v1/itemtypes.t [EDIT] perltidy -b Koha/REST/V1/ItemTypes.pm Lesson: Please run qa tools yourself and adjust accordingly? Edit (tcohen): I restored the item_type_translated_description.yaml file as the entire API was broken because of the lack of it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:18:19 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 158083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158083&action=edit Bug 34008: (QA follow-up) 'item_type_id' should be used Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:18:23 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 158084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158084&action=edit Bug 34008: Harmonize attribute names This patch harmonizes the attribute names with what is used for `items` and `checkouts` in terms of terminology. It also adapts the tests so they are less random failure-prone (they had a fixed value for the item type, which might make things explode if the chosen value already exists on the DB. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:18:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:18:42 +0000 Subject: [Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:32:54 +0000 Subject: [Koha-bugs] [Bug 35115] ERM - Potential MARC data loss when importing titles from list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:32:57 +0000 Subject: [Koha-bugs] [Bug 35115] ERM - Potential MARC data loss when importing titles from list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #7 from Pedro Amorim --- Created attachment 158085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158085&action=edit Bug 35115 [Alternative]: Skip Resource store logic if resource was imported from list This patch fixes the data loss issue when importing titles from a list of biblios. It does NOT fix the data loss issue when saving a title that is linked to a biblio, that will still caused data loss on the biblio. I believe store in Resource.pm is trying to do a couple things: 1) Updating Biblio when a title is saved, or 2) Adding a biblio when a title is created The problem is that it's updating the biblio when the title is created from an import list, as if new changes were made to the title and need to be reflected to the biblio. This is not the case, a title created from an imported list of biblios should have no business updating their respective biblio's MARC at that time. ---- The biblio MARC being updated when the title is saved through the edit form should perhaps be a different bug. Should all possible fields be updated on the biblio when saving the title? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:46:15 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128633|0 |1 is obsolete| | --- Comment #24 from Lucas Gass --- Created attachment 158086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158086&action=edit Bug 27992: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 17:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 16:46:26 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:09:32 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart --- (In reply to Katrin Fischer from comment #48) > I am sorry, but my testing didn't go as well as I had hoped for :( > > Problems: > 1) One of the commit messages needs to be fixed Two were kept for history, I removed them from the branch. > 2) When there is no barcode, it appears as 'null' in the column Fixed in "Bug 33568: Do not display 'null' when no barcode" > 3) 'Host records' column should not be available, when EasyAnalytics is > turned off. Fixed in "Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off" > 4) Table configuration doesn't appear to be used as expected. I checked: > Catalog > holdings_table has only holdings_issues and holdings_renewals > hidden by default. But the table keeps appearing with only a minimum number > of columns and a lot of them hidden. Unfortunately the hidden column also > includes much neded ones like callnumber. Any changes I make don't seem to > stick. The table is hiding empty columns. So if the x items displayed on the page do not have callnumber, then the column will be hidden, even if other pages have items with callnumber. Is that what you are seeing? See commit message "Bug 33568: Hide empty columns". It is what we are doing already on master, but here we don't want to fetch all the items to know if data exist for each each column... > 5) SpineLabelShowPrintOnBibDetails: the callnumber print on longer opens in > small size modal. This also has the effect, that there is no way to close > this window without printing. Fixed in "Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails" > 6) The status column is no longer sortable. It's sortable in 22.11 and works > well there. Alos: I can't activate a filter for this column and the normal > filter doesn't find the contents of the column. There is no way to find the > 'checked out' or 'ordered' items in that list. See commit message for "Bug 33568: Status" """ See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). """ > 7) When an item is checked out, there is no longer a link to the patron's > account. Fixed in "Bug 33568: Restore link to patron" > 8) hidepatronname doesn't seem to have any effect. I think this is a bug in js-patron-format.inc, it should be reported separately. > 9) Using the single search box on top of the table: "checked" doesn't find > the checked out items. In 22.11 that works. If we want that we need a filter at the top of the page. That should be a separate bug. > 10) StaffDetailItemSelection: when disabled, not only the checkboxes are > gone, but I can also no longer activate the column specific filters. In > 22.11 this is still possible when the select feature is disabled. Fixed in "Bug 33568: Restore column filters when StaffDetailItemSelection is off" > Notes/Questions: > 1) Currently some column only show when there is data for them, like course > reserves. this is very helpful in preserving space, but doesn't seem to be > the case anymore. "Preserving space"? See above. > 2) Right now we see all items immediately in the table, one the page has > loaded. Now we only see the first 20. Libraries might feel this is a too low > default setting. It would be great if we could have that configurable in > table settings from the start. It should be very easy to implement. I will do it when this reaches master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:26:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:26:14 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 --- Comment #1 from Emily Lamancusa --- Created attachment 158087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158087&action=edit Bug 35190: Set default NULL for authorised_value_category in additional_fields table To test: 1. Start KTD without this patch 2. In the Administration module, create an Additional Field with Authorized Value set to None 3. Create another Additional Field with Authorized Value set to an existing authorized value 4. Apply patch and updatedatabase 5. Access the database in the command line with koha-mysql kohadev 6. Select all rows from additional_fields 7. Confirm that the two Additional Fields from earlier have values of NULL and the correct authorized value, respectively, in their authorised_value_category fields. 8. reset_all to test new install 9. Access the database in the command line 10. Show the table structure for additional_fields and confirm that default for authorised_value_category is NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:26:15 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 --- Comment #2 from Emily Lamancusa --- Created attachment 158088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158088&action=edit Bug 35190: Adjust tests Test plan: prove t/db_dependent/Koha/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:26:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:26:17 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 --- Comment #3 from Emily Lamancusa --- Created attachment 158089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158089&action=edit Bug 35190: Adjust UI handling to avoid inserting an empty starting To test: 1. In the Administration module, create an Additional Field that is not linked to an authorized value 2. Create another Additional Field that is linked to an authorized value 3. Access the database in the command line (koha-mysql kohadev) 4. Select all from additional_fields 5. Confirm that each field correctly lists either the appropriate authorized value, or NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:27:11 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 --- Comment #4 from Emily Lamancusa --- Created attachment 158090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158090&action=edit Bug 35190: Adjust UI handling to avoid inserting an empty string To test: 1. In the Administration module, create an Additional Field that is not linked to an authorized value 2. Create another Additional Field that is linked to an authorized value 3. Access the database in the command line (koha-mysql kohadev) 4. Select all from additional_fields 5. Confirm that each field correctly lists either the appropriate authorized value, or NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:29:29 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158089|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:29:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:29:47 +0000 Subject: [Koha-bugs] [Bug 35190] additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:32:03 +0000 Subject: [Koha-bugs] [Bug 35191] New: Make entries per page configurable for items table on staff detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35191 Bug ID: 35191 Summary: Make entries per page configurable for items table on staff detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 33568 The new API driven items view defaults to 20 per page. This is a bit low, it would be great if it could be configurable to a higher value per the table configuration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:32:03 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35191 [Bug 35191] Make entries per page configurable for items table on staff detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 30 18:32:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Oct 2023 17:32:06 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > This works, but there are some bigger and smaller issues: > > 1) It produces an invalid HTML file, missing the html and body tags. If we > were to add them to the template, the template could no longer be properly > displayed in Koha. That's why I feel it would be better to add those on > export. It's created with a .html ending, so I assume that is the use case. This feature is meant to generate arbitrary formats. The only production use case we have right now produces an XML file. To make the data viewable before download I use IF blocks to warp the xml in a textarea. This is just one possible way to deal with the issue. The main point is that this feature isn't mean to be HTML only. > 2) The patch commit line needs to be fixed. Fixed! > 3) I think we should change the label in the download menu to fit with the > others. It's a list of formats now, never including the word "Download", so > my suggestion would be something like: "HTML using [template] '