[Koha-bugs] [Bug 32767] Optionally allow for trimming whitespace from patron attribute values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Processing files before patches
|========================>| 10 / 10 (100.00%)
Processing files after patches
|========================>| 10 / 10 (100.00%)

 WARN   Koha/Patron/Attribute.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 8,
now: 10)
   OK     valid

 WARN   Koha/Patron/Attribute/Type.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 6,
now: 14)
   OK     valid

 WARN   Koha/Schema/Result/BorrowerAttributeType.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 47,
now: 49)
   OK     valid

 WARN   admin/patron-attr-types.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 62,
now: 65)
   OK     valid

 WARN   installer/data/mysql/atomicupdate/bug_32767-trim-attr-feature.pl
   OK     critic
   OK     file permissions
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 4)
   OK     valid

 FAIL   installer/data/mysql/kohastructure.sql
   OK     boolean_vs_tinyint
   OK     charset_collate
   OK     git manipulation
   FAIL   tinyint_has_boolean_flag
                The new column borrower_attribute_types.trim_value is using
TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/BorrowerAttributeType.pm), see the SQL12 coding guideline

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   SKIP   spelling
   OK     tt_valid
   OK     valid_template

 WARN   members/memberentry.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 318,
now: 319)
   OK     valid

 OK     opac/opac-memberentry.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 WARN   t/db_dependent/Koha/Patron/Attribute.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 84,
now: 104)
   OK     valid


Processing additional checks OK!

Running tests (1)
        * Proving /usr/share/koha/t/db_dependent/Koha/Patron/Attribute.t OK!

-- 
You are receiving this mail because:
You are watching all bug changes.