[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #29 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works as expected, here is a 2nd signoff :)

I couldn't get it to change the password of another user via editing and
resending the POST query 😈 and the code looks well guarded against that 👍

Code looks good functionally.

I found this:
`print $input->redirect(...)` followed by `exit;` is used in many other pages
to make guard closes. So it seems to me we can avoid wrapping the whole happy
path in an `else {...}`

That also avoids the need to indent tons of lines. Or to choose to not do it
which makes perltidy complain a lot. And about much more than actually changed
lines.

So just some polishing and it will be good :)
I'll go ask about what should be the default value of StaffLoginResetPassword
for new installs and existing installs.

-- 
You are receiving this mail because:
You are watching all bug changes.