[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #126 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi all. I know the history of this bug and am willing to overlook some things,
but as-is I believe this requires some more work.

High

* The GET /illbatches endpoint is not /ill/batchess?
* Illbatches.pm is too old school. Entirely relying on fetching the whole
resultset:
    #FIXME: This should be $c->objects-search
    my @batches = Koha::Illbatches->search()->as_list;
* And crafting the response manually, even the 'patron' attribute is done
manually instead of an embed
* The request body needs to be manually translated into the DB model:
    my $batch = Koha::Illbatch->new($body);
 we have Koha::Illbatches->new_from_api to avoid that. But there's obviously a 
 reason it wasn't done like that.

Lower

* Table names, and column names: this is using old school naming for things. We
can solve it on the API front, but even that is not entirely done.

Please let me know if there's anything I can do to help you with this.

-- 
You are receiving this mail because:
You are watching all bug changes.