[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708

--- Comment #112 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #105)
> Seeing things like this in qa tools:
> 
> DBIx::Class::Relationship::ManyToMany::many_to_many():
> ***************************************************************************
> The many-to-many relationship 'bundle_items' is trying to create a utility
> method
> called set_bundle_items.
> This will completely overwrite one such already existing method on class
> Koha::Schema::Result::Item.

"bundle_items", that's not related to this development.

It happens between the "before" and "after" the patch, we reload the different
module (and so the schema file), that's why you see the warnings.

(In reply to Marcel de Rooy from comment #106)
>         * Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/'
> seems invalid

We could add the whole team, but I think is what they want here.

(In reply to Marcel de Rooy from comment #107)
> $c->validation errors too in qa tools

Fixed.

Also fixed another bug.

(In reply to Marcel de Rooy from comment #109)
> And a few (innocent) notes during the process:
> 
> But keep in mind that a train can have items that have different processings
> (specific case, will see later).

Hum?

> RewriteRule ^/cgi-bin/koha/preservation/.*$
> /cgi-bin/koha/preservation/home.pl [PT]

Yes?

> ASK Shouldnt we have a few default NFL statuses added now ?

I don't think so. It really depends on how the library will use the module.
We could however add sample data in misc4dev.

> POST /api/v1/preservation/waiting-list/items: unhandled exception
> (Koha::Exceptions::Preservation::MissingSettings)<<The following parameter
> settings is required: PreservationNotForLoanWaitingListIn>>
> POST /intranet/svc/config/systempreferences
> Did not work at the start without warns or alerts.. Related to CSRF bug. Now
> solved, but error checking could be improved.

I don't think so. Discussed already in PM: this was a programming error, and a
programmer/reviewer must have the JS console opened (especially if something
wrong happened).
It's a whole global Koha question anyway, absolutely nothing directly related
to this bug.

> Home page
> Kind of weird to land at an empty page constantly.

Please see the kanban, still lot of things in mind.
https://tree.taiga.io/project/joubu-koha-preservation-module/us/2

Note that we have the same for ERM.

> user_train_item_id => $max + 1,
> Looking further, I wonder what is the exact use of this column? Cant really
> see when git grepping on it.

For display/info purpose. We want the items inside a given train to be
numbered.
This is the "ID" column displayed on the item table of the "show train" view.

> If a value is not in the AV list, or if it differs slightly, they would like
> to force the modification of the value, without creating a new authorised
> value.
> -            value: "Paraguay",
> => Not very clear.

(This is referring to bug 30708: Allow modifying attribute linked with AV to
another value)
Before this patch it was not possible de force the value of a dropdown list,
you had to select a value from the AV list.
With this patch it's possible to enter another value.
AV list is only there as suggestions, but not to force a choice.

Hence the rest of the commit message:
"""
Note that this could be a candidate for an option at the attribute
level if there are different needs (ie. for some attributes we don't
want to allow an other value).
"""

-- 
You are receiving this mail because:
You are watching all bug changes.