[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trying to do a first run through here, but I feel like we might want another
set of eyes maybe on the date calculations later on:

1) QA Test Tools

 FAIL   C4/Circulation.pm
   FAIL   critic
                # Variables::ProhibitUnusedVariables: Got 1 violation(s).  
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before:
1100, now: 1106)

 WARN   Koha/Schema/Result/Branch.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 222,
now: 226)

 FAIL   Koha/Schema/Result/BranchHour.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 18)

 WARN   admin/branches.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 47,
now: 58)

 WARN  
installer/data/mysql/atomicupdate/bug_6796_-_add_ConsiderLibraryHoursWhenIssuing_syspref.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 4)

 WARN   installer/data/mysql/atomicupdate/bug_6796_-_add_branch_hours_table.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 8)

 FAIL   t/db_dependent/Circulation/CalcDateDue.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 138,
now: 164)
   FAIL   valid
                Global symbol "$categorycode" requires explicit package name
(did you forget to declare "my $categorycode"?)
                Global symbol "$categorycode" requires explicit package name
(did you forget to declare "my $categorycode"?)
                t/db_dependent/Circulation/CalcDateDue.t had compilation
errors.


The last one I believe might be responsible for the unit tests not passing.
Please make always sure to run QA tests and unit tests on rebase:

Global symbol "$categorycode" requires explicit package name (did you forget to
declare "my $categorycode"?) at t/db_dependent/Circulation/CalcDateDue.t line
414.
Execution of t/db_dependent/Circulation/CalcDateDue.t aborted due to
compilation errors.
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/Circulation/CalcDateDue.t .. Dubious, test returned 255 (wstat
65280, 0xff00)


2) Terminology

a) ConsiderLibraryHoursWhenIssuing = instead of issue we usually use checkout,
but maybe ConsiderLibraryHoursInCirculation would be a good fit?

b) We have Koha::Library::Hours.pm, but Koha::Schema::Results::BranchHour - why
not use LibraryHour and also library_hours for the table name?

c) Issuing should be 'checking out' in system preference description: 
Take library opening hours into consideration to calculate due date when
issuing.

3) Database update

The 2 separate database updates for adding the pref and the table could have
been combined (not blocker).

a) The code comments should be removed form the kohastructure.sql file.

+/*!40101 SET @saved_cs_client     = @@character_set_client */;
+/*!40101 SET character_set_client = utf8 */;
+/*!40101 SET character_set_client = @saved_cs_client */;

4) Translatability

Our scripts always look for strings inside of HTML tags. Wrapping these in
spans will make it much easier on translators and possibly allow to 'reuse' the
existing translations for week days from other parts of Koha.

+[% BLOCK dayname %]
+    [% IF day == 0 %]
+    Monday
+    [% ELSIF day == 1 %]
+    Tuesday
+    [% ELSIF day == 2 %]
+    Wednesday
+    [% ELSIF day == 3 %]
+    Thursday
+    [% ELSIF day == 4 %]
+    Friday
+    [% ELSIF day == 5 %]
+    Saturday
+    [% ELSE %]
+    Sunday
+    [% END %]
+[% END %]


4) Library administration

a) The opening and closing times should also appear in the 'summary' table of
all libraries. (Don't forget to add to add to column configuration as well!)

b) It should also be present in the library 'view' page, that is accessible if
you don't have admin permissions.
http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL

c) TimeFormat is set to 24h format, but I still get presented with AM/PM on
data entry. It also doesn't follow CalendarFirstDayOfWeek. I'd think the first
would be more important. Maybe the curbside pickup GUI could give some ideas
here as I think we did fix the TimeFormat issue there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.