[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364

--- Comment #10 from David Nind <david at davidnind.com> ---
(In reply to Aleisha Amohia from comment #9)
> The patch applies and works for me.
> 
> You may find it easier to test using a record with only 1 item.

I had another go at testing, but I'm not sure I'm getting it right. Will leave
for someone else to test (or I'll try it fresh tomorrow!).

1. If I use a record with one item, for step 6 there is nothing in the holds to
pull queue (even after running the cronjob).

2. If I use a record with two or more items (for simplicity, items are all in
the same library), it appears on the holds to pull list both before and after
the patch is applied - this makes sense to me, as there is more than one item
available - both for a hold and the recall. (steps 9 and 11)

3. My recall rules:
   - Recalls allowed (total): 5
   - Recalls per record (count): 5
   - On shelf recalls allowed: If any unavailable
   - Recall due date interval (day): 5
   - Recall overdue fine amount: 5.00
   - Recall pickup period (day): 5

4. Patrons used: I changed three patrons so that they are all in the same
library (Centerville).

5. The tests fail after the patch for master was applied:

prove t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Item.t .. 22/30     # Looks like you planned 23 tests but
ran 24.
t/db_dependent/Koha/Item.t .. 25/30 
#   Failed test 'Recalls tests'
#   at t/db_dependent/Koha/Item.t line 2122.
t/db_dependent/Koha/Item.t .. 28/30 # Looks like you failed 1 test of 30.
t/db_dependent/Koha/Item.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/30 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Item.t (Wstat: 256 Tests: 30 Failed: 1)
  Failed test:  25
  Non-zero exit status: 1
Files=1, Tests=30, 13 wallclock secs ( 0.04 usr  0.02 sys +  8.30 cusr  3.56
csys = 11.92 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.