[Koha-bugs] [Bug 34886] Regression in when hold button appears

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886

--- Comment #25 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Tested Nick's patches.
Test plan works until step 10 where it fails for me.

Here's where it failed for me, k-t-d, On shelf holds policy = If any
unavailable:

- biblio 180 - 3 items withdrawn. 1 item not withdrawn:
OPAC logged out:
- detail page 'place hold' link: yes
- results page 'place hold' link: yes

OPAC logged in:
- detail page 'place hold' link: no  (step 10 fail)
- results page 'place hold' link: yes

I also tested with "If all unavailable" with 4 items withdrawn and, being that
all are unavailable, I would expect to be able to place holds, but the link
doesn't show for detail or results, logged in or not. Unless I'm
misunderstanding the intended behavior here (likely).

- Record 180 - 4 items withdrawn
OPAC logged out:
- detail page 'place hold' link: no
- results page 'place hold' link: no

OPAC logged in:
- detail page 'place hold' link: no
- results page 'place hold' link: no

Another funny thing I discovered is that, regardless of all of this, there is a
"Place hold" link on the top of the search results that always shows, and
always allows you to click it if you check at least one biblio which leads me
to think it's not considering any rule value at all.

-- 
You are receiving this mail because:
You are watching all bug changes.