[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #19)
> 1.
>  25 use C4::Koha;
>  26 use C4::Context;
> 
> in Koha/Template/Plugin/Notices.pm, there are not needed.

Fixed

> 
> 2.
> -                                                    [% CASE 'members'
> %]<span>Patrons</span>
> +                                                   [% CASE 'members'
> %]<span>Patrons</span>
> +                                                    [% CASE 'patron_slip'
> %]<span>Patrons toolbar (slip)</span>
>

Already tidied in the patchset

> 3. You removed printx_window but we still have:
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:                
> return printx_window( '[% CircAutoPrintQuickSlip | html %]' );

Fixed 

> 
> 4. Not blocker - changes in tools/letter.pl were not needed.

I add a condition in the first patch - tidied the whole block for consistency


> I can follow-up later this week but cannot right now.

Thanks for looking!

-- 
You are receiving this mail because:
You are watching all bug changes.