[Koha-bugs] [Bug 15504] Track Patron's Last Activity

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #96 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
OK. This looks almost ready to me. No panic please.
Here are some minor comments. The first and last one should get attention here
imo.

dbrev
Blocker
The default should probably be LOGIN IF TrackLastLogin was enabled.
Please adjust.

Preferences
Clearing all triggers is the same as turning off existing pref? Could we remove
it ? Here or in a follow-up ?

my $cache_key = "track_login_" . $self->userid;
No blocker. Would probably be better to cache with borrowernumber. Userid may
change?

+    Time::Fake->offset( $now->epoch + 5 );
No blocker, just teasing :)
You might have trouble in case you run the test close to midnight.
Could we cache the epoch value ?

-sub track_login {
-    my ( $self, $params ) = @_;
-    return if
-        !$params->{force} &&
Didnt we use force somewhere before?

Login from OPAC => Login
=> Staff login counts as well. I think we should just remove OPAC here.

This code still needs attention.
Blocker
koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
                [% IF Koha.Preference('TrackLastPatronActivity') %]
                    <li>
                        <label for="borrower_lastseen">who have not been
connected since:</label>
                        <input size="10" id="borrower_lastseen"
name="borrower_lastseen" type="text" class="flatpickr" />
                        <span class="hint">[% INCLUDE 'date-format.inc'
%]</span>
                    </li>
                [% END %]
AND Similarly:
misc/cronjobs/delete_patrons.pl
=item B<--last_seen>
Delete patrons who have not been connected since this date.
The system preference TrackLastPatronActivity must be enabled to use this
option.

-- 
You are receiving this mail because:
You are watching all bug changes.