[Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Test plan:
C4/Circulation.pm:
if($auto_renew =~ 'too_soon'){
$auto_renew is return from _CanBookBeAutoRenewed - will never be 'too_soon'

Check messages on opac-user

1 - Checkout 3 items to a patron, set for auto renewal, make sure due dates
are:
    Tomorrow
    2 days from now
    3 days from now
2 - Set 'norenewalbefore' rule for this patron's issues to be 2
3 - View patron in OPAC, renewal should be denied for all 3 items:
    Automatic renewal ( 5 of 5 renewals remaining )
4 - View patron in SCO, renewal should be denied for all 3 items:
    This item has been scheduled for automatic renewal and cannot be renewed
5 - View patron in staff interface, renewal should be denied for all 3 items
    Scheduled for automatic renewal(5 of 5 renewals remaining)
6 - Apply patch, updatedatabase, restart_all
7 - View circ rules, confirm new column 'no automatic renew before' with value
equal to 'no renewal before'
8 - View patron in OPAC, 1 item can be renewed (due tomorrow), other 2 have
updated message:
    Renew ( 5 of 5 renewals remaining ) This item is scheduled for auto
renewal.
    No renewal before 10/11/2023 ( 5 of 5 renewals remaining ) This item is
scheduled for auto renewal.
    No renewal before 10/12/2023 ( 5 of 5 renewals remaining ) This item is
scheduled for auto renewal.
9 - View patron in SCO, 1 can be renewed, updated messages on others:
    This item cannot yet be renewed. <Check in item> This item is scheduled for
automatic renewal
    This item cannot yet be renewed. <Check in item> This item is scheduled for
automatic renewal
    <Renew item> This item is scheduled for automatic renewal
10 - View patron in staff interface, 1 item can be renewed, other 2 have
updated message:
    No renewal before 10/12/2023(5 of 5 renewals remaining)
    No renewal before 10/11/2023(5 of 5 renewals remaining)
    <Checkbox>(5 of 5 renewals remaining)
11 - Update circ rule, set 'no renewal before' to 3
12 - Should now be able to renew items due tomorrow and 2 days ahead on all
interfaces
13 - Update circ rule, set 'no renewal before' to 4
14 - Should now be able to renew all items on all interfaces
15 - Renew 1 item on each interface, confirm success
16 - Check in items, checkout as before
17 - Update circ rules, set 'no renewal before' to 1
18 - Items cannot be renewed on any interface
19 - perl misc/cronjobs/automatic_renewals.pl -v
     found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
Issue id: 226 for borrower: 21 and item: 974 would not be renewed.
(auto_too_soon)
examining item '975' to auto renew
Issue id: 227 for borrower: 21 and item: 975 would not be renewed.
(auto_too_soon)
20 - Update circ rules, set 'no automatic renewal before' to 3
21 - perl misc/cronjobs/automatic_renewals.pl -v
     getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 227 for borrower: 21 and item: 975 would not be renewed.
(auto_too_soon)
22 - Update circ rules, set 'no automatic renewal before' to 4
23 - perl misc/cronjobs/automatic_renewals.pl -v
    getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
24 - Update circ rules, set 'no automatic renewal before' to 3
25 - perl misc/cronjobs/automatic_renewals.pl -v -c
     examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed.
(auto_too_soon)
26 - Nothing is renewed, because 'no renewal before' is 1, too_soon for all 3
27 - Update circ rules, set 'no renewal before' to 2
28 - perl misc/cronjobs/automatic_renewals.pl -v -c
     getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
Issue id: 228 for borrower: 21 and item: 973 will be renewed.
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed.
(auto_too_soon)
29 - Confirm 1 issue was renewed
30 - Update circ rules, set 'no renewal before' to 3
31 - perl misc/cronjobs/automatic_renewals.pl -v -c
    getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
Issue id: 228 for borrower: 21 and item: 973 will not be renewed.
(auto_too_soon)
examining item '974' to auto renew
Issue id: 229 for borrower: 21 and item: 974 will be renewed.
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed.
(auto_too_soon)
32 - Confirm a second issue was renewed
33 - Update circ rules, set both ...renew before to 4
34 - Confirm third issue was renewed

-- 
You are receiving this mail because:
You are watching all bug changes.