[Koha-bugs] [Bug 34881] Database update for bug 28854 isn't fully idempotent

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34881

--- Comment #8 from David Nind <david at davidnind.com> ---
Thanks for the alternative patch Emily! 

I've signed off as I don't get an error when running the database update.

If it shouldn't be signed off yet, please change the status back to needs
sign-off.


Running the database update - first time
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Following the test plan in #c4 I no longer get an error message when I run the
database update for the first time:

perl -e 'use C4::Installer; warn
Data::Dumper::Dumper(C4::Installer::run_db_rev("installer/data/mysql/db_revs/220600015.pl"));'
$VAR1 = {
          'output' => [
                        'Upgrade to 22.06.00.015  [20:11:52]: Bug 28854 - Item
bundles support',
                        '       Added new table \'item_bundles\'',
                        '       Added new system preference
\'BundleLostValue\'',
                        '       Added new system preference
\'BundleNotLoanValue\''
                      ],
          'filepath' => 'installer/data/mysql/db_revs/220600015.pl',
          'version' => '22.06.00.015',
          'exec_output' => 'Added new table \'item_bundles\'
Added new system preference \'BundleLostValue\'
Added new system preference \'BundleNotLoanValue\'
',
          'description' => 'Item bundles support',
          'bug_number' => '28854',
          'error' => undef,
          'time' => '20:11:52'


Running the database update - second time
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

perl -e 'use C4::Installer; warn
Data::Dumper::Dumper(C4::Installer::run_db_rev("installer/data/mysql/db_revs/220600015.pl"));'
$VAR1 = {
          'output' => [
                        'Upgrade to 22.06.00.015  [20:11:52]: Bug 28854 - Item
bundles support',
                        '       Added new table \'item_bundles\'',
                        '       Added new system preference
\'BundleLostValue\'',
                        '       Added new system preference
\'BundleNotLoanValue\''
                      ],
          'filepath' => 'installer/data/mysql/db_revs/220600015.pl',
          'version' => '22.06.00.015',
          'exec_output' => 'Added new table \'item_bundles\'
Added new system preference \'BundleLostValue\'
Added new system preference \'BundleNotLoanValue\'
',
          'description' => 'Item bundles support',
          'bug_number' => '28854',
          'error' => undef,
          'time' => '20:11:52'
        };



Running the database update - third and subsequent times
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

perl -e 'use C4::Installer; warn
Data::Dumper::Dumper(C4::Installer::run_db_rev("installer/data/mysql/db_revs/220600015.pl"));'
$VAR1 = {
          'bug_number' => '28854',
          'exec_output' => 'Added new table \'item_bundles\'
Added new system preference \'BundleLostValue\'
Added new system preference \'BundleNotLoanValue\'
',
          'filepath' => 'installer/data/mysql/db_revs/220600015.pl',
          'error' => undef,
          'version' => '22.06.00.015',
          'time' => '20:15:11',
          'output' => [
                        'Upgrade to 22.06.00.015  [20:15:11]: Bug 28854 - Item
bundles support',
                        '       Added new table \'item_bundles\'',
                        '       Added new system preference
\'BundleLostValue\'',
                        '       Added new system preference
\'BundleNotLoanValue\''
                      ],
          'description' => 'Item bundles support'
        };

-- 
You are receiving this mail because:
You are watching all bug changes.