[Koha-bugs] [Bug 35053] New: When placing a hold via the REST API if both biblio_id and item_id are passed the hold is placed on the item, but rules checked for the record

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 13 21:30:01 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35053

            Bug ID: 35053
           Summary: When placing a hold via the REST API if both biblio_id
                    and item_id are passed the hold is placed on the item,
                    but rules checked for the record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
                CC: tomascohen at gmail.com

In the checks we have:

if ( $item_id and $biblio_id ) {
....
   $biblio = Koha::Biblios->find($biblio_id);
...
}

$item does not get assigned, then later:

            my $can_place_hold
                = $item
                ? C4::Reserves::CanItemBeReserved( $patron, $item )
                : C4::Reserves::CanBookBeReserved( $patron_id, $biblio_id );

So while the item may not be holdable, we check if the bib is, then place the
hold using the item_id

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list