[Koha-bugs] [Bug 35078] Invalid HTML in OpacShowSavings system preference

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 19 01:55:08 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35078

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157252|0                           |1
        is obsolete|                            |

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 157366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157366&action=edit
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list