[Koha-bugs] [Bug 35107] New: ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107

            Bug ID: 35107
           Summary: ILL - Type disclaimer value and date should be visible
                    under "Request details" in the manage request page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pedro.amorim at ptfs-europe.com
                CC: pedro.amorim at ptfs-europe.com
        Depends on: 33716

Bug 33716 introduced this new feature.
At the time, testing was done with the FreeForm backend. FreeForm's metadata
method returns all available entries from illrequestattributes for a given
request.
Some backends may only provide a pre determined list of metadata keys, thus
possibly leaving out type_disclaimer_value and type_disclaimer_date.

To reproduce:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Set ILLModuleDisclaimerByType system preference , visit:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow
3) Copy the example code, click the "Click to edit" link to open the text area,
and paste the example yaml:
all:
 text: |
  <h2>HTML title</h2>
  <p>This is an HTML paragraph</p>
  <p>This is another HTML paragraph</p>
 av_category_code: YES_NO
article:
 text: copyright text for all article type requests
 av_category_code: YES_NO
 bypass: 1
4) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type "Book", put'9780822370451' in ISBN, put '42' in the cardnumber, and
pick a library
6) You should now be in the type disclaimer stage, click "Submit"
7) Notice the disclaimer value and date are displayed under "Details from
supplier"
8) Click the top "Switch provider" button and pick BLDSS
9) You should get one result, click the "Request BLL01018665793" link to finish
the migration
10) You should now be in the ILL table, click the request that was just
migrated to BLDSS
11) Notice the type disclaimer information is no longer visible


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716
[Bug 33716] ILL - Allow for a disclaimer stage per request type
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.