[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608

--- Comment #94 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
DONE 1) Changes to POD in Koha::Statistic are wrong in terms of consistency:
=> OK Surrendering. No problem. But I do think that these headers should be all
in uc. Much nicer :)

DONE 2) Koha::Statistic->_key_or_default feels bad. I'd prefer a ternary
operator. REMOVED

DONE 3) Koha::Statistic->insert means introducing a new pattern, and I don't
think we need it. I'd ask you to file a new bug for proposing that pattern and
have devs discuss it there, so this enhancement is not blocked.
=> Removed the method for now. Will resume this on 33636 probably.

DONE 4) C4/Stats.pm =>
+use Koha::Statistic;
^^ it should use the plural class.
=> Fixed in patch 5.

DONE 5) Probably for Martin's follow-up: if we are tidying an entire hash
structure, I usually suggest we sort keys on the same run. I can do it inline,
but thought it was worth mentioning explicitly.
=> Fixed two hashes that have been tidied.

DONE 6) This would benefit from some patch squashing.
=> Did some inline tidying removing the need for a tidy patch.

-- 
You are receiving this mail because:
You are watching all bug changes.