[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924

--- Comment #9 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Thanks for the follow-up - that fixed it!

It all works great now, except that the default text of the final renewal
notice is contradictory:

"The following item, Pro JavaScript techniques , has not been renewed because:

The following item, Pro JavaScript techniques , has correctly been renewed and
is now due on 10/23/2023
This item has reached the maximum number of unseen renewals and will need to be
renewed at the library."


It happens because the final renewal message is passed as an error even though
it's not really an error...which isn't ideal. It's easy to fix in
AUTO_RENEWALS, and a bit less so in AUTO_RENEWALS_DGST, but it does make me
wonder if we'd be setting ourselves up for issues with maintainability down the
road. Is there a better way to pass that information?


Testing notes for 3rd patch (handle final renewal errors):

Step 1 - Also need to set the system preference AutoRenwalNotices to "according
to patron messaging preferences"

Step 2 - The circ rule should set renewals to 4, unseen renewals to 2, and
Automatic Renewal to "yes" (setting both to 2 won't generate the "final unseen"
notice because the checkout will reach its final unseen renewal and its final
overall auto-renewal at the same time, and the overall limit takes precedence
in the notice)

Step 12 - already done above

Step 14 - need to update the issue to be due/overdue again before running the
script

-- 
You are receiving this mail because:
You are watching all bug changes.