[Koha-bugs] [Bug 35072] Invalid usage of "& " in JavaScript intranet-tmpl script redirects

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35072

M <schodkowy.omegi-0r at icloud.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |schodkowy.omegi-0r at icloud.c
                   |                            |om
             Status|NEW                         |Needs Signoff

--- Comment #7 from M <schodkowy.omegi-0r at icloud.com> ---
Created attachment 157654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157654&action=edit
Bug 35072: Fix invalid usage of "&" in JavaScript intranet-tmpl script
redirects

This patch fixes it in just JS templates, which is where it causes actual
breakage (as invalid HTTP requests are being sent).

It does not fix invalid escape occurences that might happen inside of Perl
templates (second case I've mentioned later), as those are silently handled by
this piece of code in case of CGI redirects:
https://metacpan.org/release/LDS/CGI.pm-3.48/source/lib/CGI.pm#L1630-1647

As such, this patch itself fixes only JS templates to keep things simple, and
is ready to be merged and fix the prime bug.

As for the second case with Perl templates, I'll wait for feedback on whether I
should look into that and make a patch as well, as that technically happens to
not break things, just isn't right pedantically...

-- 
You are receiving this mail because:
You are watching all bug changes.