[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Emily Lamancusa from comment #9)

> It happens because the final renewal message is passed as an error even
> though it's not really an error...which isn't ideal. It's easy to fix in
> AUTO_RENEWALS, and a bit less so in AUTO_RENEWALS_DGST, but it does make me
> wonder if we'd be setting ourselves up for issues with maintainability down
> the road. Is there a better way to pass that information?
> 

I adjusted the single renewal notice - the digest looks to me like it will come
out correctly.

I started trying to look into this, and it got much bigger. We could pass a
'success' flag for the regular notice, then check for the final in the
auto_renew_error field. If we just consider it to be 'status' rather than
'error' it feels less bad, adding a new column for tracking final seems
overkill to me. If acceptable, I'd like to see this work done on a new bug,
rather than changing the structure and adding feature at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.