[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am still a bit confused by this patch/script.

It looks like we always turn an empty line into a <br>. It seems an improvement
from previous behavior, but I wonder if it's correct.

What I would expect when the html flag is passed:
* If the notice template is already HTML, do not make any changes.
* If the notice is plain text, wrap in <pre>, do not add any additional line
breaks.

Why is the regex required at all? 

It seems to add additional breaks where they might not be needed/intended.
Especially with TT sometimes it's nice to add some line breaks separating
blocks etc. 

I thik we can now use the letter_id in message_queue to figure out if the
template is HTML if that helps things.

-- 
You are receiving this mail because:
You are watching all bug changes.