[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #28 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Looks great!

Added a follow-up to fix some checks when compiling result data for the digest
notices - CanBookBeRenewed was returning an $error value of 'auto-renew' for
successful autorenewals, while attempt_auto_renew returns an undefined $error
value in that situation (which makes sense - the subroutine already assumes
we're in an auto-renewal context after all). This was actually causing some
incorrect data to be passed to the digest notice, as well as a bunch of warns
for trying to access $error when it was undefined. Won't cause issues anywhere
else, though, since attempt_auto_renew isn't used outside the cron.

Other than that, QA tests pass, no regressions found, and everything looks
good. Thanks for the nice refactor and excellent added clarity to auto-renewal
notices!

-- 
You are receiving this mail because:
You are watching all bug changes.