[Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 158015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158015&action=edit
Screenshots - Before and after for step 23

I have tested (using koha-testing-docker).

For me, it looks like steps 19 and 23 in the test plan aren't working as
expected.

For both steps, I had to run the script twice. The first time three holds were
converted to recalls, and when run again the fourth hold was converted.

I'm also not sure how it works with having multiple recalls requested for the
same item by different patrons. Who gets the recall when it is returned and
checked in? What happens to the other recall?

Setup
~~~~~

Recall rules:
- Recalls allowed (total): 5
- Recalls per record (count): 5 
- On shelf recalls allowed: If any unavailable
- Recall due date interval (day): 5
- Recall overdue fine amount: 5.00
- Recall pickup period (day): 5

Record used, people used for checking out and recall requests:
- For Programming Perl (biblionumber=262) I added two more items, so that there
are three in total
- I checked out the items to Lisa Charles, Henry Acevedo, and Mary Burton
- I placed record level holds for Edna Acosta, Bobbie Middleton, Jordan Alford,
and Pamela Bennett

System preferences:
- ConvertedSelectedHoldsToRecalls =  one hold for each item available to be
recalled
- RecallsInterface = both the OPAC and the staff interface
- RecallsMaxPickUpDelay = 7
- UseRecalls = Use
- RecallsLog = Log

Step 19
~~~~~~~

I got the same results as for step 14 - three recalls requested, one hold
remaining

Output from running the script ONCE:

misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1
No reserves HOLD_CANCELLATION letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 588.
1. Hold converted to recall (reserve_id: 8, biblionumber: 262).
No reserves HOLD_CANCELLATION letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 588.
2. Hold converted to recall (reserve_id: 9, biblionumber: 262).
No reserves HOLD_CANCELLATION letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 588.
3. Hold converted to recall (reserve_id: 10, biblionumber: 262).

Output from running the script again:

kohadev-koha at kohadevbox:koha(bz32776)$
misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1
No reserves HOLD_CANCELLATION letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 588.
1. Hold converted to recall (reserve_id: 11, biblionumber: 262).


Step 23
~~~~~~~

I've attached some screenshots with the before and after results.

Setup similar to step 19 - additional details:

- Items checked out:
  . 987654321 - Checked out to Lisa Charles, item level hold by Jordan Alfred
  . 123456789 - Checked out to Henry Acevedo, item level hold by Pamela Bennett
  . 39999000011418 - Checked out to Mary Burton

- Holds, in priority order:
  1. Next available - Edna Acosta
  2. Next available - Bobbie Middleton
  3. Item 987654321 - Jordan Alfred
  4. Item 123456789 - Pamela Bennet

Results from running the script ONCE - I don't think that is the expected
result, but I'm not sure:
1. Holdings table - three holds converted to recalls: 
    . 987654321 - Checked out to Lisa Charles, recalled by Bobbie Middleton
(recall on patron record)
    . 123456789 - Checked out to Henry Acevedo, item level hold (no recall on
patron record for Henry)
    . 39999000011418 - Checked out to Mary Burton, recalled by Edna Acosta
(recall on patron record)
2. Holds tab - forth hold still showing as a hold (item-level hold by Pamela
Bennett for 123456789) 
3. Recalls tab:
   . Edna Acosta - recall requested for 39999000011418
   . Bobbie Middleton - recall requested for 987654321 (patron record shows
recall due to be returned - same date as Jordan Alford)
   . Jordan Alford - recall requested for 987654321 (patron record shows recall
due to be returned - same date as for Bobbie Middleton)

Results from running the script again:
1. Holdings table - three holds converted to recalls: 
    . 987654321 - Checked out to Lisa Charles, recalled by Bobbie Middleton
(recall on patron record) (NO CHANGE)
    . 123456789 - Checked out to Henry Acevedo, recalled by Pamella Bennett
(recall on patron record for Henry) (CHANGED FROM ITEM LEVEL HOLD TO A RECALL)
    . 39999000011418 - Checked out to Mary Burton, recalled by Edna Acosta
(recall on patron record) (NO CHANGE)
2. Holds tab - no holds 
3. Recalls tab:
   . Edna Acosta - recall requested for 39999000011418 (NO CHANGE)
   . Bobbie Middleton - recall requested for 987654321 (patron record shows
recall due to be returned) (NO CHANGE)
   . Jordan Alford - recall requested for 987654321 (patron record shows recall
due to be returned) (NO CHANGE)
   . Pamela Bennett - recall requested for 123456789 (patron record shows
recall due to be returned) (ADDITIONAL RECALL)

-- 
You are receiving this mail because:
You are watching all bug changes.