[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
All nice improvements!

The only thing I noticed with the WELCOME notice, is that it displayed OK for
me before the patch under Patrons > [Account] > Notices, but the email received
was all on one line. After the patch, there are extra lines displayed under
Patrons > [Account] > Notices, but the email received is now nicely formatted.
I tried using <p>s instead of <br/>s - no visible change for email message
received, and only slightly better under Patrons > [Account] > Notices. Better
that the email message that goes out is correct by default.

I changed the bug assignee 8-)

Testing notes (using KTD):

1. Add email to KohaAdminEmailAddress system preference. 

2. To test sending emails using a Google account:
   3.1 Set up an App password in your Google Account
   3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this
configuration near the end (where <user_name> = your Google email address;
<password> = your APP password, not your Google account password):

 <smtp_server>
    <host>smtp.gmail.com</host>
    <port>587</port>
    <timeout>5</timeout>
    <ssl_mode>STARTTLS</ssl_mode>
    <user_name>GOOGLEACCOUNTUSER</user_name>
    <password>GOOGLEAPPPASSWORD</password>
    <debug>1</debug>
 </smtp_server>

3. WELCOME
   - Before the patch:
     . Displays OK for me if you view the message under Patron > [Account] >
Notices
     . The email received (after running
misc/cronjobs/process_message_queue.pl) is all on one line
   - After the patch:
     . There are extra lines if you view the message under Patron > Notices
(not a showstopper for me - better that the email that goes out is correct)
     . The email received (after running
misc/cronjobs/process_message_queue.pl) is now correctly formatted and looks
great!
     . I tried using <p></p> tags instead of <br/> tags: the email message
comes through the same, the preview under Patrons > [Account] > Notices looks
slightly better, but still has extra lines
     . Not sure what the best way to do this is!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.