[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Nick Clemens from comment #12)
> I don't know if I agree with these patches.
> 
> Rules for placing a hold and rules for filling a hold are not the same.
> 
> Being allowed to place 0 holds is different than these holds are not allowed.
> 
> It's subtle, and confusing, but its designed this way and libraries use
> overrides to place holds that a patron can't place, but they expect to fill

Hi Nick, 

It was nice to meet you in person at KohaCon23 :)

Thank you for your feedback.

Looking at these patches in retrospect, I agree. 
I have conflated placing and filling holds which could cause unintended
consequences with respect to overrides. 

That being the case I am going to close this bug report.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.