[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579

Émily-Rose Francoeur <emily-rose.francoeur at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158100|0                           |1
        is obsolete|                            |

--- Comment #13 from Émily-Rose Francoeur <emily-rose.francoeur at inLibro.com> ---
Created attachment 158104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158104&action=edit
Bug 31579: Improve reserve/request.pl to avoid mistakes with pick up locations

The patch has been updated to ensure it does not break the existing behavior.
The test plan have also been updated.

This patch improve the behavior of the intranet reservation page
cgi-bin/koha/reserve/request.pl
It ensures that when you change the "pickup at" value in the "Hold details"
section, the "Allowed pickup locations" values of each item are also changed
(in the table)

System preferences

        ensure that "UseBranchTransferLimits" is set to "Don't enforce"

Prerequisites

        have 4 different branches (libraries):
                library A - logged in library, the one used to log into the
intranet by the employee
                library B - item's home library
                library C - item's holding library found in the file of the
user who will have the reservation
                library D - another library

        have 2 library groups (each of them is set as "Is local hold group"):
                group A - contains "library A" and "library B"
                group B - contains "library C" and "library D"

        have a record with multiple copies
                create an item for each library A, B, C, D with homebranch =
holdingbranch (with barcode)

Circulation rules

        in the "Circulation and fine rules", under "Default holds policy by
item type":
                select the same item type you use for the items you created
before
                set "Hold pickup library match" to "item's hold group"
                click on "+ Add"

Test plan

        1- Find a user record
        2- Change the user library (set it to library C) and save
        3- Click on "Search to hold"
        4- Find the notice you created
        5- Click on "Place a hold > Place hold for [User]"
        6- Check the "pickup at" field in the top section and those in the
column "Allowed pickup locations"
        7- Change the library of the top "pickup at" field
        8- Check the "Allowed pickup locations" of each item
        9- Notice that the "Allowed pickup locations" columns are not adjusted
        10- Apply the patch
        11- Refresh the page
        12- Repeat steps 6,7 and 8
        13- Notice that the pickup locations change only if they are in the
same library group
        14- Go to "Circulation and fine rule" (in Koha administration) and
delete the the rule you created under "Default holds policy by item type"
        15- Repeat step 1,3,4,5,6,7 and 8
        16- Notice that all the "Allowed pickup locations" columns are adjusted

-- 
You are receiving this mail because:
You are watching all bug changes.