[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #28 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to David Cook from comment #27)
> If you ran ./misc/devel/install_plugins.pl against all instances, it would
> be a paralyzing load on a large shared hosting server, yes.

:( Too bad. Thanks for the real world knowledge. I was hopping the actual
compile would happen on the 1st request.

Also, are there cases of a single main starman for all workers of a large
shared hosting? Or would that be a bad setup and we don't have the duty to
worry about instances that went out of their way to achieve this? And for such
a setup, instance wide reload might not be a paralyzing load because
*hopefully?* when spawning many workers at the same time from the *same* main
starman process, it might not compile 100 times Koha's minimal base code but
only once and they fork 100 time almost for free. (the last is suppositions, if
not waiting for requests to do the compiling, then it would make sense to
benefit for mutualising compiling work)

> If it was just on a web upload or a single install for
> ./misc/devel/install_plugins.pl then it should be fine since it would just
> be restarting 1 starman master process.
> 
> Certainly something to be careful with...
> 
> I'm a bit apprehensive about giving a web user the ability to restart
> Starman.

It still happens on it's own every 100 queries by default (50 X the number of
workers, 2 by default) on most Koha's right? And can be triggered by someone
knowing that it existing like as a way to mitigate this very issue.
install/upgrade/uninstall a plugin and spam F5 on a light page to make the
operation effective ^^"

What bad stuff could happen if an end user (managing plugins) can trigger a
worker reload?

-- 
You are receiving this mail because:
You are watching all bug changes.