[Koha-bugs] [Bug 31652] Add geo-search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 154388
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154388
Bug 31652: Add geo-search

Review of attachment 154388:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31652&attachment=154388)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ +592,5 @@
>          [% Asset.js("js/openlibrary.js") | $raw %]
>      [% END %]
> +    [% IF ( GeoSearchEnabled ) %]
> +        <link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.1/dist/leaflet.css" integrity="sha256-sA+zWATbFveLLNqWO2gtiw3HL/lh1giY/Inf1BJ0z14=" crossorigin=""/>
> +        <script src="https://unpkg.com/leaflet@1.9.1/dist/leaflet.js" integrity="sha256-NDI0K41gVbWqfkkaHj15IzU7PtMoelkzyKp8TOaFQ3s=" crossorigin=""></script>

As Frido suggested, we don't link out to externally hosted static files. Lots
of reasons for that.

Koha already has leaflet.js and leaflet.css although a much older version:
1.0.3+ed36a04

I'd suggest opening a separate issue to upgrade Leaflet and then having that be
a dependency of this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.