[Koha-bugs] [Bug 33245] Add $patron->is_active

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 1 08:23:56 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> Please amend and tidy the patches.

Will submit.

> +        $dt = dt_from_string()->subtract( days => 180 ); # default fallback
> Where is 180 coming from?

The 180 is a fallback as noted in the comment. Normally you should pass the
desired number of days, months to the routine. The follow-up patch does this in
a cron script:

Bug 33522
+    my $patron_active = $recent->is_active({ months => $active // $inactive
}); # checked already that only one is defined

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list