[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #12)
Thanks for QA.

> Why not using reservestatus for 
> 
> +                <input type="checkbox" name="filter_reservestatus_or_C"
> value="C" /> Cancelled
> +                <input type="checkbox" name="filter_reservestatus_or_F"
> value="F" /> Filled
> +                <input type="checkbox" name="filter_reservestatus_or_P"
> value="P" /> Placed
> +                <input type="checkbox" name="filter_reservestatus_or_W"
> value="W" /> Waiting
> 
> ?

For several reasons:
[1] Completely improving this part of code is not in scope. Look at the changes
here. They improve and resolve a bug. Further work can be done, but is not
required here.
[2] The reservestatus refers to the routine in C4/Reserves. Which has some
interesting comments:
## FIXME: I don't think this does what it thinks it does.
## It only ever checks the first reserve result, even though
## multiple reserves for that bib can have the itemnumber set
## the sub is only used once in the codebase.
It does not know Cancelled or Filled which are important in reporting here.
So in short, that routine needs attention. Cannot be forced here.
[3] This script needs a solution in SQL not in Perl. We cannot call Perl for
each row in the query and impact performance negatively. Implementing this
needs much more changes than the current scope requires.

Please have another look.

-- 
You are receiving this mail because:
You are watching all bug changes.