[Koha-bugs] [Bug 32980] Checkouts for guarantees are not shown if patron also has a guarantor

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Sep 4 17:00:00 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32980

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #12)
> Any good reasons to not use TestBuilder?
I have some reasons... not sure if they're good enough:
- I'm used to DBIx::Class API and always forget how to use TestBuilder, so it's
faster for me to write it like that (okay that one is not that good, I'm just
lazy).
- TestBuilder populates all columns, which can make tests fail randomly.
Without it I don't have to think about those cases.
- TestBuilder is not really useful in a simple case like this IMO
- While writing tests I like to commit transaction and explore the database to
see what's going wrong. And it's a lot easier when it's not filled with
"AI37AMe2_0aESHPuxgZVLAmwHXOohDl" in every column.

I'm ok with your patch but I don't understand why you took the time to write
it. Is it mandatory to use TestBuilder in test files ?
What do we gain ? Certainly not speed because it now takes 40% more time for
the test to complete.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list