[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Sep 6 01:15:01 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Ok so this seem to implement the UNIMARC part of the initial request of the
ticket.
C4::Heading::MARC21->new() does nothing compared to C4::Heading::UNIMARC->new()
I guess the equivalent code might be somewhere else, weird.
Though what Andreas found doesn't seem to be the same as what Martin analyzed
at the beginning. So maybe it two different optimizations that can be stacked.

So anyway, this could keep moving as UNIMARC only and in the end another ticket
can be made for if the same could be done for MARC21. And/or keeping the
initial proposal of Martin. (not sure if I understood well what we have here
and the initial idea)

---

The relevant tests seem to be *at least*:
prove t/db_dependent/Biblio.t t/db_dependent/Heading.t

They fail when when I sabotage C4::Heading::UNIMARC->new()

But I can't tell in the detail if they test enough regarding the changes of
this patch.
No idea about eventual side effects of skipping stuff when $bib_heading_fields
if defined. It's likely 100% redundant but I don't have the insight to be sure.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list