[Koha-bugs] [Bug 34400] Inconsistencies in OAI sets page titles, breadcrumbs, and header

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 155035
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155035
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header

Review of attachment 155035:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34400&attachment=155035)
-----------------------------------------------------------------

Overall, I think it's looking pretty good, but I did note a new inconsistency
introduced by this patch.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
@@ +29,4 @@
>  
>          [% IF ( op_new || op_mod ) %]
>              [% WRAPPER breadcrumb_item %]
> +                <a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets</a>

This change makes the breadcrumb inconsistent with oai_set_mappings.tt though.

@@ +44,5 @@
>              [% END %]
>  
>          [% ELSE %]
>              [% WRAPPER breadcrumb_item bc_active= 1 %]
> +                <span>OAI sets</span>

This change makes the breadcrumb inconsistent with oai_set_mappings.tt though.

-- 
You are receiving this mail because:
You are watching all bug changes.