[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 155233
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155233
Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and
header

Review of attachment 155233:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34412&attachment=155233)
-----------------------------------------------------------------

I have a few comments but none of them are blockers imo

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
@@ +13,4 @@
>          [% END %] ›
>      [% END %]
>      [% IF ( add_validate ) %]
> +        [% t("Preference added") | html %] ›

I couldn't find a way to see this text but I'm not too worried about it.

@@ +91,5 @@
>  
>  [% IF ( add_form ) %]
> +        <h1>
> +            [% IF ( modify ) %]
> +                Modify a local use system preference

I think this could probably be "Modify preference '[% searchfield | html %]'",
but not a deal breaker.

@@ +283,5 @@
>      [% END %]
>      
>      [% IF ( delete_confirm ) %]
> +        <div class="dialog alert">
> +            <h1>Confirm deletion of [% searchfield | html %]?</h1>

It would be a good idea to wrap [% searchfield | html %] in single quotes, but
since this is the same before and after the change I don't think it's in scope.

-- 
You are receiving this mail because:
You are watching all bug changes.