[Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 155255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155255&action=edit
Bug 34724: Remove inline onclick handler for opac-imageviewer.pl

This patch moves the click handler for thumbnails for opac-imageviewer.pl
out of the inline HTML and out to an existing <script> element.

Test plan:
0. Apply the patch (including dependent patches)
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover
2. Change both *LocalCoverImages sysprefs to "Show"
3. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers
4. Change "AllowMultipleCovers" to "Allow"
5. Click "Images (0)" tab
6. Download or make two JPEG images
7. Upload the images
8. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29
9. See one large image in the centre and two smaller thumbnails on the right
side
10. Click on the thumbnail of the image that isn't displayed in the centre
11. Note that the image changes
12. Click the other thumbnail and note that the image changes back

-- 
You are receiving this mail because:
You are watching all bug changes.