[Koha-bugs] [Bug 34726] New: Clicking the title of a record in cart creates URL with duplicate query strings

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Sep 6 09:00:50 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726

            Bug ID: 34726
           Summary: Clicking the title of a record in cart creates URL
                    with duplicate query strings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

If you click a title in the OPAC cart, it will create a URL like the following:

http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=114?biblionumber=114

This is because of competing functionality in the template and the Javascript.
The output of the following "biblio_a_href" is fed into "openBiblio". 

koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
[% BLOCK biblio_a_href -%]
    [%- IF Koha.Preference('BiblioDefaultView') == 'marc' -%]
        [%- SET this_biblio_href =
"/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=" -%]
    [%- ELSIF Koha.Preference('BiblioDefaultView') == 'isbd' -%]
        [%- SET this_biblio_href =
"/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=" -%]
    [%- ELSE -%]
        [%- SET this_biblio_href = "/cgi-bin/koha/opac-detail.pl?biblionumber="
-%]
    [%- END -%]
    [%- this_biblio_href | url %][% biblionumber | url -%]
[%- END %]


koha-tmpl/opac-tmpl/bootstrap/js/basket.js
function openBiblio(dest,biblionumber) {
    var openerURL = dest + "?biblionumber=" + biblionumber;
    opener.document.location = openerURL;
    opener.focus();
}

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list