[Koha-bugs] [Bug 34707] Abstract intranet-tmpl/includes/*-search.inc

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34707

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> I am not sure, that's a lot of different variables to define. Also some inc
> files are included from different places, you are going to duplicate this
> new big block.
> 
> Another approach (to test!) would be to define all the 'tabs' in a single
> include, then pass the idea from the tt?
> 
> include would contain all those blocks (here is one):
> +    {
> +        id          => 'city_search',
> +        is_active   => 1,
> +        is_allowed  => 1,
> +        label       => 'Search cities',    #TODO:translate
> +        icon        => 'fa-building',
> +        form_action => undef,
> +        form_id     => undef,
> +        form_method => 'POST',
> +        inputs      => [
> +            {
> +                id          => 'city_name_filter',
> +                name        => 'city_name_filter',
> +                type        => 'text',
> +                value       => city_name_filter,
> +                placeholder => 'City search',
> +                class       => 'head-searchbox form-control',
> +            }
> +        ]
> +    },
> 
> and tt would simply include:
> [% INCLUDE header-search-tabs.inc tabs => ['city-search', 'circ_search',
> 'catalog_search'] %]

s/idea/ids

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.