[Koha-bugs] [Bug 34666] _Findgroupreserve is not returning title level matches from the queue for holds with no item group

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34666

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154984|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 155267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155267&action=edit
Bug 34666: Allow item_group to be null and still match

The current logic requires that the grop ids match, but this eliminates null
matches
from the group.

The fallout essentially is that the queue won't be checked to fill holds in
cases of title level matches
where holds don't have an item group id. The queue checks the transport cost
matrix while the check reserves
check does not, so this may have an impact on holds costs and delivery times

To test:
0 - Apply unit test patch
1 - prove -v t/db_dependent/Reserves.t
2 - It fails
3 - Apply this patch
4 - prove -v t/db_dependent/Reserves.t
5 - It passes!

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.