[Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Sep 7 15:11:38 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 155300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155300&action=edit
Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link
gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change
anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists,
then the imagenumber must also exist
The link does not contain translatable strings, it doesnt need to be repeated
twice in if-else just for a css class change

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list