[Koha-bugs] [Bug 34339] $c->validation should be avoided (part 2)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34339

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 WARN   Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 25,
now: 27)
 WARN   Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 54,
now: 56)
 WARN   Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 21,
now: 24)

=> Just warnings. No reason to block pushing imo.

Corrected Koha/REST/V1/ERM/Licenses.pm
-        my $license    = $c->objects->find( Koha::ERM::Licenses->search,
$license_id );
+        my $license = $c->objects->find( Koha::ERM::Licenses->new,
$c->param('license_id') );

prove t/db_dependent/api/v1/erm*
t/db_dependent/api/v1/erm_agreements.t ........... ok
t/db_dependent/api/v1/erm_documents.t ............ ok
t/db_dependent/api/v1/erm_eholdings_packages.t ... ok
t/db_dependent/api/v1/erm_eholdings_resources.t .. ok
t/db_dependent/api/v1/erm_eholdings_titles.t ..... ok
t/db_dependent/api/v1/erm_licenses.t ............. ok
t/db_dependent/api/v1/erm_users.t ................ ok
All tests successful.
Files=7, Tests=24, 78 wallclock secs ( 0.15 usr  0.05 sys + 68.57 cusr  5.75
csys = 74.52 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.