[Koha-bugs] [Bug 17499] Koha objects for messaging preferences

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #205 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Overall looks very good to me. Great job. And with so much patience :)

A few minor remarks (for the record, no blockers)
+=head3 new_from_default
+
+NOTE: This subroutine initializes and STORES the object (in order to set
+message transport types for the preference), so no need to call ->store when
+preferences are initialized via this method.

=> This might be a bit confusing. Do not store immediately? No blocker (waited
too long, etc)

+=head3 find_with_message_name
+
+Koha::Patron::Message::Preferences->find_with_message_name({
+    borrowernumber => 123,
+    message_name => 'Hold_Filled',
+});

This should be a search instead of a find imo. No blocker.
Note that there is a search_with.. too ?

+=head2 Internal methods
Recently someone failed my patches for something like this. I wont do that here
:)

QA tools mentions a few untidy lines. Please ignore them now in view of time
passed.

The big question is however: Who sets the next step and applies this stuff in
favor of C4 Messaging routines?

-- 
You are receiving this mail because:
You are watching all bug changes.