[Koha-bugs] [Bug 33087] OPACHoldsIfAvailableAtPickup considers On order as available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I dont understand this patch. Looks wrong.
Now we are only saying Unavailable if it is notforloan.
But the idea of the pref is that you are not allowed to place holds on items
not on loan. This could include on order, right?

Another thing coming to my mind is that the original condition does not even
look at items which are really notforloan.
So is this query really correct:
   my $items_in_this_library = Koha::Items->search({ biblionumber =>
$item->biblionumber, holdingbranch => $item->holdingbranch });

Please clarify.

-- 
You are receiving this mail because:
You are watching all bug changes.