[Koha-bugs] [Bug 33087] OPACHoldsIfAvailableAtPickup considers On order as available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Hammat wele from comment #6)
> (In reply to Marcel de Rooy from comment #4)
> > I dont understand this patch. Looks wrong.
> > Now we are only saying Unavailable if it is notforloan.
> Not exactly, we are saying Unavailable if the notforloan field is positive
> that means for the items with notforloan field has these values: Not For
> Loan or Staff Collection or Added to bundle or any other positive value.

Sure. We mean the same.

> By default, the on order (Ordered) has a negative value -1 referred to
> auth_val.yml
> NOT_LOAN	-1	Ordered

Sure :)

> so the " && $item->notforloan >= 0 " condition will allow place hold on item
> when notforloan is negative (Ordered) by not putting their holdingbranch in
> the not_available_at list because those items are technically not
> "available" so we can put place them on hold

Yeah. But is it the right spot?

(In reply to Marcel de Rooy from comment #4)
> Another thing coming to my mind is that the original condition does not even
> look at items which are really notforloan.
> So is this query really correct:
>    my $items_in_this_library = Koha::Items->search({ biblionumber =>
> $item->biblionumber, holdingbranch => $item->holdingbranch });

What about looking here to the notforloan field ?
If notforloan<>0 (positive or negative), the item cannot be issued. So it would
be unfair to take it along in the count comparison.
If we exclude them here, there is no reason to add the condition later. And we
technically solve a broader bug.

-- 
You are receiving this mail because:
You are watching all bug changes.