[Koha-bugs] [Bug 34767] New: SIP2 fee acknowledgement flag on renewals is passed, but not used

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34767

            Bug ID: 34767
           Summary: SIP2 fee acknowledgement flag on renewals is passed,
                    but not used
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: david at davidnind.com,
                    koha-bugs at lists.koha-community.org,
                    nick at bywatersolutions.com,
                    testopia at bugs.koha-community.org

C4/SIP/ILS.pm
436 sub renew {
437     my ($self, $patron_id, $patron_pwd, $item_id, $title_id,
438     $no_block, $nb_due_date, $third_party,
439     $item_props, $fee_ack) = @_;

The $fee_ack variable is lost in the transition to
C4::SIP::ILS::Transaction::Renew.. we need to clone it across as we do for the
checkout message transaction.

This is important, as without passing this on, one cannot renew items where
charges apply.

To test:
1) Add a rental charge to an itemtype
2) Checkout an item of that itemtype to a user
3) Attempt a renewal of that item via SIP2 and note that it fails
4) Pass the fee_acknowledgement bit in renewal and note the renewal still
fails.

This can be achieved using the sip_cli_emulator (after applying bug 34764 to
fix it's mishandling of passing the fee_ack bit)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.