[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

--- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've added a minor follow-up to restore a little of the original styling and
wording from the Privacy Policy feature.

Doing the above made me wonder if the 'description' display for plugin
generated consent types should not be wrapped in <p>.. allowing for plugin
authors to have more control over the final display of the description (for
example adding a warning box as we do for the privacy policy one again now).

I'm not 100% sure about the Koha::Patron->consent($type) accessor introduced
here.. but I can see why you've done it that way and this patchset has been
through a few iterations already.. so not a blocker.

I'm also not in total agreement around the new system preference introduced. I
believe you've done this for performance reasons but I tihnk we could work
around it with caching instead.. again.. I don't think this should be a
blocker.

Finally.. and this one may be more of a blocker.  I'm not sure how one would go
about translating the description blocks introduced by plugins. We could pass
language (or rely on context) through the available types method.. in fact,
perhaps that's the answer.. we just leave it to the plugin author to look at
lang from context and return the right thing when 'patron_consent_type' is
called.  I'd love to see this in the example plugin to highlight it's possible
and works.. I may add that shortly if I can find a few more minutes.

Generally, though, I'm happy with this and feel it can move forward. I'd love
one final QA set of eyes.. I'll ask around for you.

-- 
You are receiving this mail because:
You are watching all bug changes.