[Koha-bugs] [Bug 20859] Enter SMS number and SMS provider during self registration

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

--- Comment #17 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
I think the question is, why does the condition contain

&& !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id')

# which will only show the section if both fields are enabled

instead of something like

&& ( !hidden.defined('smsalertnumber') || !hidden.defined('sms_provider_id') )

# which will show the section as long as at least one field is enabled

I hadn't looked that closely at the code when I signed off, but that's a good
point - from what I understand, knowing the SMS provider of individual patrons
isn't always needed, so a library may want to hide sms_provider_id but still
show smsalertnumber.

There's no real use for knowing the provider without the number, though, so
maybe the answer is to simplify the condition and only check whether
smsalertnumber is hidden at that point.

-- 
You are receiving this mail because:
You are watching all bug changes.