[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149784|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 155767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155767&action=edit
Bug 33364: [22.05] Prevent Holds to Pull from including items with pending
recalls

This patch changes the check for pending recalls to include items in transit,
as well as items awaiting pickup, to fill a recall request.

It then ensures the Holds to Pull report excludes items that have pending
recalls.

To test:

1. Enable UseRecalls and set the recalls-related circulation rules
2. Check out an item to Patron A
3. Place a hold on the item for Patron B
4. Log into the OPAC as Patron C and search for the item. Place a recall on the
item.
5. Go back to the staff interface. Go to Circulation -> Holds to pull
6. Confirm the item shows in the Holds to pull table, with the hold for Patron
B
7. Check in the item and confirm the recall as waiting
8. Go back to the Holds to pull page. You may need to manually regenerate the
page by running the cronjob in the terminal
misc/cronjobs/holds/build_holds_queue.pl
9. Notice that even though the item is allocated for a recall, the hold is
showing. It should not be showing in this page.

10. Apply the patch and refresh the page

11. The item allocated to a recall should no longer be showing in the Holds to
pull report

12. Go to the record detail page and go to the Recalls tab
13. Revert the recall from its waiting status
14. The record will now show on the Holds to pull page
15. Go to the Circulation -> Check in page
16. Go to the menu in the top-right of the page and click Set library
17. Change your library to a different one
18. Check in the item to confirm the recall as waiting and trigger a transfer
19. Go back to the Holds to pull page, regenerate if needed
20. The item should no longer show on the Holds to pull report

21. Confirm tests pass t/db_dependent/Koha/Item.t

Sponsored-by: Auckland University of Technology

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.