[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653

--- Comment #12 from David Nind <david at davidnind.com> ---
(In reply to Evan Giles from comment #10)
> Hi David
> 
> I did see the "Commit Messages" wiki page, and tried to follow the
> guidelines there.  Apologies for being difficult, but could you please let
> me know which conventions I missed in the commit message?  It's not obvious
> to me as a beginner..
> 
> I don't know if it helps, but I have just installed & configured "git bz" to
> re-upload the patch.  I see that it's done some things differently (maybe
> better?)
> 
> Any advice welcome!
> Thanks

Hi Evan.

It looks like it was my mistake - I was expecting to see the bug title,
description and test plan as part of comment #6. Looking at the details for the
obsoleted patches, it looks like it was there all along!

I'm not sure, but I guess it must depend on how the patch is attached to the
bug.

I normally (using koha-testing-docker) I go:
- git so X
- git bz attach -e bugnumber HEAD~X..
(where X = the number of patches)

It all looks good now, and I've signed off.

Thanks!

David

-- 
You are receiving this mail because:
You are watching all bug changes.